- 29 7月, 2019 5 次提交
-
-
由 Daniel Gustafsson 提交于
Fixing a small bug in my regexp searching for duplicates yielded two additional hits. Fix by adding to the mailmap file.
-
由 Daniel Gustafsson 提交于
It seems that the duplicate prototype snuck in during the 8.4 merge, which should've been mostly a noop as I had synced pgcrypto with 8.4 in 16d26ee9. I had however placed the prototype on the wrong line and so git merge was able to cleanly place the protype a few lines down, creating a duplicate.
-
由 Daniel Gustafsson 提交于
The gpstringsubs program replaces tokens in input .source test files when creating output .sql/.out files for pg_regress. There were no more callsites for the gp_glob_connect token however so remove that, and also remove tests for gpwhich_<binary> tokens which aren't in use in tests and thus might start failing randomly, which is exactly what happened in another patch where Perl programs were no longer incorrectly installed in PATH. Without this, removing the Perl test apps from PATH results in errors like this: which: no get_ereport.pl in ( .. ) Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
-
由 Xiaoran Wang 提交于
The test cases of gpfdist_ssl sometimes fail on pipeline. We don't know the root cause yet. So just disable them. And we will enable them after fixing.
-
由 Chen Mulong 提交于
* Fix quirk of isolation2 test - Fix the line continuation behaviour and document Instead of matching "; *$" to detect the end of a sql end, the original code was using ";$". This creates a totally different output for tests like: a) SELECT * FROM t1; SELECT * FROM t2; b) SELECT * FROM t1;<space> SELECT * FROM t2; For a), two SELECT statements will be sent separately. For b), they will be sent together as "SELECT * FROM t1; SELECT * FROM t2;" Spaces are playing too much magic here, some of them could be a bug in the test itself. For example, the oom_query test should NOT pass since it misses error output in the expected. This change unifies the behaviours by matching with "; *$". So if a line is end with ';', no matter spaces follows it or not, the statement will be sent at once. - Document the known issue of multi SQL in one line. This issue was found during debugging pipeline failure of #8211 Authored-by: NChen Mulong <muchen@pivotal.io>
-
- 27 7月, 2019 4 次提交
-
-
由 Soumyadeep Chakraborty 提交于
We accidentally skipped the fts probe on the primary in f2ca17a0 when it should be skipped on the master. The fault point 'fts_probe' can only be encountered on the master.
-
由 Shreedhar Hardikar 提交于
Also, bump ORCA version to 2.61.0
-
由 Shreedhar Hardikar 提交于
Also bump version to 3.60.0.
-
由 Ashwin Agrawal 提交于
This function was modified in GPDB just for pg_regress. pg_regress needs to locate gpdiff.pl and gpstringsubs.pl scripts where it uses find_other_exec(). Since not correct version was passed to it, this modification was required to find_other_exec(). These scripts have code to correctly print the version information on "-V". So, regular unmodified version of find_other_exec() works if the version is passed correctly from pg_regress. Reviewed-by: NAsim R P <apraveen@pivotal.io> Reviewed-by: NDaniel Gustafsson <dgustafsson@pivotal.io> Reviewed-by: NHeikki Linnakangas <hlinnakangas@pivotal.io>
-
- 26 7月, 2019 14 次提交
-
-
由 Adam Berlin 提交于
-
由 Adam Berlin 提交于
- Adds hint to user on how to disable FTS. - Registers warnings outside of the core injection framework This allows us to create warnings that are GPDB specific, for things like FTS without tainting the core framework which is theoretically Postgres-only dependent.
-
由 Heikki Linnakangas 提交于
We don't build the HTML docs in GPDB like we do in PostgreSQL, but let's be tidy anyway. * We don't allow tabs in SGML files. There's a "make check-tabs" target to check for them. * Fix reference to non-existing SQL-ALTERROLE-title sections. (Should be SQL-ALTERROLE) * Fix copy-pasto in link to ALTER RESOURCE GROUP. * In func.sgml, a tag was typoed. * In pg_dumpall.sgml, the term-tag is not allowed in this part in DocBook format. Reviewed-by: NLisa Owen <lowen@pivotal.io>
-
由 Weinan WANG 提交于
When a failed raised by `CREATE DATABASE`, relevant files, directories should not be leftover. Add new DB information into `pendingDbDeletes` list, so that promise `CREATE DATABASE` as a 2pc safe command. Co-authored-by: NAsim R P <apraveen@pivotal.io>
-
由 Adam Lee 提交于
ExecMaterializeSlot() transformed any tuple to a virtual tuple via slot_getallattrs(), then formed a heaptuple from it, ctid was lost here since virtual tuples have no system columns. This commit copies the entire htup directly if we have a regular physical tuple but not locally palloc'd.
-
由 Francisco Guerrero 提交于
An elusive missing header file was detected when the Ubuntu job failed in CI. Centos and Mac did not show any indication of a missing header file and no side effects were detected. However, Ubuntu was returning an int32 in makeDefElem instead of a 64-bit pointer. Co-authored-by: NAshwin Agrawal <aagrawal@pivotal.io> Co-authored-by: NJesse Zhang <jzhang@pivotal.io> Co-authored-by: NFrancisco Guerrero <aguerrero@pivotal.io>
-
由 David Yozie 提交于
* Docs: Using 'Postgres Planner' terminology consistently * Postgres planner -> Postgres Planner * remove another reference to 'legacy' planner * Few more fixes
-
由 David Yozie 提交于
* Remove syntax options for creating OIDS; add pivotal-only statements of non-support * Some edits from Lisa * Clarify error with oids on partitioned/co table. * Feedback from Mel * Add deprecation/removal wording suggested by Rob
-
由 David Yozie 提交于
* Add centos7 command to start config.service * Add some text around starting immediately
-
由 Mel Kiyama 提交于
-
由 Amil Khanzada 提交于
postgresql_conf_gp_addition is just an example for what can be injected into postgresql.conf via gpinitsystem, but the values in there make little sense to ship for production. It has not been changed in many years and is mistakenly copied into the files we distributed with Greenplum (via gpMgmt/Makefile target that copies bin/ files). Authored-by: NAmil Khanzada <akhanzada@pivotal.io>
-
由 Amil Khanzada 提交于
There is different build system code that defines which contrib extensions are built and installed. gpAux/Makefile should not be building any contrib extensions. Authored-by: NAmil Khanzada <akhanzada@pivotal.io>
-
由 Francisco Guerrero 提交于
Currently, PXF is not propagating the format options in the external table framework. In Foreign Data Wrappers, these options are defined at the foreign table-level and are being propagated to PXF. In order for the PXF Server to better support both FDW and external tables we are consistently passing format information from both clients.
-
由 mkiyama 提交于
-
- 25 7月, 2019 12 次提交
-
-
由 Heikki Linnakangas 提交于
The PostgreSQL 9.2 merge introduced a couple of new cursor options, including CURSOR_OPT_GENERIC_PLAN, which clashed with the 0x0040 value that we were already using in GPDB for the GPDB-specific CURSOR_OPT_UPDATABLE option. Fix the conflict. The CURSOR_OPT_UPDATABLE flag was used in cursors opened in PL/pgSQL, so the mixup caused generic plans to be used for all PL/pgSQL cursors. Add a test case for that. The PostgreSQL 9.2 merge happened in GPDB 6, so backport to GPDB 6. Reviewed-by: NAsim R P <apraveen@pivotal.io> Reviewed-by: NPengzhou Tang <ptang@pivotal.io>
-
由 Heikki Linnakangas 提交于
Git stores the 'x' flag for files in the repository. For no good reason, some files had it set differently from upstream. It's harmless, but let's avoid spurious differences.
-
由 Heikki Linnakangas 提交于
These were removed from upstream years ago already, but were left over in GPDB for some reason. GPDB never supported these.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
-
由 Daniel Gustafsson 提交于
Happened to spot two variations from pairing stations.
-
由 Adam Berlin 提交于
Ooops. We only injected the skip fault for fts once, causing a race condition in the test. Here's the problematic timeline: 1. Inject skip fault for fts 2. Fts runs, skip fault is gone 3. Panic primary 4. Inject Noop record into mirror 5. Promote mirror 6. Noop record never replayed and test fails.
-
由 Heikki Linnakangas 提交于
I don't know what purpose this might have served originally, but it's unused now. Reviewed-by: NAsim R P <apraveen@pivotal.io>
-
由 Abhijit Subramanya 提交于
This guc allows the optimizer to estimate the cardinality in case of DPE much more accurately. On the TPC-DS test suite, it improves the execution time for query 13 from 114s to 28s and for query 48 from 84s to 34s.
-
由 congnan.luo 提交于
This is initial version of README to document FTS details. Lot more details need to be captured to completely cover FTS working, but this acts as good starting point. I (Ashwin) performed minor touch-ups to the README. Reviewed-by: NAsim R P <apraveen@pivotal.io> Reviewed-by: NPengzhou Tang <ptang@pivotal.io>
-
由 dyozie 提交于
-
由 Bhuvnesh Chaudhary 提交于
For partitioned tables, in case of DELETE/UPDATE operation on the root table, we must acquire ExclusiveLock on the root and leaf partitions, so that any other operation requesting lock higher than AccessShareLock and ShareLock must wait on QD. If we don't acquire lock for the leaf partitions, other concurrent DML operation may be dispatched to the segments and a deadlock can occur. Refer to the test case added for GDD. resultRelations may not have all the entries including the root and leaf partition tables, so in this fix we explicitly acquire locks on all the tables. While GDD is on, it will be able to detect the deadlock and cancel one of the query, so we don't acquire locks on the leaf parts if the DML operation is on the root. Co-authored-by: NAlexandra Wang <lewang@pivotal.io> Signed-off-by: NAlexandra Wang <lewang@pivotal.io> Co-authored-by: NAlexandra Wang <lewang@pivotal.io>
-
- 24 7月, 2019 5 次提交
-
-
由 Daniel Gustafsson 提交于
gpnetbench is an always installed binary which is shipped for every production release of Greenplum, so it may as well live in src/bin which is intended for just those binaries. The gp* namespace ensure that it's presence won't collide with upstream additions, and since we want to get rid of gpAux/ we must start moving these tools from there anyways. No functional changes are introduced, apart from the Makefile now supporting "make uninstall" as well. Reviewed-by: NJimmy Yih <jyih@pivotal.io>
-
由 Daniel Gustafsson 提交于
The whole target is quite dubious and should be removed in favor of just using 'make -C gpMgmt install', but until I know how this file is at all used then let's at least clean out the worst offenders. Reviewed-by: NBradford D. Boyle <bboyle@pivotal.io>
-
由 Daniel Gustafsson 提交于
The greenplum_path target was referencing a program which no longer exists and is thus dead code, and the devel_failtinj is no longer defined at all. Reviewed-by: NBradford D. Boyle <bboyle@pivotal.io>
-
由 Daniel Gustafsson 提交于
The gpAux Makefile was checking for GCC version to ensure that GPDB is compiled with the minimum version required. This is a layering violation since we should be doing these checks in autoconf. Should the compiler be let through autoconf then we are good to go, further checking should not (need to) be performed. The version checked for is also quite ancient by now, the odds of it being the compiler on a system which can compile the rest of the codebase is slim to none. Reviewed-by: NBradford D. Boyle <bboyle@pivotal.io>
-
由 Heikki Linnakangas 提交于
It was made unused by commit 8eed4217Co-authored-by: NPengzhou Tang <ptang@pivotal.io>
-