Signed-off-by: NCorbin Halliwill <challiwill@pivotal.io>

Signed-off-by: NRyan Tang <rtang@pivotal.io>

* Tighten the criteria for partition validation

Add additional case when source and destination attributes are different.

Authors: Larry Hamel, Marbin Tan, Chris Hajas

Ignore cursor case to get CI passed for now. Have submitted two issues
to track it.
Signed-off-by: NPengzhou Tang <ptang@pivotal.io>

This is hopefully a temporary change to increase stability of the pipeline.

So far we were assuming that the content of `llvm_isNull_ptr` variable, which is passed as
input to expression evaluation, is always `false`. Consequently, when the result of the
expression is not null, we avoid setting `llvm_isNull_ptr` to `false`.

However, this assumption is not correct since in codegen we do not use a temporary `fcinfo`
struct (for perfromance reasons), which initializes `fcinfo->isnull` to `false`.
Instead, we pass a pointer to the isnull variable of the caller directly (which might not
have been inititialized). For example, in `GenerateAdvanceAggregates` we pass a pointer
to `transValueIsNull`.

In this commit, we explicitly set `llvm_isNull_ptr` to `false` when the result is not null.
This will cover all cases that the input is not initialized to `false`.
Signed-off-by: NKarthikeyan Jambu Rajaraman <karthi.jrk@gmail.com>

Codegened advance_aggregares did not support null attributes. With this
patch, we enhance it with checks for strict functions and create the
proper arguments' nullity checks accordingly.

Authors: Nikos Armenatzoglou and Jimmy Yih

With this commit adding infrastructure scripts to enable running catalog and
storage tests in Concourse containers natively. Using this infra interatively
will be migrating CS tests suites to concourse.

This avoids a lot of overhead for short read-only queries. We still don't
do lazy assignment for most transactions, like PostgreSQL 8.3 does, but
this is a step in the right direction.

Replace sleeps with deterministic check for database operational, after
injecting PANIC faults.

In moving the AO table format version to be a segment version, bump
the catversion to ensure that existing clusters are rebuilt to handle
the new format.

Segments that are still in an old format are treated as read-only. All new
data go to new segments, in new format. This allows us to eventually get
rid of the old format completely.

This is hypothetical until we have pg_upgrade working for GPDB 4.3 -> 5.0
upgrade, as you can't have old-format tables or segments at all in a
cluster that's initialized with 5.0. Stay tuned for pg_upgrade, but this
is preparatory work for that.

This meant moving the version field from pg_appendonly to the
pg_aoseg_<oid> table (or pg_aocsseg_<oid>, for AOCS). We can still read
and write both formats, but new segments will always be created in the new
format (except if you set the test_appendonly_version_default GUC).

Ensure that that the header guards match the actual name of the
file.

Remove unused fields from past version control systems and ensure
that all filenames in the comments match the actual name of the file.
Also fix some spelling and references.

pgstat_write_statsfile() failed to write the resource queue statistics
to the stat file which in turn makes the pg_stat_resqueues view empty.

Patch by Github user LJoNe with testcase added by me

gporca has a set of banned API calls which needs to be allowed with the
ALLOW_xxx macro in order for gpopt to compile. But it should be the
library caller(GPDB/Orca)'s resposibility to take care of the function call.

see discussions on greenplum-db/gpdb#1136
and https://groups.google.com/a/greenplum.org/forum/#!topic/gpdb-dev/Mcw6JPav6h4

* Adding support for interrupt processing before reserving more vmem.

* Process pending interrupts before reserving VMEM.

* Adding guc to control vmem tracker checking for interrupts before reserving more vmem.

.psqlrc can create unexpected output and changes in formatting that don't play nice with parse_oids().

```
psql database --pset footer -Atq -h localhost -p 5432 -U gpadmin -f /tmp/20161012232709/toolkit.sql

{"relids": "573615536", "funcids": ""}
Time: 2.973 ms
```

Generates an Exception:
```
Traceback (most recent call last):
  File "/usr/local/greenplum-db/./bin/minirepro", line 386, in <module>
    main()
  File "/usr/local/greenplum-db/./bin/minirepro", line 320, in main
    mr_query = parse_oids(cursor, json_str)
  File "/usr/local/greenplum-db/./bin/minirepro", line 151, in parse_oids
    result.relids = json.loads(json_oids)['relids']
  File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/__init__.py", line 307, in loads
    return _default_decoder.decode(s)
  File "/usr/local/greenplum-db/ext/python/lib/python2.6/json/decoder.py", line 322, in decode
    raise ValueError(errmsg("Extra data", s, end, len(s)))
ValueError: Extra data: line 2 column 1 - line 3 column 1 (char 39 - 54)
```

In many places where we had used a mixture of spaces and tabs for
indentation, new versions of gcc complained about misleading indentation,
because gcc doesn't know we're using tab width of 4. To fix, make the
indentation consistent in all the places where gcc gave a warning. Would
be nice to fix it all around, but that's a lot of work, so let's do it
in a piecemeal fashion whenever we run into issues or need to modify a
piece of code anyway.

For some files, especially the GPDB-specific ones, I ran pgindent over
the whole file. I used the pgindent from PostgreSQL master, which is
slightly different from what was used back 8.3 days, but that's what I had
easily available, and that's what we're heading to in the future anyway.
In some cases, I didn't commit the pgindented result if there were
funnily formatted code or comments that would need special treatment.

For other places, I fixed the indentation locally, just enough to make the
warnings go away.

I also did a tiny bit of other trivial cleanup, that I happened to spot
while working on this, although I tried to refrain from anything more
extensive.

Update storage types of cidr and inet in AOCO_Compression2,
schema_topology and schema_topology_optimizer expected files.

Related commit: 3e23b68dSigned-off-by: NPengzhou Tang <ptang@pivotal.io>

Aggressive inlining can improve performance in hot spots, but when applied
indiscriminately, it makes binaries larger for little gain. For lack of
better evidence, let's trust the compiler defaults. This makes the build
faster, and the binaries smaller. If we find out that these options are
beneficial for some specific functions or source files, let's add them
back to those special cases.

In a quick test on my laptop, this makes the build about 2x faster, and
shrinks the binaries from about 14MB to 9MB (after running "strip").

Signed-off-by: NGang Xiong <gxiong@pivotal.io>

- In ORCA, due to the way exception handled previously we do warning first
and then later print error referring that message. In this commit, we
enhanced the exception handling so we just print a single error message.
- Also, we removed 'PQO unable to generate a plan' or 'Aborting PQO plan
generation' message and make the error message as close as the planner.
- Updated error message with filename and line number from where the exception
is raised.

Due to 31edbadf, concatenating two
integers is not supported by both GPDB and latest PostgreSQL, so we need
to explicitly cast the integers in this tpch_query case.
Signed-off-by: NPengzhou Tang <ptang@pivotal.io>
Signed-off-by: NGang Xiong <gxiong@pivotal.io>

Environment variables of QD should not be included in the startup packet when making connections to segments.
Add ICG test case to guarantee the QD env variable should not effect GUCs on segments
Signed-off-by: NPengzhou Tang <ptang@pivotal.io>

constant format strings, so that the compiler can more easily check the
formats for correctness.

 Conflicts:
	src/backend/postmaster/postmaster.c
	src/interfaces/ecpg/pgtypeslib/dt_common.c

Commit ff3474e2 which removed the gp_partition_* catalog functions
left some auxiliary code behind which is now unused. Remove the now
dead functions and while in there, put back the filename in the file
headercomment to match other files.

The inconsistency between using tabs and spaces caused a compiler warning
from GCC 6.2, with -Wmisleading-indentation.

* Removing invalid assertion that checks to ensure we don't do further allocations under dead accounts. The whole idea of a index based accounting is to not care about dead accounts and transparently handle those via RolloverAccount without hitting a SEGV.

* Including MEMORY_OWNER_TYPE_EXECUTOR_END as a valid owner type as this enum value overlaps with the last valid executor account type.

These .sql files assumed that the timezone for machines running the
TINC tests would have the timezone as PST/PDT. This commit explicitly
sets the timezone to PST in the .sql files and updates the .ans files
to handle this new behavior.

This was done so that the below TINC tests could run on Concourse
containers which use UTC time zone:
-cs-storage
-cs-uao

Current codegen expression evaluation framework generates code based only on
ExprState->Expr->type (e.g., T_Var), without checking the ExprState->type.
In other words, it treats all nodes of the tree that have the same type
(e.g., T_Var) in the same way (i.e., generates the same code).

However, in GPDB the evaluation function (evalfunc) of a node depends
on ExprState->Expr->type and ExprState->type. For example, if
ExprState->Expr->type = T_Var and ExprState->type = T_ExprState, then
the evalfunc  = ExecEvalScalarVar. On the other hand, if
ExprState->Expr->type = T_Var and ExprState->type =
T_WholeRowVarExprState, then evalfunc = ExecEvalWholeRowVar.

We fix this issue by avoiding code generation for an expression tree
that contains nodes of unsupported ExprState->type.
Signed-off-by: NKaren Huddleston <khuddleston@pivotal.io>