- 31 3月, 2017 14 次提交
-
-
由 Daniel Gustafsson 提交于
When creating a table using the CTAS construction with an explicit distribution clause, the duplicate check for distribution columns wasn't applied: CREATE TABLE tt AS SELECT * FROM t DISTRIBUTED BY (c,c); Move the duplicate distribution check to the parsing stage since it is a syntax error to supply duplicate column references. This alters the behavior such that supplying a duplicate non-existing column will error out on the duplication rather than the column being non-existing. Since syntax errors should have precedence over semantic errors I however find that this is the correct order. Remove the existing duplicate checks which only applied to CREATE TABLE and ALTER TABLE, and add test cases to cover CTAS. The ticket reference was removed since it's not public and also clearly didn't cover all the cases. The DROP TABLE is also moved to not using IF EXISTS since it would be an error if the table didn't exist at that point.
-
由 Heikki Linnakangas 提交于
Digging into the git history, it was removed sometime during the 8.2 (sic) merge, back in 2006. I don't think it was intentional.
-
由 Heikki Linnakangas 提交于
It was added back in 2009. Seems quite clear at this point that we're not going to change how this works.
-
由 Heikki Linnakangas 提交于
It was added back in 2010, as part of a patch to: commit d0ca3d8a4333db510ac68145c30ff917626d2037 Author: kentj <a@b> Date: Mon Jan 25 13:50:14 2010 -0800 MPP-7734: initialize executor nodes for the active slice instead of the whole tree. Postponding the initialization of the subplans of an Append node to the time when it is processed. Send init gpmon packages for the subnodes of the Append node even though we don't initialize them. [git-p4: depot-paths = "//cdb2/main/": change = 43428] However, it was reverted only a few weeks later: commit 5cb7e64a093dfcc1bcbdca5ed74c261e9c56d3a3 Author: kentj <a@b> Date: Tue Feb 16 16:40:49 2010 -0800 MPP-8031, MPP-7734: revert back the Append changes, since it breaks the explain analyze. It is hard to fix the explain analyze with the existing Append changes. It needs some more thinking. [git-p4: depot-paths = "//cdb2/main/": change = 45078] The revert removed all use of the flag, but left the flag behind. Remove it.
-
由 Heikki Linnakangas 提交于
-
由 Heikki Linnakangas 提交于
A HashJoin would always have an outer_plan, hence the if-statement was pointless. It was added a long time ago in GPDB, due to a bug that was related to Adaptive Joins. We haven't had Adaptive Joins for ages, so it was dead code.
-
由 Heikki Linnakangas 提交于
-
由 Christopher Hajas 提交于
This reverts commit b20a3f92 and 37cdd250 since the gptransfer suite is failing.
-
由 Peifeng Qiu 提交于
S3QueryAbort's message was hardcoded to "Query is aborted". This commit initializes it via constructor.
-
由 Adam Lee 提交于
-
由 Christopher Hajas 提交于
This was missed in b20a3f92
-
由 Larry Hamel 提交于
Signed-off-by: NChumki Roy <croy@pivotal.io>
-
由 Chris Hajas 提交于
Instead of simply printing which files are different, print the contents of the diff files.
-
由 Todd Sedano 提交于
-
- 30 3月, 2017 12 次提交
-
-
由 Todd Sedano 提交于
-
由 Daniel Gustafsson 提交于
The gp_create_table suite tests that the maximum number of columns can be specified as a distribution clause (well, it really tests that CREATE TABLE allows the maximum number of columns since that check applies first), and then tests to CTAS from the resulting table. There is no reason to believe that there is a difference between CTAS with 1600 columns and CTAS with fewer columns. Remove this case to speed up the test significantly and also adjust the DROP TABLE clauses to match reality.
-
由 Daniel Gustafsson 提交于
Rather than relying on always having a full cloned repository when building, add fallbacks which work for trees with constrained (such as shallow-cloned trees), or no, history. When the tagged commit is reachable, use git describe, else rely on the version string in configure since that's required to always be there regardless of distribution mode. If we have git tree then include the HEAD sha1 as well. While there, clean up versioning to more clearly separate us from upstream.
-
由 Adam Lee 提交于
Enable existing GPPC tests and move more from TINC to ICW to get higher coverage. For now we keep gppc_test, gppc_demo and tabfunc_gppc_demo test suites separate, may investigate more and merge them. Signed-off-by: NAdam Lee <ali@pivotal.io> Signed-off-by: NYuan Zhao <yuzhao@pivotal.io>
-
由 mkiyama 提交于
[ci skip]
-
由 foyzur 提交于
Relocating memory usage dump from ExecutorEnd to MemoryAccounting_Reset() as we no longer call ExecutorEnd upon abort. This ensures that we dump memory usage (if configured) once per command before resetting memory accounting. (#2113)
-
由 Jesse Zhang 提交于
Not to be confused with a TINC test with the same name. This test was brought into the main suite in b82c1e60 as an effort to increase visibility into all the tests that we cared about. We never had the bandwidth to look at the intent of this test though. There are a plethora of problem of the bugbuster version of `schema_topology`: 0. It has very unclear and mixed intent. For example, it depends on gphdfs (which nobody outside Pivotal can build) but it just tests that we are able to revoke privilege of that protocol. 0. It creates and switches databases 0. The vast number of cases in this test is duplicating coverage for tests elsewhere in `installcheck-good` and TINC. Burning this with fire.
-
由 Omer Arap 提交于
-
由 Jamie McAtamney 提交于
This commit splits up the single backup.feature file (where each scenario both dumps and restores data) into two files, dumps_only.feature which performs all necessary dumps and is run against a 4.3 database and restores_only.feature which performs the corresponding restores and is run against a 5 database. It also adds and/or modifies Behave steps to account for differences in functionality between 4.3 and 5. It uses the installed GPDB python version when running behave tests. This is necessary when running different versions of Greenplum with the same behave feature file. Authors: Karen Huddleston, Chris Hajas, Todd Sedano
-
由 Chris Hajas 提交于
gpdbrestore improperly filters out blocks that contain drop statements. BEGIN..END blocks from dumps should always be included in the restore.
-
由 Chuck Litzell 提交于
-
由 Chumki Roy 提交于
* Remove a previously deprecated utility * Remove mentions of gpsnap Signed-off-by: NMarbin Tan <mtan@pivotal.io>
-
- 29 3月, 2017 3 次提交
-
-
由 Heikki Linnakangas 提交于
Commit fae97ae7 accidentally removed the prototype for matrix_add(), even though it didn't remove the function itself. Put back the prototype, to silence compiler warning about missing prototype.
-
由 Daniel Gustafsson 提交于
These datafiles were no longer used by any test, remove since they will otherwise just linger in there.
-
由 Ashwin Agrawal 提交于
[ci skip]
-
- 28 3月, 2017 5 次提交
-
-
由 Daniel Gustafsson 提交于
Error tables were removed in 5.0 but the syntax for creating them on external tables in pg_dump was left in. Remove the offending INTO <relname> syntax to ensure restoring works in 5.0+. Apply to pg_dump and cdb_dump_agent.
-
由 Daniel Gustafsson 提交于
appendPQExpBuffer() is a variadic function which interprets the second parameter as a printf format string. Where we just append a static string, use appendPQExpBufferStr() instead which is much faster. Where a single char is added, use appendPQExpBufferChar().
-
由 Daniel Gustafsson 提交于
When merging upstream releases, or inventing new GPDB specific code, new object types may be required to be added to pg_upgrade. This documents the process on a broad level.
-
-- it is red in pipeline with a report of OoM, but that could actually be a symptom of a missing library. This reverts commit e4976920.
-
由 Marbin Tan 提交于
* Rewrite Kerberos test suite * Remove obsolete Kerberos test stuff from pipeline and TINC We now have a rewritten Kerberos test script in installcheck-world. * Update ICW kerberos test to run on concourse container This adds a whole new test script in src/test/regress, implemented in plain bash. It sets up temporary a KDC as part of the script, and doesn't therefore rely on a pre-existing Kerberos server, like the old MU_kerberos-smoke test job did. It does require MIT Kerberos server-side utilities to be installed, instead, but no server needs to be running, and no superuser privileges are required. This supersedes the MU_kerberos-smoke behave tests. The new rewritten bash script tests the same things: 1. You cannot connect to the server before running 'kinit' (to verify that the server doesn't just let anyone in, which could happen if the pg_hba.conf is misconfigured for the test, for example) 2. You can connect, after running 'kinit' 3. You can no longer connect, if the user account is expired The new test script is hooked up to the top-level installcheck-world target. There were also some Kerberos-related tests in TINC. Remove all that, too. They didn't seem interesting in the first place, looks like they were just copies of a few random other tests, intended to be run as a smoke test, after a connection had been authenticated with Kerberos, but there was nothing in there to actually set up the Kerberos environment in TINC. Other minor patches added: * Remove absolute path when calling kerberos utilities -- assume they are on path, so that they can be accessed from various installs -- add clarification message if sample kerberos utility is not found with 'which' * Specify empty load library for kerberos tools * Move kerberos test to its own script file -- this allows a failure to be recorded without exiting Make, and therefore the server can be turned off always * Add trap for stopping kerberos server in all cases * Use localhost for kerberos connection Signed-off-by: NMarbin Tan <mtan@pivotal.io> Signed-off-by: NChumki Roy <croy@pivotal.io> Signed-off-by: NLarry Hamel <lhamel@pivotal.io>
-
- 27 3月, 2017 6 次提交
-
-
由 Daniel Gustafsson 提交于
The tiny2 suite was a cut-down version of qp_derived_table with no new tests added. The stransaction suite was already covered by the ICW suites gpdtm_plpgsql and trasaction. Neither of these two suites were no longer connected to any test schedule.
-
由 Peifeng Qiu 提交于
Signed-off-by: NYuan Zhao <yuzhao@pivotal.io>
-
由 Heikki Linnakangas 提交于
Now that external tables use resource owners to clean up on abort, we no longer need to ensure that ExecutorEnd gets called on failed portals. Remove PG_TRY-CATCH block in nodeAgg.c that's no longer needed. This demonstrates well why we should not call ExecutorEnd on abort; there might well have been more places that previously needed a PG_TRY-CATCH block like this, but didn't have one. See also discussion on this on the gpdb-dev mailing list: https://groups.google.com/a/greenplum.org/forum/#!topic/gpdb-dev/-BTKTbLuP1k Re-applying this since the blocker was removed by ca3f5520. Signed-off-by: NAdam Lee <ali@pivotal.io>
-
由 Adam Lee 提交于
The old cdbfast test suite had these, move to ICW. Signed-off-by: NAdam Lee <ali@pivotal.io> Signed-off-by: NYuan Zhao <yuzhao@pivotal.io>
-
由 Adam Lee 提交于
Generate certificates for gpfdists then place them into master and segments' data directories. After this commit, specifying gpfdist's `--ssl` option with `$MASTER_DATA_DIRECTORY/gpfdists` could enable gpfdists protocol for gpdemo. Also update `lalshell` to remove unnecessary lines. Signed-off-by: NAdam Lee <ali@pivotal.io> Signed-off-by: NYuan Zhao <yuzhao@pivotal.io>
-
由 Daniel Gustafsson 提交于
[ci skip]
-