Replace docker-image with registry-image.

For context, the registry-image resource was introduced more than two years ago as a drop-in replace for the docker-image resource (especially when you're only fetching, not building). It's leaner, less resource-intense, faster, and doesn't rely on spawning a Docker daemon. Also swept up in this patch are four unused files that are left behind by previous changes. See https://github.com/concourse/registry-image-resource for more. This is spiritually a cherry-pick of be6ff30f, but I'm only touching the 5X_STABLE pipeline and the PR pipeline because they are in my way of backporting 868fd2d7 and 6aac45f3 (clang-format check).

Replace docker-image with registry-image.
For context, the registry-image resource was introduced more than two years ago as a drop-in replace for the docker-image resource (especially when you're only fetching, not building). It's leaner, less resource-intense, faster, and doesn't rely on spawning a Docker daemon. Also swept up in this patch are four unused files that are left behind by previous changes. See https://github.com/concourse/registry-image-resource for more. This is spiritually a cherry-pick of be6ff30f, but I'm only touching the 5X_STABLE pipeline and the PR pipeline because they are in my way of backporting 868fd2d7 and 6aac45f3 (clang-format check).
c8993c2c · Jesse Zhang · 472e263c · c8993c2c · c8993c2c · c8993c2c
3 changed file
--- a/concourse/pipelines/5X_STABLE-generated.yml
+++ b/concourse/pipelines/5X_STABLE-generated.yml
@@ -308,17 +308,17 @@ groups:

 resource_types:
 - name: terraform
-  type: docker-image
+  type: registry-image
  source:
    repository: ljfranklin/terraform-resource
    tag: 0.11.14
 - name: pivnet
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotalcf/pivnet-resource
    tag: latest-final
 - name: gcs
-  type: docker-image
+  type: registry-image
  source:
    repository: frodenas/gcs-resource

@@ -338,7 +338,7 @@ resources:
    uri: {{ccp-git-remote}}

 - name: ccp-image
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ccp
    tag: '7'
@@ -444,43 +444,43 @@ resources:
    uri: ((debian-release-git-remote))

 - name: centos-gpdb-dev-6
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-gpdb-dev
    tag: '6-gcc6.2-llvm3.7'

 - name: centos-gpdb-dev-7
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-gpdb-dev
    tag: 7-gcc6.2-llvm3.7

 - name: oracle-gpdb-test-7
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/oracle7-test
    tag: gpdb5-latest

 - name: ubuntu-gpdb-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpdb-dev
    tag: '16.04'

 - name: ubuntu16.04-test
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu16.04-test
    tag: gpdb5-latest

 - name: ubuntu-gpdb-debian-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpdb-debian-dev
    tag: '16.04'

 - name: ubuntu-gpcloud-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpcloud-dev
    tag: '16.04'
@@ -488,7 +488,7 @@ resources:
    password: {{docker_password}}

 - name: centos-mingw
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-mingw

@@ -857,7 +857,7 @@ anchors:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -952,7 +952,7 @@ set_failed_anchor: &set_failed
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: "7"
@@ -979,7 +979,7 @@ set_failed_two_clusters_anchor: &set_failed_two_clusters
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: "7"
@@ -1005,7 +1005,7 @@ dpm_debug_sleep_anchor: &dpm_debug_sleep
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
          tag: latest
@@ -2011,7 +2011,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2525,7 +2525,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2688,7 +2688,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -3122,7 +3122,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -3221,7 +3221,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3299,7 +3299,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3377,7 +3377,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3662,7 +3662,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3695,7 +3695,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3715,7 +3715,7 @@ jobs:
        - name: ccp_src
        - name: gpdb_src
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3766,7 +3766,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3798,7 +3798,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3818,7 +3818,7 @@ jobs:
        - name: ccp_src
        - name: gpdb_src
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3883,7 +3883,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -3943,7 +3943,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -4283,7 +4283,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:

--- a/concourse/pipelines/pr_pipeline.yml
+++ b/concourse/pipelines/pr_pipeline.yml
 resource_types:
  - name: pull-request
-    type: docker-image
+    type: registry-image
    source:
      repository: teliaoss/github-pr-resource

  - name: gcs
-    type: docker-image
+    type: registry-image
    source:
      repository: frodenas/gcs-resource

@@ -34,7 +34,7 @@ resources:
      uri: {{gpaddon-git-remote}}

  - name: centos-gpdb-dev-6
-    type: docker-image
+    type: registry-image
    source:
      repository: pivotaldata/centos-gpdb-dev
      tag: '6-gcc6.2-llvm3.7'

--- a/concourse/pipelines/templates/gpdb-tpl.yml
+++ b/concourse/pipelines/templates/gpdb-tpl.yml
@@ -327,18 +327,18 @@ groups:

 resource_types:
 - name: terraform
-  type: docker-image
+  type: registry-image
  source:
    repository: ljfranklin/terraform-resource
    tag: 0.11.14
 - name: pivnet
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotalcf/pivnet-resource
    tag: latest-final
 {% if "ICW" in test_sections %}
 - name: gcs
-  type: docker-image
+  type: registry-image
  source:
    repository: frodenas/gcs-resource
 {% endif %}
@@ -366,7 +366,7 @@ resources:
    uri: {{ccp-git-remote}}

 - name: ccp-image
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ccp
    tag: '7'
@@ -475,43 +475,43 @@ resources:
    uri: ((debian-release-git-remote))

 - name: centos-gpdb-dev-6
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-gpdb-dev
    tag: '6-gcc6.2-llvm3.7'

 - name: centos-gpdb-dev-7
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-gpdb-dev
    tag: 7-gcc6.2-llvm3.7

 - name: oracle-gpdb-test-7
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/oracle7-test
    tag: gpdb5-latest

 - name: ubuntu-gpdb-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpdb-dev
    tag: '16.04'

 - name: ubuntu16.04-test
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu16.04-test
    tag: gpdb5-latest

 - name: ubuntu-gpdb-debian-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpdb-debian-dev
    tag: '16.04'

 - name: ubuntu-gpcloud-dev-16
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/ubuntu-gpcloud-dev
    tag: '16.04'
@@ -519,7 +519,7 @@ resources:
    password: {{docker_password}}

 - name: centos-mingw
-  type: docker-image
+  type: registry-image
  source:
    repository: pivotaldata/centos-mingw

@@ -900,7 +900,7 @@ anchors:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -995,7 +995,7 @@ set_failed_anchor: &set_failed
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: "7"
@@ -1022,7 +1022,7 @@ set_failed_two_clusters_anchor: &set_failed_two_clusters
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: "7"
@@ -1048,7 +1048,7 @@ dpm_debug_sleep_anchor: &dpm_debug_sleep
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
          tag: latest
@@ -2060,7 +2060,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2296,7 +2296,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2463,7 +2463,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2744,7 +2744,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -2844,7 +2844,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -2922,7 +2922,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3000,7 +3000,7 @@ jobs:
       - name: cluster_env_files
       - name: ddboost_rpm
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3285,7 +3285,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3318,7 +3318,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3338,7 +3338,7 @@ jobs:
        - name: ccp_src
        - name: gpdb_src
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3389,7 +3389,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3421,7 +3421,7 @@ jobs:
        config:
          platform: linux
          image_resource:
-            type: docker-image
+            type: registry-image
            source:
              repository: pivotaldata/ccp
              tag: "7"
@@ -3441,7 +3441,7 @@ jobs:
        - name: ccp_src
        - name: gpdb_src
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: pivotaldata/ccp
          tag: '7'
@@ -3509,7 +3509,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -3573,7 +3573,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run:
@@ -3734,7 +3734,7 @@ jobs:
    config:
      platform: linux
      image_resource:
-        type: docker-image
+        type: registry-image
        source:
          repository: alpine
      run: