Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Greenplum
Gpdb
提交
b7a86e40
G
Gpdb
项目概览
Greenplum
/
Gpdb
通知
7
Star
1
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
Gpdb
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b7a86e40
编写于
5月 12, 1999
作者:
J
Jan Wieck
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixed wrong hasAggs when aggregate columns of view aren't
selected. Disabled ability of defining DISTINCT or ORDER BY on views. Jan
上级
79c2576f
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
146 addition
and
4 deletion
+146
-4
src/backend/rewrite/rewriteDefine.c
src/backend/rewrite/rewriteDefine.c
+13
-1
src/backend/rewrite/rewriteHandler.c
src/backend/rewrite/rewriteHandler.c
+133
-3
未找到文件。
src/backend/rewrite/rewriteDefine.c
浏览文件 @
b7a86e40
...
...
@@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.2
7 1999/05/10 00:45:30 momjian
Exp $
* $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.2
8 1999/05/12 17:04:46 wieck
Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -317,6 +317,18 @@ DefineQueryRewrite(RuleStmt *stmt)
if
(
query
->
limitOffset
!=
NULL
||
query
->
limitCount
!=
NULL
)
elog
(
ERROR
,
"LIMIT clause not supported in views"
);
/*
* DISTINCT on view is not supported
*/
if
(
query
->
uniqueFlag
!=
NULL
)
elog
(
ERROR
,
"DISTINCT not supported in views"
);
/*
* ORDER BY in view is not supported
*/
if
(
query
->
sortClause
!=
NIL
)
elog
(
ERROR
,
"ORDER BY not supported in views"
);
/*
* ... and finally the rule must be named _RETviewname.
*/
...
...
src/backend/rewrite/rewriteHandler.c
浏览文件 @
b7a86e40
...
...
@@ -6,7 +6,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.
39 1999/05/12 15:01:53
wieck Exp $
* $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.
40 1999/05/12 17:04:47
wieck Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -59,6 +59,7 @@ static void modifyAggrefChangeVarnodes(Node **nodePtr, int rt_index, int new_ind
static
void
modifyAggrefDropQual
(
Node
**
nodePtr
,
Node
*
orignode
,
Expr
*
expr
);
static
SubLink
*
modifyAggrefMakeSublink
(
Expr
*
origexp
,
Query
*
parsetree
);
static
void
modifyAggrefQual
(
Node
**
nodePtr
,
Query
*
parsetree
);
static
bool
checkQueryHasAggs
(
Node
*
node
);
static
Query
*
fireRIRrules
(
Query
*
parsetree
);
...
...
@@ -1272,6 +1273,126 @@ modifyAggrefQual(Node **nodePtr, Query *parsetree)
}
/*
* checkQueryHasAggs -
* Queries marked hasAggs might not have them any longer after
* rewriting. Check it.
*/
static
bool
checkQueryHasAggs
(
Node
*
node
)
{
if
(
node
==
NULL
)
return
FALSE
;
switch
(
nodeTag
(
node
))
{
case
T_TargetEntry
:
{
TargetEntry
*
tle
=
(
TargetEntry
*
)
node
;
return
checkQueryHasAggs
((
Node
*
)(
tle
->
expr
));
}
break
;
case
T_Aggref
:
return
TRUE
;
case
T_Expr
:
{
Expr
*
exp
=
(
Expr
*
)
node
;
return
checkQueryHasAggs
((
Node
*
)(
exp
->
args
));
}
break
;
case
T_Iter
:
{
Iter
*
iter
=
(
Iter
*
)
node
;
return
checkQueryHasAggs
((
Node
*
)(
iter
->
iterexpr
));
}
break
;
case
T_ArrayRef
:
{
ArrayRef
*
ref
=
(
ArrayRef
*
)
node
;
if
(
checkQueryHasAggs
((
Node
*
)(
ref
->
refupperindexpr
)))
return
TRUE
;
if
(
checkQueryHasAggs
((
Node
*
)(
ref
->
reflowerindexpr
)))
return
TRUE
;
if
(
checkQueryHasAggs
((
Node
*
)(
ref
->
refexpr
)))
return
TRUE
;
if
(
checkQueryHasAggs
((
Node
*
)(
ref
->
refassgnexpr
)))
return
TRUE
;
return
FALSE
;
}
break
;
case
T_Var
:
return
FALSE
;
case
T_Param
:
return
FALSE
;
case
T_Const
:
return
FALSE
;
case
T_List
:
{
List
*
l
;
foreach
(
l
,
(
List
*
)
node
)
{
if
(
checkQueryHasAggs
((
Node
*
)
lfirst
(
l
)))
return
TRUE
;
}
return
FALSE
;
}
break
;
case
T_CaseExpr
:
{
CaseExpr
*
exp
=
(
CaseExpr
*
)
node
;
if
(
checkQueryHasAggs
((
Node
*
)(
exp
->
args
)))
return
TRUE
;
if
(
checkQueryHasAggs
((
Node
*
)(
exp
->
defresult
)))
return
TRUE
;
return
FALSE
;
}
break
;
case
T_CaseWhen
:
{
CaseWhen
*
when
=
(
CaseWhen
*
)
node
;
if
(
checkQueryHasAggs
((
Node
*
)(
when
->
expr
)))
return
TRUE
;
if
(
checkQueryHasAggs
((
Node
*
)(
when
->
result
)))
return
TRUE
;
return
FALSE
;
}
break
;
default:
elog
(
NOTICE
,
"unknown node tag %d in checkQueryHasAggs()"
,
nodeTag
(
node
));
elog
(
NOTICE
,
"Node is: %s"
,
nodeToString
(
node
));
break
;
}
return
FALSE
;
}
static
Node
*
FindMatchingTLEntry
(
List
*
tlist
,
char
*
e_attname
)
{
...
...
@@ -2574,8 +2695,17 @@ BasicQueryRewrite(Query *parsetree)
* Apply all the RIR rules on each query
*/
foreach
(
l
,
querylist
)
{
query
=
(
Query
*
)
lfirst
(
l
);
results
=
lappend
(
results
,
fireRIRrules
(
query
));
query
=
fireRIRrules
((
Query
*
)
lfirst
(
l
));
/*
* If the query was marked having aggregates, check if
* this is still true after rewriting. This check must get
* expanded when someday aggregates can appear somewhere
* else than in the targetlist or the having qual.
*/
if
(
query
->
hasAggs
)
query
->
hasAggs
=
checkQueryHasAggs
((
Node
*
)(
query
->
targetList
))
|
checkQueryHasAggs
((
Node
*
)(
query
->
havingQual
));
results
=
lappend
(
results
,
query
);
}
return
results
;
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录