Do not expect warning to disable FTS for panic type fault
The intention behind the warning was to guide the test writer to avoid flaky behavior due to FTS intervening in the middle of a PANIC to mark a segment as down. This is good, however, the way the warning is emitted is not correct. The underlying assumption in the warning implementation (see fbd0f091) is that InjectFault() function is executed by the same process that created the gp_inject_fault extension. This is not valid in the new libpq based fault injector because the fault is injected by a transient fault handler process, which is always different from the process that creates the extension when running regression tests. Evidently, there are several tests injecting 'panic' type fault already and their answer files don't have such warnings. The bitmap_index test modified by this commit was the only test still using old fault injector interface to inject a 'panic' fault. In the old fault injector, the above mentioned assumption was applicable and the warning was emitted. Now that we've moved to new implementation wholesale, the warning must be removed. We should go back to drawing board for emitting the FTS warning but that's a separate patch.
Showing
想要评论请 注册 或 登录