提交 a6599e22 编写于 作者: A Asim R P

Do not expect warning to disable FTS for panic type fault

The intention behind the warning was to guide the test writer to avoid
flaky behavior due to FTS intervening in the middle of a PANIC to mark
a segment as down.

This is good, however, the way the warning is emitted is not correct.
The underlying assumption in the warning implementation (see
fbd0f091) is that InjectFault() function is executed by the same
process that created the gp_inject_fault extension.  This is not valid
in the new libpq based fault injector because the fault is injected by
a transient fault handler process, which is always different from the
process that creates the extension when running regression tests.

Evidently, there are several tests injecting 'panic' type fault
already and their answer files don't have such warnings.  The
bitmap_index test modified by this commit was the only test still
using old fault injector interface to inject a 'panic' fault.  In the
old fault injector, the above mentioned assumption was applicable and
the warning was emitted.  Now that we've moved to new implementation
wholesale, the warning must be removed.

We should go back to drawing board for emitting the FTS warning but
that's a separate patch.
上级 748f86fb
......@@ -657,12 +657,6 @@ INSERT INTO bm_test_insert SELECT generate_series (1, 10000);
UPDATE bm_test_update SET b=b+1;
-- trigger recovery on primaries
SELECT gp_inject_fault_infinite('finish_prepared_after_record_commit_prepared', 'panic', dbid) FROM gp_segment_configuration WHERE role = 'p' AND content > -1;
WARNING: consider disabling FTS probes while injecting a panic. (seg0 127.0.0.1:7002 pid=27680)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
WARNING: consider disabling FTS probes while injecting a panic. (seg1 127.0.0.1:7003 pid=27681)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
WARNING: consider disabling FTS probes while injecting a panic. (seg2 127.0.0.1:7004 pid=27682)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
gp_inject_fault_infinite
--------------------------
Success:
......
......@@ -659,12 +659,6 @@ INSERT INTO bm_test_insert SELECT generate_series (1, 10000);
UPDATE bm_test_update SET b=b+1;
-- trigger recovery on primaries
SELECT gp_inject_fault_infinite('finish_prepared_after_record_commit_prepared', 'panic', dbid) FROM gp_segment_configuration WHERE role = 'p' AND content > -1;
WARNING: consider disabling FTS probes while injecting a panic. (seg0 127.0.0.1:7002 pid=98667)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
WARNING: consider disabling FTS probes while injecting a panic. (seg1 127.0.0.1:7003 pid=98668)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
WARNING: consider disabling FTS probes while injecting a panic. (seg2 127.0.0.1:7004 pid=98669)
HINT: Inject a 'skip' into the 'fts_probe' fault to disable FTS probing.
gp_inject_fault_infinite
--------------------------
Success:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册