提交 918fbd84 编写于 作者: G Georgios Kokolatos

Do not prefer libedit over readline for tab completion and history

Tab completion does not work for centos 7 as reported in #8575
[https://github.com/greenplum-db/gpdb/issues/8575] and installing from the rpms.
The root cause is that the binary is linked against libedit (v 0x402) which is
providing the necessary `rl_line_buffer` yet with different contents from
readline. In libedit, the variable contains the last flushed entry in the
history file whereas in readline it contains the current line in the interactive
terminal.

It is not necessary to link with libedit on the build packages so the flag is
removed.
Reviewed-by: NBradford D. Boyle <bboyle@pivotal.io>
(cherry picked from commit 3827c3a6)
上级 9eb508db
......@@ -34,7 +34,7 @@ The python-devel is not required here because it is provided by Anaconda.
## Download and build GPDB
git clone https://github.com/greenplum-db/gpdb.git
cd gpdb
./configure --prefix=`pwd`/greenplumdb --with-gssapi --with-pgport=5432 --with-libedit-preferred --with-perl --with-python --with-openssl --with-libxml --enable-cassert --enable-debug --enable-depend
./configure --prefix=`pwd`/greenplumdb --with-gssapi --with-pgport=5432 --with-perl --with-python --with-openssl --with-libxml --enable-cassert --enable-debug --enable-depend
make install
Make sure "--with-python" parameter exists. Because the default Python is the Anaconda Python, It's done.
......
......@@ -136,7 +136,7 @@ ubuntu18.04_x86_64_CONFIGFLAGS=--with-quicklz --enable-tap-tests --enable-gpperf
BLD_CONFIGFLAGS=$($(BLD_ARCH)_CONFIGFLAGS)
CONFIGFLAGS=$(strip $(BLD_CONFIGFLAGS) --with-pgport=$(DEFPORT) --with-libedit-preferred $(BLD_DEPLOYMENT_SETTING))
CONFIGFLAGS=$(strip $(BLD_CONFIGFLAGS) --with-pgport=$(DEFPORT) $(BLD_DEPLOYMENT_SETTING))
ifdef CONFIGURE_FLAGS
CONFIGFLAGS+= $(CONFIGURE_FLAGS)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册