Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Greenplum
Gpdb
提交
906dce04
G
Gpdb
项目概览
Greenplum
/
Gpdb
通知
7
Star
1
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
Gpdb
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
906dce04
编写于
4月 03, 2003
作者:
T
Tom Lane
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Repair incorrect checking of grouped/ungrouped variables in the presence
of unnamed joins; per pghackers discussion 31-Mar-03.
上级
cdbd298b
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
38 addition
and
9 deletion
+38
-9
src/backend/parser/parse_agg.c
src/backend/parser/parse_agg.c
+38
-9
未找到文件。
src/backend/parser/parse_agg.c
浏览文件 @
906dce04
...
...
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/parse_agg.c,v 1.5
1 2003/01/17 03:25:04
tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/parser/parse_agg.c,v 1.5
2 2003/04/03 18:04:09
tgl Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -16,6 +16,7 @@
#include "optimizer/clauses.h"
#include "optimizer/tlist.h"
#include "optimizer/var.h"
#include "parser/parse_agg.h"
#include "parser/parsetree.h"
...
...
@@ -179,7 +180,9 @@ parseCheckAggregates(ParseState *pstate, Query *qry)
{
List
*
groupClauses
=
NIL
;
bool
have_non_var_grouping
=
false
;
List
*
tl
;
List
*
lst
;
bool
hasJoinRTEs
;
Node
*
clause
;
/* This should only be called if we found aggregates, GROUP, or HAVING */
Assert
(
pstate
->
p_hasAggs
||
qry
->
groupClause
||
qry
->
havingQual
);
...
...
@@ -205,9 +208,9 @@ parseCheckAggregates(ParseState *pstate, Query *qry)
* repeated scans of the targetlist within the recursive routine...).
* And detect whether any of the expressions aren't simple Vars.
*/
foreach
(
tl
,
qry
->
groupClause
)
foreach
(
lst
,
qry
->
groupClause
)
{
GroupClause
*
grpcl
=
lfirst
(
tl
);
GroupClause
*
grpcl
=
(
GroupClause
*
)
lfirst
(
lst
);
Node
*
expr
;
expr
=
get_sortgroupclause_expr
(
grpcl
,
qry
->
targetList
);
...
...
@@ -220,14 +223,40 @@ parseCheckAggregates(ParseState *pstate, Query *qry)
have_non_var_grouping
=
true
;
}
/*
* If there are join alias vars involved, we have to flatten them
* to the underlying vars, so that aliased and unaliased vars will be
* correctly taken as equal. We can skip the expense of doing this
* if no rangetable entries are RTE_JOIN kind.
*/
hasJoinRTEs
=
false
;
foreach
(
lst
,
pstate
->
p_rtable
)
{
RangeTblEntry
*
rte
=
(
RangeTblEntry
*
)
lfirst
(
lst
);
if
(
rte
->
rtekind
==
RTE_JOIN
)
{
hasJoinRTEs
=
true
;
break
;
}
}
if
(
hasJoinRTEs
)
groupClauses
=
(
List
*
)
flatten_join_alias_vars
(
qry
,
(
Node
*
)
groupClauses
);
/*
* Check the targetlist and HAVING clause for ungrouped variables.
*/
check_ungrouped_columns
((
Node
*
)
qry
->
targetList
,
pstate
,
groupClauses
,
have_non_var_grouping
);
check_ungrouped_columns
((
Node
*
)
qry
->
havingQual
,
pstate
,
clause
=
(
Node
*
)
qry
->
targetList
;
if
(
hasJoinRTEs
)
clause
=
flatten_join_alias_vars
(
qry
,
clause
);
check_ungrouped_columns
(
clause
,
pstate
,
groupClauses
,
have_non_var_grouping
);
/* Release the list storage (but not the pointed-to expressions!) */
freeList
(
groupClauses
);
clause
=
(
Node
*
)
qry
->
havingQual
;
if
(
hasJoinRTEs
)
clause
=
flatten_join_alias_vars
(
qry
,
clause
);
check_ungrouped_columns
(
clause
,
pstate
,
groupClauses
,
have_non_var_grouping
);
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录