提交 51bd8009 编写于 作者: D Daniel Gustafsson

Fix incorrect struct member in backport

The backport of the data checksum catalog changes backported the
relevant GUC from a version which has struct config_bool defined
differently than GPDB. The reason an extra NULL in the config_bool
array initialization wasn't causing a compilation failure is that
there is an extra bool member at the end which is only set during
runtime, reset_val. The extra NULL was "overflowing" into this
member and thus only raised a warning under -Wint-conversion:

    guc.c:1180:15: warning: incompatible pointer to integer
	               conversion initializing 'bool' (aka 'char')
				   with an expression of type 'void *’

Fix by removing the superflous NULL. Since it was setting reset_val
to NULL (and for a GUC which is yet to "do something") there should
be no effects by this.
上级 b5e1fb0a
......@@ -1176,8 +1176,7 @@ static struct config_bool ConfigureNamesBool[] =
GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE
},
&data_checksums,
false,
NULL, NULL, NULL
false, NULL, NULL
},
/* End-of-list marker */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册