提交 4a61641c 编写于 作者: A Adam Berlin 提交者: Adam Berlin

Removed FIXME comment from test suite.

We left the comment explaining the difference between GPDB
and upstream, as it will be useful for future merge work.

pg_event_trigger_dropped_objects should observe events run
on the QD when tables are dropped and have the same behavior
as upstream.

There's a possible race-condition because the query no longer
joins, so there's a gap between the lookup of dropped objects
and the query for undroppable objects, but because theres no
other queries using this table or function, it is not a concern.
Co-authored-by: NGeorgios Kokolatos <gkokolatos@pivotal.io>
上级 8b3291bc
......@@ -144,7 +144,7 @@ BEGIN
RETURN;
END IF;
-- GPDB_93_MERGE_FIXME: This query has been modified from upstream's,
-- This query has been modified from upstream's,
-- to not do a join, because with the original query, the planner would
-- execute the pg_event_trigger_dropped_objects() function in an entry DB
-- worker process, not the QD process. That doesn't work, the function
......
......@@ -155,7 +155,7 @@ BEGIN
RETURN;
END IF;
-- GPDB_93_MERGE_FIXME: This query has been modified from upstream's,
-- This query has been modified from upstream's,
-- to not do a join, because with the original query, the planner would
-- execute the pg_event_trigger_dropped_objects() function in an entry DB
-- worker process, not the QD process. That doesn't work, the function
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册