Fix gpinitsystem when setting password for numeric username

gpinitsystem did not quote the username while performing ALTER USER. When the username
is a numeric value the postgres parser gets upset - unless the username is quoted.

See here for more details:

https://www.postgresql.org/docs/9.4/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS

- SQL identifiers and key words must begin with a letter (a-z, but also letters with
  diacritical marks and non-Latin letters) or an underscore (_).

- Also, there is a second kind of identifier: the delimited identifier or quoted
  identifier. It is formed by enclosing an arbitrary sequence of characters in
  double-quotes (")

- use variable interpolation provided by psql to properly quote user-provided values.

- use RETVAL to perform testing due to Commit d7b7a40aCo-authored-by: NJacob Champion <pchampion@pivotal.io>
(cherry picked from commit f188ecb5)

gpMgmt/bin/Makefile

@@ -220,8 +220,13 @@ unitdevel:
 	PYTHONPATH=$(SERVER_SRC):$(SERVER_SBIN):$(PYTHONPATH):$(PYTHONSRC_INSTALL_PYTHON_PATH):$(SRC)/ext:$(SBIN_DIR):$(LIB_DIR):$(PYLIB_DIR)/mock-1.0.1 \
 	    python -m unittest discover --verbose -s $(SRC)/gppylib -p "test_unit*.py"
 
+
+.PHONY: installcheck-bash
+installcheck-bash:
+	./test/suite.bash
+
 .PHONY: installcheck
-installcheck:
+installcheck: installcheck-bash
 	$(MAKE) -C gpload_test $@
 
 clean distclean:

gpMgmt/bin/gpinitsystem

@@ -1586,13 +1586,6 @@ START_QD_PRODUCTION () {
     LOG_MSG "[INFO]:-End Function $FUNCNAME"
 }
 
-SET_GP_USER_PW () {
-    LOG_MSG "[INFO]:-Start Function $FUNCNAME"
-    $PSQL -p $MASTER_PORT -d "$DEFAULTDB" -c"alter user $USER_NAME password '$GP_PASSWD';" >> $LOG_FILE 2>&1
-    ERROR_CHK $? "update Greenplum superuser password" 1
-    LOG_MSG "[INFO]:-End Function $FUNCNAME"
-}
-
 CREATE_DATABASE () {
 		LOG_MSG "[INFO]:-Start Function $FUNCNAME"
 		SET_VAR $QD_PRIMARY_ARRAY

gpMgmt/bin/lib/gp_bash_functions.sh

@@ -1297,6 +1297,21 @@ CHK_GPDB_ID () {
 	LOG_MSG "[INFO]:-End Function $FUNCNAME"
 }
 
+SET_GP_USER_PW () {
+    LOG_MSG "[INFO]:-Start Function $FUNCNAME"
+
+    local alter_statement="alter user :\"username\" password :'password';"
+
+    $PSQL --variable=ON_ERROR_STOP=1 \
+      -p $MASTER_PORT \
+      -d "$DEFAULTDB" \
+      --variable=username="$USER_NAME" \
+      --variable=password="$GP_PASSWD" <<< "$alter_statement" >> $LOG_FILE 2>&1
+
+    ERROR_CHK $? "update Greenplum superuser password" 1
+    LOG_MSG "[INFO]:-End Function $FUNCNAME"
+}
+
 #******************************************************************************
 # Main Section
 #******************************************************************************

gpMgmt/bin/test/gpinitsystem_test.bash

+#!/usr/bin/env bash
+
+. lib/gp_bash_functions.sh
+
+__cleanupTestUsers() {
+  dropuser 123456
+  dropuser abc123456
+}
+
+mimic_gpinitsystem_setup() {
+  # ensure MASTER_PORT is set, it is needed by SET_GP_USER_PW
+  GET_MASTER_PORT "$MASTER_DATA_DIRECTORY"
+
+  # the return value set when performing ERROR_CHK
+  # on the status code returned from $PSQL
+  #
+  # set it to a default value
+  RETVAL=0
+}
+
+it_should_quote_the_username_during_alter_user_in_SET_GP_USER_PW() {
+  mimic_gpinitsystem_setup
+
+  # given a user that is only a number
+  USER_NAME=123456
+  createuser $USER_NAME
+  trap __cleanupTestUsers EXIT
+
+  # when we run set user password
+  SET_GP_USER_PW
+
+  # then it should succeed
+  if [ "$RETVAL" != "0" ]; then
+    local error_message="$(tail -n 10 "$LOG_FILE")"
+    echo "got an exit status of $RETVAL while running SET_GP_USER_PW for $USER_NAME, wanted success: $error_message"
+    exit 1
+  fi
+}
+
+it_should_quote_the_password_during_alter_user_in_SET_GP_USER_PW() {
+  mimic_gpinitsystem_setup
+
+  # given a user
+  USER_NAME=abc123456
+  createuser $USER_NAME
+  trap __cleanupTestUsers EXIT
+
+  # when we run set user password with a password containing single quotes
+  GP_PASSWD="abc'"
+  SET_GP_USER_PW
+
+  # then it should succeed
+  if [ "$RETVAL" != "0" ]; then
+    local error_message="$(tail -n 10 "$LOG_FILE")"
+    echo "got an exit status of $RETVAL while running SET_GP_USER_PW for $USER_NAME with password $GP_PASSWD, wanted success: $error_message"
+    exit 1
+  fi
+}
+
+main() {
+  it_should_quote_the_username_during_alter_user_in_SET_GP_USER_PW
+  it_should_quote_the_password_during_alter_user_in_SET_GP_USER_PW
+}
+
+main

gpMgmt/bin/test/suite.bash

+#!/usr/bin/env bash
+
+set -o errexit
+
+./test/gpinitsystem_test.bash