resgroup: hashagg: revert operator memory auto enlarging
In resource group mode we ever introduced an operator memory automatic enlarging logic for hashagg, the point is to let hashagg fail on actual OOM instead of a soft quote checking, this helps to let hashagg run successfully with an initial low operator memory. However a bug was introduced by the auto enlarging logic, hashagg spilling can be disabled in resource group mode by accident. On the other hand we introduced a memory_spill_ratio=0 mode in resource group to use statement_mem for operators, which is the same behavior as resource queue. The statement_mem setting is usually large enough and fine tuned by the users, in such a case we do not need the auto enlarge for hashagg, and it is better to keep the old quote checking behavior. In such a case we revert the hashagg related changes from below commits: - 40d955d6 Rid resource group on hashagg spill evaluation (#8199) - ede74cdc resgroup: reduce log level for operator memory overuse - f053e6cd resgroup: allow memory overuse for hashagg spill meta data - 90795402 resgroup: allow operators enlarge their memory quota Reviewed-by: NAdam Lee <ali@pivotal.io> Reviewed-by: NWeinan WANG <wewang@pivotal.io> Discussion: https://groups.google.com/a/greenplum.org/d/msg/gpdb-dev/30hiTArxsgo/aydVMcrXBQAJ
Showing
想要评论请 注册 或 登录