未验证 提交 2c7f4f6d 编写于 作者: J Jinbao Chen 提交者: GitHub

Remove fixme and a copy of group clause (#5458)

A parse object has been copyed to subroot, and We do not free
root->simple_rel_array and root->simple_rte_array. So We do not
need to copy group clause.
上级 f8332b3c
......@@ -4579,13 +4579,8 @@ add_second_stage_agg(PlannerInfo *root,
/*
* Since the rtable has changed, we had better recreate a RelOptInfo entry
* for it. Make a copy of the groupClause since freeing the arrays can
* pull out references still in use from underneath it.
* We do not free root->simple_rel_array and root->simple_rte_array since
* they are used by subroot.
* GPDB_92_MERGE_FIXME: Do we still need to copy groupClause?
* for it.
*/
root->parse->groupClause = copyObject(root->parse->groupClause);
rebuild_simple_rel_and_rte(root);
/*
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册