Make fsync=off default on create-demo-cluster

Also remove the redundant fsync=off from related pipeline files.

It can be overriden with BLDWRAP_POSTGRES_CONF_ADDONS.

Author: Xin Zhang <xzhang@pivotal.io>
Author: Ashwin Agrawal <aagrawal@pivotal.io>

concourse/pipelines/pipeline.yml

@@ -1036,7 +1036,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=off' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       TEST_BINARY_SWAP: false
       CONFIGURE_FLAGS: {{configure_flags}}
@@ -1056,7 +1055,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       CONFIGURE_FLAGS: {{configure_flags}}
 
@@ -1075,7 +1073,6 @@ jobs:
     image: centos-gpdb-dev-7
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       CONFIGURE_FLAGS: {{configure_flags}}
 
@@ -1092,7 +1089,6 @@ jobs:
     file: gpdb_src/concourse/tasks/ic_gpdb_sles11.yml
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: sles
       CONFIGURE_FLAGS: {{configure_flags}}
 
@@ -1256,7 +1252,7 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off | optimizer_use_gpdb_allocators=on"
+      BLDWRAP_POSTGRES_CONF_ADDONS: optimizer_use_gpdb_allocators=on
       TEST_OS: centos
       CONFIGURE_FLAGS: {{configure_flags}}
 
@@ -1275,7 +1271,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c gp_interconnect_type=tcp -c optimizer=off' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
 
 - name: icw_extensions_gpcloud
@@ -1848,7 +1843,6 @@ jobs:
       file: gpdb_src/concourse/tasks/tinc_gpdb.yml
       params:
         MAKE_TEST_COMMAND: aocoalter_catalog_loaders
-        BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
         TEST_OS: centos
         CONFIGURE_FLAGS: {{configure_flags}}
       image: centos-gpdb-dev-6
@@ -1856,7 +1850,6 @@ jobs:
       file: gpdb_src/concourse/tasks/tinc_gpdb.yml
       params:
         MAKE_TEST_COMMAND: storage_persistent_accessmethods_and_vacuum
-        BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
         TEST_OS: centos
         CONFIGURE_FLAGS: {{configure_flags}}
       image: centos-gpdb-dev-6
@@ -1865,7 +1858,6 @@ jobs:
       file: gpdb_src/concourse/tasks/tinc_gpdb.yml
       params:
         MAKE_TEST_COMMAND: storage_filerep
-        BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
         TEST_OS: centos
         CONFIGURE_FLAGS: {{configure_flags}}
       image: centos-gpdb-dev-6
@@ -1874,7 +1866,6 @@ jobs:
       file: gpdb_src/concourse/tasks/tinc_gpdb.yml
       params:
         MAKE_TEST_COMMAND: storage_uao_and_transactionmanagement
-        BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
         TEST_OS: centos
         CONFIGURE_FLAGS: {{configure_flags}}
       image: centos-gpdb-dev-6
@@ -1883,7 +1874,6 @@ jobs:
       file: gpdb_src/concourse/tasks/tinc_gpdb.yml
       params:
         MAKE_TEST_COMMAND: storage_vacuum_xidlimits
-        BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
         TEST_OS: centos
         CONFIGURE_FLAGS: {{configure_flags}}
       image: centos-gpdb-dev-6

concourse/pipelines/pipeline_segwalrep.yml

@@ -89,7 +89,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       CONFIGURE_FLAGS: "((configure_flags)) --enable-segwalrep"
 
@@ -108,7 +107,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=off' installcheck-world
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       CONFIGURE_FLAGS: "((configure_flags)) --enable-segwalrep"
 
@@ -127,7 +125,6 @@ jobs:
     image: centos-gpdb-dev-6
     params:
       MAKE_TEST_COMMAND: "-C src/test/regress && make -C src/test/walrep install installcheck"
-      BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
       TEST_OS: centos
       CONFIGURE_FLAGS: "((configure_flags)) --enable-segwalrep"
       WITH_MIRRORS: false

concourse/pipelines/pr_pipeline.yml

@@ -122,7 +122,6 @@ jobs:
           bin_gpdb: gpdb_artifacts
         params:
           MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=off' installcheck-world
-          BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
           TEST_OS: centos
           CONFIGURE_FLAGS: {{configure_flags}}
         timeout: 2h
@@ -136,7 +135,6 @@ jobs:
           bin_gpdb: gpdb_artifacts
         params:
           MAKE_TEST_COMMAND: PGOPTIONS='-c optimizer=on' installcheck-world
-          BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
           TEST_OS: centos
           CONFIGURE_FLAGS: {{configure_flags}}
         timeout: 5h

concourse/scripts/ic_gpdb_ubuntu.bash

@@ -21,7 +21,6 @@ function setup_gpadmin_user() {
 }
 
 function make_cluster() {
-  export BLDWRAP_POSTGRES_CONF_ADDONS="fsync=off"
   source "${GREENPLUM_INSTALL_DIR}/greenplum_path.sh"
   export DEFAULT_QD_MAX_CONNECT=150
   pushd gpdb_src/gpAux/gpdemo

concourse/tasks/test_with_orca.yml

@@ -17,5 +17,3 @@ run:
     - --gpdb_name=bin_gpdb
     - --action=test
     - --configure-option=--disable-gpcloud
-params:
-  BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"

concourse/tasks/test_with_orca_conan.yml

@@ -15,5 +15,4 @@ run:
     - --mode=orca
     - --gpdb_name=bin_gpdb
 params:
-  BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"
   TEST_SUITE: "icg"

concourse/tasks/test_with_planner.yml

@@ -17,5 +17,3 @@ run:
     - --gpdb_name=bin_gpdb
     - --action=test
     - --configure-option=--disable-gpcloud
-params:
-  BLDWRAP_POSTGRES_CONF_ADDONS: "fsync=off"

gpAux/gpdemo/Makefile

@@ -19,6 +19,7 @@ export with_openssl
 MASTER_PORT ?= 15432
 PORT_BASE ?= 25432
 NUM_PRIMARY_MIRROR_PAIRS ?= 3
+BLDWRAP_POSTGRES_CONF_ADDONS := fsync=off $(BLDWRAP_POSTGRES_CONF_ADDONS)
 
 ifeq ($(WITH_MIRRORS), )
 WITH_MIRRORS = true
@@ -28,6 +29,7 @@ export MASTER_DEMO_PORT=$(MASTER_PORT)
 export DEMO_PORT_BASE=$(PORT_BASE)
 export NUM_PRIMARY_MIRROR_PAIRS
 export WITH_MIRRORS
+export BLDWRAP_POSTGRES_CONF_ADDONS
 
 all:
 	$(MAKE) clean

gpAux/gpdemo/demo_cluster.sh

@@ -350,6 +350,9 @@ if [ "${BLDWRAP_POSTGRES_CONF_ADDONS}" != "__none__" ]  && \
     for addon in $( echo ${BLDWRAP_POSTGRES_CONF_ADDONS} | sed -e "s/|/ /g" ); do
         echo "" >> ${CLUSTER_CONFIG_POSTGRES_ADDONS}
         echo $addon >> ${CLUSTER_CONFIG_POSTGRES_ADDONS}
+	if [ "$addon" == "fsync=off" ]; then
+		echo "WARNING: fsync is off, database consistency is not guaranteed."
+	fi
         echo "" >> ${CLUSTER_CONFIG_POSTGRES_ADDONS}
     done