提交 06ecacde 编写于 作者: N Neil Conway

More trivial dead code removal: in int_to_roman(), checking for "num == -1"

is redundant after a check has already been made for "num < 0". The "set"
variable can also be removed, as it is now no longer used. Per checking
with Karel, this is the right fix.

Per Coverity static analysis performed by EnterpriseDB.
上级 ebcb4c93
/* ----------------------------------------------------------------------- /* -----------------------------------------------------------------------
* formatting.c * formatting.c
* *
* $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.88 2005/06/15 00:34:08 momjian Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.89 2005/06/22 01:43:05 neilc Exp $
* *
* *
* Portions Copyright (c) 1999-2005, PostgreSQL Global Development Group * Portions Copyright (c) 1999-2005, PostgreSQL Global Development Group
...@@ -3508,8 +3508,7 @@ static char * ...@@ -3508,8 +3508,7 @@ static char *
int_to_roman(int number) int_to_roman(int number)
{ {
int len = 0, int len = 0,
num = 0, num = 0;
set = 0;
char *p = NULL, char *p = NULL,
*result, *result,
numstr[5]; numstr[5];
...@@ -3529,9 +3528,6 @@ int_to_roman(int number) ...@@ -3529,9 +3528,6 @@ int_to_roman(int number)
num = *p - 49; /* 48 ascii + 1 */ num = *p - 49; /* 48 ascii + 1 */
if (num < 0) if (num < 0)
continue; continue;
if (num == -1 && set == 0)
continue;
set = 1;
if (len > 3) if (len > 3)
{ {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册