Applied Feedback

src/backend/commands/copy.c

@@ -990,15 +990,13 @@ DoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 		rel = heap_openrv(stmt->relation,
 						  (is_from ? RowExclusiveLock : AccessShareLock));
 
-		if (is_from)
+		if (is_from && !allowSystemTableMods && IsUnderPostmaster && IsSystemRelation(rel))
 		{
-			if (!allowSystemTableMods && IsUnderPostmaster && IsSystemRelation(rel))
-			{
-				ereport(ERROR,
-					(errcode(ERRCODE_WRONG_OBJECT_TYPE),
-						errmsg("permission denied: \"%s\" is a system catalog",
-							RelationGetRelationName(rel))));
-			}
+			ereport(ERROR,
+					(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
+							errmsg("permission denied: \"%s\" is a system catalog",
+								RelationGetRelationName(rel)),
+								errhint("Make sure the configuration parameter allow_system_table_mods is set.")));
 		}
 
 		relid = RelationGetRelid(rel);

src/test/regress/output/gpcopy.source

@@ -1615,6 +1615,7 @@ RESET allow_system_table_mods;
 -- cannot copy to a catalog table with allow_system_table_mods=off;
 COPY gp_configuration_history from stdin with delimiter '|';
 ERROR:  permission denied: "gp_configuration_history" is a system catalog
+HINT:  Make sure the configuration parameter allow_system_table_mods is set.
 ABORT;
 -- GPDB makes the database name, and many other things, available
 -- as environment variables to the program. Test those.