Remove gppkg packaging of PL/perl.

In previous versions of GPDB, we compiled PL/perl against the Perl version
that shipped with RHEL5, and built a separate gpkkg package of plperl,
compiled against the version that ships with RHEL6. If you wanted to use
PL/perl on RHEL6, you had to install the package separately. That's now
obsolete, as we don't support RHEL5 anymore. We can just always build
against the later Perl version.

Adjust concourse script to cope when no gppkg packages were built, as is
now the case on most platforms.

concourse/scripts/compile_gpdb.bash

@@ -110,7 +110,9 @@ function export_gpdb_extensions() {
       chmod 755 greenplum-*zip*
       cp greenplum-*zip* "$GPDB_ARTIFACTS_DIR"/
     fi
-    chmod 755 "$GPDB_ARTIFACTS_DIR"/*.gppkg
+    if ls "$GPDB_ARTIFACTS_DIR"/*.gppkg 1>/dev/null 2>&1; then
+      chmod 755 "$GPDB_ARTIFACTS_DIR"/*.gppkg
+    fi
   popd
 }
 

gpAux/Makefile

@@ -1240,7 +1240,6 @@ gccVersionCheck :
 
 ifeq ($(BLD_ARCH),$(filter $(BLD_ARCH),rhel7_x86_64 rhel6_x86_64))
 GPPKG_SOURCES = \
-	../src/pl/plperl \
 	$(NULL)
 else
 # Removed filtering logic for building gppkg as on suse11. It was only building
@@ -1250,7 +1249,6 @@ else
 # TODO: As we build for centos6 we can add filtering logic if necessary
 GPPKG_SOURCES = \
 	../contrib/pgcrypto \
-	../src/pl/plperl \
 	../src/bin/pg_dump/cdb/ddboost \
 	extensions/postgis-2.0.3 \
 	extensions/plr \
@@ -1304,12 +1302,10 @@ endif
 
 ifeq ($(BLD_ARCH),$(filter $(BLD_ARCH),rhel7_x86_64 rhel6_x86_64 suse11_x86_64))
 GPPKG_ROOT_DIR = \
-	../src/pl/plperl \
 	$(NULL)
 else
 GPPKG_ROOT_DIR = \
 	../contrib/pgcrypto \
-	../src/pl/plperl \
 	$(NULL)
 endif
 

src/pl/plperl/package/Makefile

-all: gppkg
-
-BLD_TOP=../../../../gpAux
-GPMGMT=$(BLD_TOP)/gpMgmt
-include $(BLD_TOP)/releng/tools.mk
-include $(BLD_TOP)/releng/releng.mk
-include $(BLD_TOP)/Makefile.global
-
-OS=$(word 1,$(subst _, ,$(BLD_ARCH)))
-ARCH=$(shell uname -p)
-
-# NOTE: PERL_DIR is dfined in $(BLD_TOP)/releng/releng.mk
-
-PLPERL_GPPKG_VER=ossv5.12.4_pv1.3_gpdb4.3orca
-PLPERL_VER=1.3
-PLPERL_REL=4
-PLPERL_DIR=`cd .. && pwd`
-PLPERL_RPM_FLAGS="--define 'plperl_dir $(PLPERL_DIR)' --define 'plperl_ver $(PLPERL_VER)' --define 'plperl_rel $(PLPERL_REL)' "
-PLPERL_RPM=plperl-$(PLPERL_VER)-$(PLPERL_REL).$(ARCH).rpm
-PLPERL_GPPKG=plperl-$(PLPERL_GPPKG_VER)-$(OS)-$(ARCH).gppkg
-
-TARGET_GPPKG=$(PLPERL_GPPKG)
-EXTRA_CLEAN+=$(PLPERL_RPM) $(PLPERL_GPPKG)
-
-#
-# Generic rules to build gppkgs included here
-#
-include $(BLD_TOP)/releng/gppkg.mk
-
-gppkg:
-	$(MAKE) $(PLPERL_RPM) RPM_FLAGS=$(PLPERL_RPM_FLAGS)
-	$(MAKE) $(PLPERL_GPPKG) MAIN_RPM=$(PLPERL_RPM) 
-
-.PHONY: gppkg

src/pl/plperl/package/gppkg_spec.yml.in

-Pkgname: plperl 
-Architecture: #arch
-OS: #os
-Version: ossv5.12.4_pv1.3_gpdb4.3orca
-GPDBVersion: 4.3
-Description: Provides a procedural langauge implementation of Perl for the Greenplum Database. 
-PostInstall:
-- Master: "echo 'Please source your $GPHOME/greenplum_path.sh and restart the database.';
-          echo 'You can enable plperl by running createlang plperl -d mydatabase.' ;"

src/pl/plperl/package/perl.spec

-Summary:        Perl 
-License:        Artistic License        
-Name:           perl
-Version:        %{perl_ver}
-Release:        %{perl_rel} 
-Group:          Development/Tools
-Prefix:         /temp
-AutoReq:        no
-AutoProv:       no
-Provides:       perl = %{perl_ver}, /bin/sh 
-
-%description
-The Perl package provides Perl for PL/Perl. 
-
-%install
-mkdir -p %{buildroot}/temp/ext/perl-%{perl_ver}
-cp -r %{perl_dir}/*   %{buildroot}/temp/ext/perl-%{perl_ver}
-
-%post
-echo "PERL5HOME=\$GPHOME/ext/perl-%{perl_ver}" >> $GPHOME/greenplum_path.sh
-echo "export PATH=\$PERL5HOME/bin:\$PATH" >> $GPHOME/greenplum_path.sh
-echo "export LD_LIBRARY_PATH=\$PERL5HOME/lib/%{perl_ver}/x86_64-linux/CORE:\$LD_LIBRARY_PATH" >> $GPHOME/greenplum_path.sh
-echo "export PERL5LIB=\$PERL5HOME/lib/site_perl/%{perl_ver}/x86_64-linux:\$PERL5HOME/lib/site_perl/%{perl_ver}:\$PERL5HOME/lib/%{perl_ver}/x86_64-linux:\$PERL5HOME/lib/%{perl_ver}" >> $GPHOME/greenplum_path.sh
-
-%postun
-sed -i".bk" "/PERL5HOME/d" $GPHOME/greenplum_path.sh
-rm -rf $GPHOME/greenplum_path.sh.bk
-
-%files
-/temp

src/pl/plperl/package/plperl.spec

-Summary:        PL/Perl for Greenplum Database 
-License:        Artistic License        
-Name:           plperl
-Version:        %{plperl_ver}
-Release:        %{plperl_rel}
-Group:          Development/Tools
-Prefix:         /temp
-AutoReq:        no
-AutoProv:       no
-Provides:       plperl = %{plperl_ver} 
-
-%description
-The PL/Perl package provides Procedural language implementation of Perl for Greenplum Database.
-
-%install
-mkdir -p %{buildroot}/temp
-make -C %{plperl_dir} install prefix=%{buildroot}/temp
-
-%files
-/temp