提交 032ee470 编写于 作者: D Daniel Gustafsson

Fix ereport punctuation in reloptions_gp.c

As per the error message style guid, error hints should be proper
sentences starting with a capital letter and ending with a period.
This adds the ending period to the ereports where it was missing.
Reviewed-by: NAshwin Agrawal <aagrawal@pivotal.io>
上级 b3b2797e
......@@ -872,7 +872,7 @@ validate_and_adjust_options(StdRdOptions *result,
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("invalid option \"compresstype\" for base relation"),
errhint("\"compresstype\" is only valid for Append Only relations, create an AO relation to use \"compresstype\"")));
errhint("\"compresstype\" is only valid for Append Only relations, create an AO relation to use \"compresstype\".")));
if (!compresstype_is_valid(comptype_opt->values.string_val))
ereport(ERROR,
......@@ -1003,7 +1003,7 @@ validate_and_adjust_options(StdRdOptions *result,
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("invalid option \"checksum\" for base relation"),
errhint("\"checksum\" option only valid for Append Only relations, data checksum for heap relations are turned on at cluster creation")));
errhint("\"checksum\" option only valid for Append Only relations, data checksum for heap relations are turned on at cluster creation.")));
result->checksum = checksum_opt->values.bool_val;
}
/* Disable checksum for heap relations. */
......@@ -1220,7 +1220,7 @@ validateAppendOnlyRelOptions(bool ao,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("block size (%d) is smaller gp_safefswritesize (%d)",
blocksize, gp_safefswritesize),
errhint("Increase blocksize or decrease gp_safefswritesize if it is safe to do so on this file system")));
errhint("Increase blocksize or decrease gp_safefswritesize if it is safe to do so on this file system.")));
}
/*
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册