• H
    Silence compiler warning about strncpy length argument. · e17e57c1
    Heikki Linnakangas 提交于
    GCC 8.2 started giving this warning:
    
    pg_regress.c: In function ‘generate_uao_sourcefiles’:
    pg_regress.c:609:34: warning: argument to ‘sizeof’ in ‘strncpy’ call is the same expression as the source; did you mean to use the size of the destination? [-Wsizeof-pointer-memaccess]
        strncpy(line_row, line, sizeof(line));
                                      ^
    
    In this case, 'line' and 'line_row' actually have the same size, 1024
    bytes, so this is just pedantry.
    
    While we're at it, switch to using strlcpy(), because this would not work
    correctly if the buffer isn't NULL-terminated. The buffer is supposed to
    "large enough", so that that never happens anyway, but might as well be
    safe here.
    e17e57c1
pg_regress.c 76.5 KB