• T
    Fix SPI_getvalue and SPI_getbinval to range-check the given attribute number · bcf188a2
    Tom Lane 提交于
    according to the TupleDesc's natts, not the number of physical columns in the
    tuple.  The previous coding would do the wrong thing in cases where natts is
    different from the tuple's column count: either incorrectly report error when
    it should just treat the column as null, or actually crash due to indexing off
    the end of the TupleDesc's attribute array.  (The second case is probably not
    possible in modern PG versions, due to more careful handling of inheritance
    cases than we once had.  But it's still a clear lack of robustness here.)
    
    The incorrect error indication is ignored by all callers within the core PG
    distribution, so this bug has no symptoms visible within the core code, but
    it might well be an issue for add-on packages.  So patch all the way back.
    bcf188a2
spi.c 55.6 KB