• T
    Code review for FILLFACTOR patch. Change WITH grammar as per earlier · b7b78d24
    Tom Lane 提交于
    discussion (including making def_arg allow reserved words), add missed
    opt_definition for UNIQUE case.  Put the reloptions support code in a less
    random place (I chose to make a new file access/common/reloptions.c).
    Eliminate header inclusion creep.  Make the index options functions safely
    user-callable (seems like client apps might like to be able to test validity
    of options before trying to make an index).  Reduce overhead for normal case
    with no options by allowing rd_options to be NULL.  Fix some unmaintainably
    klugy code, including getting rid of Natts_pg_class_fixed at long last.
    Some stylistic cleanup too, and pay attention to keeping comments in sync
    with code.
    
    Documentation still needs work, though I did fix the omissions in
    catalogs.sgml and indexam.sgml.
    b7b78d24
tablecmds.c 207.2 KB