• M
    · a1627a1d
    Marc G. Fournier 提交于
    From: David Hartwig <daybee@bellatlantic.net>
    
    I have attached a patch to allow GROUP BY and/or ORDER BY function or
    expressions.  Note worthy items:
    
    1. The expression or function need not be in the target list.
    Example:
                SELECT  name FROM foo GROUP BY lower(name);
    
    2.   Simplified the grammar to use expressions only.
    
    3.  Cleaned up earlier patch in this area to make use of existing
    utility functions.
    
    3.  Reduced some of the members in the SortGroupBy parse node.   The
    original data members were redundant with the new expression node.
    (MUST do a "make clean" now)
    
    4.  Added a new parse node "JoinUsing".   The JOIN USING clause was
    overloading this SortGroupBy structure.   With the afore mentioned
    reduction of members, the two clauses lost all their commonality.
    
    5.  A bug still exist where, if a function or expression is GROUPed BY,
    and an aggregate function does not include a attribute from the
    expression or function, the backend crashes.   (or something like
    that)   The bug pre-dates this patch.    Example:
    
        SELECT lower(a) AS lowcase, count(b) FROM foo GROUP BY lowcase;
                     *** BOOM  ***
    
        --Also when not in target list
        SELECT  count(b) FROM foo GROUP BY lower(a);
                    *** BOOM  AGAIN ***
    a1627a1d
parsenodes.h 22.2 KB