• T
    Prevent pushing down WHERE clauses into unsafe UNION/INTERSECT nests. · 964c0d0f
    Tom Lane 提交于
    The planner is aware that it mustn't push down upper-level quals into
    subqueries if the quals reference subquery output columns that contain
    set-returning functions or volatile functions, or are non-DISTINCT outputs
    of a DISTINCT ON subquery.  However, it missed making this check when
    there were one or more levels of UNION or INTERSECT above the dangerous
    expression.  This could lead to "set-valued function called in context that
    cannot accept a set" errors, as seen in bug #8213 from Eric Soroos, or to
    silently wrong answers in the other cases.
    
    To fix, refactor the checks so that we make the column-is-unsafe checks
    during subquery_is_pushdown_safe(), which already has to recursively
    inspect all arms of a set-operation tree.  This makes
    qual_is_pushdown_safe() considerably simpler, at the cost that we will
    spend some cycles checking output columns that possibly aren't referenced
    in any upper qual.  But the cases where this code gets executed at all
    are already nontrivial queries, so it's unlikely anybody will notice any
    slowdown of planning.
    
    This has been broken since commit 05f916e6,
    which makes the bug over ten years old.  A bit surprising nobody noticed it
    before now.
    964c0d0f
union.out 11.8 KB