• H
    Don't throw a warning if vacuum sees PD_ALL_VISIBLE flag set on a page that · 93d88823
    Heikki Linnakangas 提交于
    contains newly-inserted tuples that according to our OldestXmin are not
    yet visible to everyone. The value returned by GetOldestXmin() is conservative,
    and it can move backwards on repeated calls, so if we see that contradiction
    between the PD_ALL_VISIBLE flag and status of tuples on the page, we have to
    assume it's because an earlier vacuum calculated a higher OldestXmin value,
    and all the tuples really are visible to everyone.
    
    We have received several reports of this bug, with the "PD_ALL_VISIBLE flag
    was incorrectly set in relation ..." warning appearing in logs. We were
    finally able to hunt it down with David Gould's help to run extra diagnostics
    in an environment where this happened frequently.
    
    Also reword the warning, per Robert Haas' suggestion, to not imply that the
    PD_ALL_VISIBLE flag is necessarily at fault, as it might also be a symptom
    of corruption on a tuple header.
    
    Backpatch to 8.4, where the PD_ALL_VISIBLE flag was introduced.
    93d88823
procarray.c 92.9 KB