• R
    Remove partial, broken support for NULL pointers when fetching attributes. · 84b6d5f3
    Robert Haas 提交于
    Previously, fastgetattr() and heap_getattr() tested their fourth argument
    against a null pointer, but any attempt to use them with a literal-NULL
    fourth argument evaluated to *(void *)0, resulting in a compiler error.
    Remove these NULL tests to avoid leading future readers of this code to
    believe that this has a chance of working.  Also clean up related legacy
    code in nocachegetattr(), heap_getsysattr(), and nocache_index_getattr().
    
    The new coding standard is that any code which calls a getattr-type
    function or macro which takes an isnull argument MUST pass a valid
    boolean pointer.  Per discussion with Bruce Momjian, Tom Lane, Alvaro
    Herrera.
    84b6d5f3
heapam.c 145.3 KB