• T
    Repair a bunch of problems in md.c. This builds on Hiroshi's · 68c32348
    Tom Lane 提交于
    insight that RelationFlushRelation ought to invoke smgrclose, and that the
    way to make that work is to ensure that mdclose doesn't fail if the relation
    is already closed (or unlinked, if we are looking at a DROP TABLE).  While
    I was testing that, I was able to identify several problems that we had
    with multiple-segment relations.  The system is now able to do initdb and
    pass the regression tests with a very small segment size (I had it set to
    64Kb per segment for testing).  I don't believe that ever worked before.
    File descriptor leaks seem to be gone too.
    I have partially addressed the concerns we had about mdtruncate(), too.
    On a Win32 or NFS filesystem it is not possible to unlink a file that
    another backend is holding open, so what md.c now does is to truncate
    unwanted files to zero length before trying to unlink them.  The other
    backends will be forced to close their open files by relation cache
    invalidation --- but I think it would take considerable work to make
    that happen before vacuum truncates the relation rather than after.
    Leaving zero-length files lying around seems a usable compromise.
    68c32348
md.c 24.1 KB