• T
    Clean up the #include mess a little. · 1609797c
    Tom Lane 提交于
    walsender.h should depend on xlog.h, not vice versa.  (Actually, the
    inclusion was circular until a couple hours ago, which was even sillier;
    but Bruce broke it in the expedient rather than logically correct
    direction.)  Because of that poor decision, plus blind application of
    pgrminclude, we had a situation where half the system was depending on
    xlog.h to include such unrelated stuff as array.h and guc.h.  Clean up
    the header inclusion, and manually revert a lot of what pgrminclude had
    done so things build again.
    
    This episode reinforces my feeling that pgrminclude should not be run
    without adult supervision.  Inclusion changes in header files in particular
    need to be reviewed with great care.  More generally, it'd be good if we
    had a clearer notion of module layering to dictate which headers can sanely
    include which others ... but that's a big task for another day.
    1609797c
procarray.c 92.9 KB