Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Phodal
Coca
提交
3b1a7077
C
Coca
项目概览
Phodal
/
Coca
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
C
Coca
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
3b1a7077
编写于
12月 30, 2019
作者:
P
Phodal Huang
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
feat: update assertion list
上级
bd934aff
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
49 addition
and
29 deletion
+49
-29
core/domain/tbs/tbs_app.go
core/domain/tbs/tbs_app.go
+35
-25
core/domain/tbs/tbs_app_test.go
core/domain/tbs/tbs_app_test.go
+14
-4
未找到文件。
core/domain/tbs/tbs_app.go
浏览文件 @
3b1a7077
...
...
@@ -26,10 +26,10 @@ type TestBadSmell struct {
func
(
a
TbsApp
)
AnalysisPath
(
deps
[]
models
.
JClassNode
,
identifiersMap
map
[
string
]
models
.
JIdentifier
)
[]
TestBadSmell
{
var
results
[]
TestBadSmell
=
nil
var
ident
MethodMap
=
make
(
map
[
string
]
models
.
JMethod
)
for
_
,
ident
:=
range
identifiersMap
{
for
_
,
method
:=
range
ident
.
Methods
{
identMethodMap
[
ident
.
Package
+
"."
+
ident
.
ClassName
+
"."
+
method
.
Name
]
=
method
var
call
MethodMap
=
make
(
map
[
string
]
models
.
JMethod
)
for
_
,
clz
:=
range
deps
{
for
_
,
method
:=
range
clz
.
Methods
{
callMethodMap
[
clz
.
Package
+
"."
+
clz
.
Class
+
"."
+
method
.
Name
]
=
method
}
}
...
...
@@ -43,8 +43,10 @@ func (a TbsApp) AnalysisPath(deps []models.JClassNode, identifiersMap map[string
currentMethodCalls
:=
method
.
MethodCalls
for
_
,
methodCall
:=
range
currentMethodCalls
{
if
methodCall
.
Class
==
clz
.
Class
{
jMethod
:=
identMethodMap
[
getMethodCallFullPath
(
methodCall
)]
currentMethodCalls
=
append
(
currentMethodCalls
,
jMethod
.
MethodCalls
...
)
jMethod
:=
callMethodMap
[
getMethodCallFullPath
(
methodCall
)]
if
jMethod
.
Name
!=
""
{
currentMethodCalls
=
append
(
currentMethodCalls
,
jMethod
.
MethodCalls
...
)
}
}
}
...
...
@@ -64,9 +66,9 @@ func (a TbsApp) AnalysisPath(deps []models.JClassNode, identifiersMap map[string
checkRedundantPrintTest
(
clz
.
Path
,
methodCall
,
&
results
,
&
testType
)
checkSleepyTest
(
clz
.
Path
,
methodCall
,
method
,
&
results
,
&
testType
)
checkRedundantAssertionTest
(
clz
.
Path
,
methodCall
,
method
,
&
results
,
&
testType
)
methodName
:=
methodCall
.
MethodName
if
hasAssertion
(
methodName
)
{
if
hasAssertion
(
methodCall
.
MethodName
)
{
hasAssert
=
true
}
...
...
@@ -77,23 +79,27 @@ func (a TbsApp) AnalysisPath(deps []models.JClassNode, identifiersMap map[string
}
}
checkDuplicateAssertTest
(
clz
,
&
results
,
methodCallMap
,
&
testType
)
checkDuplicateAssertTest
(
clz
,
&
results
,
methodCallMap
,
method
,
&
testType
)
}
}
return
results
}
func
checkRedundantAssertionTest
(
path
string
,
call
models
.
JMethodCall
,
method
models
.
JMethod
,
result
*
[]
TestBadSmell
,
testType
*
string
)
{
}
func
hasAssertion
(
methodName
string
)
bool
{
methodName
=
strings
.
ToLower
(
methodName
)
assertionList
:=
[]
string
{
"assert"
,
"should"
,
"check"
,
// ArchUnit,
"maynotbe"
,
// ArchUnit,
"is"
,
// RestAssured,
"spec"
,
// RestAssured,
"verify"
,
// Mockito,
"check"
,
// ArchUnit,
"maynotbe"
,
// ArchUnit,
"is"
,
// RestAssured,
"spec"
,
// RestAssured,
"verify"
,
// Mockito,
}
for
_
,
assertion
:=
range
assertionList
{
...
...
@@ -127,24 +133,28 @@ func checkUnknownTest(clz models.JClassNode, method models.JMethod, results *[]T
*
results
=
append
(
*
results
,
tbs
)
}
func
checkDuplicateAssertTest
(
clz
models
.
JClassNode
,
results
*
[]
TestBadSmell
,
methodCallMap
map
[
string
][]
models
.
JMethodCall
,
testType
*
string
)
{
func
checkDuplicateAssertTest
(
clz
models
.
JClassNode
,
results
*
[]
TestBadSmell
,
methodCallMap
map
[
string
][]
models
.
JMethodCall
,
method
models
.
JMethod
,
testType
*
string
)
{
var
isDuplicateAssert
=
false
for
_
,
methodCall
:=
range
methodCallMap
{
if
len
(
methodCall
)
>=
DuplicatedAssertionLimitLength
{
methodName
:=
methodCall
[
len
(
methodCall
)
-
1
]
.
MethodName
if
hasAssertion
(
methodName
)
{
*
testType
=
"DuplicateAssertTest"
tbs
:=
*&
TestBadSmell
{
FileName
:
clz
.
Path
,
Type
:
*
testType
,
Description
:
""
,
Line
:
methodCall
[
len
(
methodCall
)
-
1
]
.
StartLine
,
}
*
results
=
append
(
*
results
,
tbs
)
isDuplicateAssert
=
true
}
}
}
if
isDuplicateAssert
{
*
testType
=
"DuplicateAssertTest"
tbs
:=
*&
TestBadSmell
{
FileName
:
clz
.
Path
,
Type
:
*
testType
,
Description
:
""
,
Line
:
method
.
StartLine
,
}
*
results
=
append
(
*
results
,
tbs
)
}
}
func
getMethodCallFullPath
(
methodCall
models
.
JMethodCall
)
string
{
...
...
core/domain/tbs/tbs_app_test.go
浏览文件 @
3b1a7077
package
tbs
import
(
"fmt"
.
"github.com/onsi/gomega"
"github.com/phodal/coca/core/adapter"
"github.com/phodal/coca/core/adapter/call"
...
...
@@ -63,7 +62,8 @@ func TestTbsApp_DuplicateAssertTest(t *testing.T) {
result
:=
buildTbsResult
(
codePath
)
g
.
Expect
(
result
[
0
]
.
Line
)
.
To
(
Equal
(
23
))
g
.
Expect
(
len
(
result
))
.
To
(
Equal
(
1
))
g
.
Expect
(
result
[
0
]
.
Line
)
.
To
(
Equal
(
9
))
g
.
Expect
(
result
[
0
]
.
Type
)
.
To
(
Equal
(
"DuplicateAssertTest"
))
}
...
...
@@ -79,6 +79,17 @@ func TestTbsApp_UnknownTest(t *testing.T) {
g
.
Expect
(
result
[
1
]
.
Type
)
.
To
(
Equal
(
"UnknownTest"
))
}
func
TestTbsApp_RedundantAssertionTest
(
t
*
testing
.
T
)
{
g
:=
NewGomegaWithT
(
t
)
codePath
:=
"../../../_fixtures/tbs/code/RedundantAssertionTest.java"
codePath
=
filepath
.
FromSlash
(
codePath
)
result
:=
buildTbsResult
(
codePath
)
g
.
Expect
(
len
(
result
))
.
To
(
Equal
(
1
))
//g.Expect(result[0].Type).To(Equal("EmptyTest"))
}
func
TestTbsApp_CreatorNotUnknownTest
(
t
*
testing
.
T
)
{
g
:=
NewGomegaWithT
(
t
)
codePath
:=
"../../../_fixtures/tbs/regression/CreatorNotUnknownTest.java"
...
...
@@ -96,8 +107,7 @@ func TestTbsApp_CallAssertInClassTests(t *testing.T) {
result
:=
buildTbsResult
(
codePath
)
fmt
.
Println
(
result
)
g
.
Expect
(
len
(
result
))
.
To
(
Equal
(
1
))
g
.
Expect
(
len
(
result
))
.
To
(
Equal
(
0
))
}
func
buildTbsResult
(
codePath
string
)
[]
TestBadSmell
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录