提交 c205e986 编写于 作者: J Jingwen Owen Ou

Fix NewProjectWithUrl which assume the wrong number of path segments

上级 44181941
......@@ -104,13 +104,13 @@ func NewProjectFromURL(url *url.URL) (p *Project, err error) {
}
parts := strings.SplitN(url.Path, "/", 4)
if len(parts) < 2 {
if len(parts) <= 2 {
err = fmt.Errorf("Invalid GitHub URL: %s", url)
return
}
name := strings.TrimSuffix(parts[2], ".git")
p = &Project{Name: name, Owner: parts[1], Host: url.Host}
p = NewProject(parts[1], name, url.Host)
return
}
......
......@@ -119,4 +119,9 @@ func TestNewProjectFromURL(t *testing.T) {
assert.Equal(t, nil, err)
assert.Equal(t, "go-octokit", p.Name)
assert.Equal(t, "octokit", p.Owner)
u, _ = url.Parse("origin/master")
_, err = NewProjectFromURL(u)
assert.NotEqual(t, nil, err)
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册