Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
github
hub
提交
9cb62f9f
H
hub
项目概览
github
/
hub
大约 1 年 前同步成功
通知
3
Star
22523
Fork
2406
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
H
hub
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
9cb62f9f
编写于
6月 25, 2019
作者:
M
Mislav Marohnić
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[pull-request] Avoid crash when branch is pushed to a non-GitHub remote
上级
936f704c
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
22 addition
and
1 deletion
+22
-1
commands/pull_request.go
commands/pull_request.go
+1
-1
features/pull_request.feature
features/pull_request.feature
+18
-0
github/branch.go
github/branch.go
+3
-0
未找到文件。
commands/pull_request.go
浏览文件 @
9cb62f9f
...
...
@@ -141,7 +141,7 @@ func pullRequest(cmd *Command, args *Args) {
trackedBranch
,
headProject
,
_
:=
localRepo
.
RemoteBranchAndProject
(
host
.
User
,
false
)
if
headProject
==
nil
{
utils
.
Check
(
err
)
utils
.
Check
(
fmt
.
Errorf
(
"could not determine project for head branch"
)
)
}
var
(
...
...
features/pull_request.feature
浏览文件 @
9cb62f9f
...
...
@@ -899,6 +899,24 @@ Feature: hub pull-request
When
I successfully run `hub pull-request -m hereyougo`
Then the output should contain exactly "the
:
//url\n"
Scenario
:
Create pull request to "github" remote when "origin" is non-GitHub
Given the "github" remote has url "git@github.com
:
sam-hart-swanson/debug.git"
Given the "origin" remote has url "ssh
:
//git
@private.server.com/path/to/repo.git"
And
I am on the
"feat/123-some-branch"
branch pushed to
"github/feat/123-some-branch"
And
an empty file named
".git/refs/remotes/origin/feat/123-some-branch"
Given the GitHub API server
:
"""
post('/repos/sam-hart-swanson/debug/pulls') {
assert :base => 'master',
:head => 'sam-hart-swanson:feat/123-some-branch',
:title => 'hereyougo'
status 201
json :html_url => "the://url"
}
"""
When
I successfully run `hub pull-request -m hereyougo`
Then the output should contain exactly "the
:
//url\n"
Scenario
:
Open pull request in web browser
Given
I am on the
"topic"
branch pushed to
"origin/topic"
Given the GitHub API server
:
...
...
github/branch.go
浏览文件 @
9cb62f9f
...
...
@@ -48,6 +48,9 @@ func (b *Branch) PushTarget(owner string, preferUpstream bool) (branch *Branch)
}
for
_
,
remote
:=
range
remotesInOrder
{
if
_
,
err
:=
remote
.
Project
();
err
!=
nil
{
continue
}
if
git
.
HasFile
(
"refs"
,
"remotes"
,
remote
.
Name
,
shortName
)
{
name
:=
fmt
.
Sprintf
(
"refs/remotes/%s/%s"
,
remote
.
Name
,
shortName
)
branch
=
&
Branch
{
b
.
Repo
,
name
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录