提交 95bd9440 编写于 作者: J Jingwen Owen Ou

Ignore looking into ssh config if URL scheme is http or https

See https://github.com/github/hub/issues/681
上级 aabc10b2
......@@ -25,6 +25,10 @@ func (p *URLParser) Parse(rawURL string) (u *url.URL, err error) {
return
}
if u.Scheme == "http" || u.Scheme == "https" {
return
}
sshHost := p.SSHConfig[u.Host]
// ignore replacing host that fixes for limited network
// https://help.github.com/articles/using-ssh-over-the-https-port
......
......@@ -34,7 +34,19 @@ func TestURLParser_ParseURL(t *testing.T) {
u, err = p.Parse("https://git.company.com/octokit/go-octokit.git")
assert.Equal(t, nil, err)
assert.Equal(t, "ssh.git.company.com", u.Host)
assert.Equal(t, "git.company.com", u.Host)
assert.Equal(t, "https", u.Scheme)
assert.Equal(t, "/octokit/go-octokit.git", u.Path)
u, err = p.Parse("git://git.company.com/octokit/go-octokit.git")
assert.Equal(t, nil, err)
assert.Equal(t, "ssh.git.company.com", u.Host)
assert.Equal(t, "git", u.Scheme)
assert.Equal(t, "/octokit/go-octokit.git", u.Path)
u, err = p.Parse("git@git.company.com:octokit/go-octokit")
assert.Equal(t, nil, err)
assert.Equal(t, "ssh.git.company.com", u.Host)
assert.Equal(t, "ssh", u.Scheme)
assert.Equal(t, "/octokit/go-octokit", u.Path)
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册