Merge pull request #652 from github/karma-update

Update Karma and detect available browsers when testing

package.json

@@ -11,11 +11,14 @@
     "chai": "^4.1.2",
     "eslint": "^4.19.1",
     "eslint-plugin-github": "^1.0.0",
-    "karma": "^1.7.1",
+    "karma": "^3.0.0",
     "karma-chai": "^0.1.0",
     "karma-chrome-launcher": "^2.2.0",
-    "karma-firefox-launcher": "^1.0.1",
+    "karma-detect-browsers": "^2.3.2",
+    "karma-firefox-launcher": "^1.1.0",
     "karma-mocha": "^1.3.0",
+    "karma-safari-launcher": "^1.0.0",
+    "karma-safaritechpreview-launcher": "0.0.6",
     "mocha": "^4.0.1",
     "promise-polyfill": "6.0.2",
     "rollup": "^0.59.1",

test/karma-worker.config.js

@@ -3,7 +3,7 @@ const parentConfig = require('./karma.config')
 module.exports = function(config) {
   parentConfig(config)
   config.set({
-    frameworks: ['mocha'],
+    frameworks: ['detectBrowsers', 'mocha'],
     files: [
       'test/worker-adapter.js',
       {

test/karma.config.js

@@ -3,7 +3,18 @@ const serverEndpoints = require('./server')
 module.exports = function(config) {
   config.set({
     basePath: '..',
-    frameworks: ['mocha', 'chai'],
+    frameworks: ['detectBrowsers', 'mocha', 'chai'],
+    detectBrowsers: {
+      preferHeadless: true,
+      usePhantomJS: false,
+      postDetection: availableBrowsers =>
+        availableBrowsers
+          .filter(
+            browser =>
+              !process.env.CI || !browser.startsWith('Chromium') || !availableBrowsers.some(b => b.startsWith('Chrome'))
+          )
+          .map(browser => (browser.startsWith('Chrom') ? `${browser}NoSandbox` : browser))
+    },
     client: {
       mocha: {
         ui: 'tdd'
@@ -20,7 +31,6 @@ module.exports = function(config) {
     port: 9876,
     colors: true,
     logLevel: process.env.CI ? config.LOG_WARN : config.LOG_INFO,
-    browsers: ['ChromeHeadlessNoSandbox', 'FirefoxHeadless'],
     autoWatch: false,
     singleRun: true,
     concurrency: Infinity,
@@ -29,10 +39,9 @@ module.exports = function(config) {
         base: 'ChromeHeadless',
         flags: ['--no-sandbox']
       },
-      FirefoxHeadless: {
-        base: 'Firefox',
-        flags: ['-headless'],
-        displayName: 'HeadlessFirefox'
+      ChromiumHeadlessNoSandbox: {
+        base: 'ChromiumHeadless',
+        flags: ['--no-sandbox']
       }
     },
     beforeMiddleware: ['custom'],

test/test.js

 var IEorEdge = /Edge\//.test(navigator.userAgent) || /MSIE/.test(navigator.userAgent)
+var Chrome = /Chrome\//.test(navigator.userAgent) && !IEorEdge
+var Safari = /Safari\//.test(navigator.userAgent) && !IEorEdge && !Chrome
 
 var support = {
   url: (function(url) {
@@ -116,12 +118,14 @@ exercise.forEach(function(exerciseMode) {
       })
     }
 
-    var nativeChrome = /Chrome\//.test(navigator.userAgent) && !IEorEdge && exerciseMode === 'native'
-    var nativeSafari = /Safari\//.test(navigator.userAgent) && !IEorEdge && exerciseMode === 'native'
+    var nativeChrome = Chrome && exerciseMode === 'native'
+    var nativeSafari = Safari && exerciseMode === 'native'
     var nativeEdge = /Edge\//.test(navigator.userAgent) && exerciseMode === 'native'
     var firefox = navigator.userAgent.match(/Firefox\/(\d+)/)
     var brokenFF = firefox && firefox[1] <= 56 && exerciseMode === 'native'
     var polyfillFirefox = firefox && exerciseMode === 'polyfill'
+    var omitSafari =
+      Safari && exerciseMode === 'native' && navigator.userAgent.match(/Version\/(\d+\.\d+)/)[1] <= '11.1'
 
     // https://fetch.spec.whatwg.org/#concept-bodyinit-extract
     function testBodyExtract(factory) {
@@ -541,7 +545,7 @@ exercise.forEach(function(exerciseMode) {
         return new Request('', {method: 'POST', body: body})
       })
 
-      test('credentials defaults to same-origin', function() {
+      featureDependent(test, !omitSafari, 'credentials defaults to same-origin', function() {
         var request = new Request('')
         assert.equal(request.credentials, 'same-origin')
       })
@@ -1104,13 +1108,10 @@ exercise.forEach(function(exerciseMode) {
             controller.abort()
           }, 30)
 
-          var start = new Date()
-
           return fetch('/slow?_=' + new Date().getTime(), {
             signal: controller.signal
           }).then(
             function() {
-              assert.isAtLeast(new Date() - start, 100, 'request finished too soon')
               assert.ok(false)
             },
             function(error) {
@@ -1127,11 +1128,8 @@ exercise.forEach(function(exerciseMode) {
             controller.abort()
           }, 30)
 
-          var start = new Date()
-
           return fetch(request).then(
             function() {
-              assert.isAtLeast(new Date() - start, 100, 'request finished too soon')
               assert.ok(false)
             },
             function(error) {