未验证 提交 1771aa50 编写于 作者: G gabry.wu 提交者: GitHub

change variable name ,make it easy to understand (#2647)

Co-authored-by: Ndailidong <dailidong66@gmail.com>
上级 0226f9f9
...@@ -56,7 +56,7 @@ public class EmailAlertPlugin implements AlertPlugin { ...@@ -56,7 +56,7 @@ public class EmailAlertPlugin implements AlertPlugin {
@Override @Override
public String getId() { public String getId() {
return Constants.PLUGIN_DEFAULT_EMAIL; return Constants.PLUGIN_DEFAULT_EMAIL_ID;
} }
@Override @Override
......
...@@ -80,7 +80,7 @@ public class AlertSender { ...@@ -80,7 +80,7 @@ public class AlertSender {
alertInfo.addProp("receivers", receviersList); alertInfo.addProp("receivers", receviersList);
AlertPlugin emailPlugin = pluginManager.findOne(Constants.PLUGIN_DEFAULT_EMAIL); AlertPlugin emailPlugin = pluginManager.findOne(Constants.PLUGIN_DEFAULT_EMAIL_ID);
retMaps = emailPlugin.process(alertInfo); retMaps = emailPlugin.process(alertInfo);
if (retMaps == null) { if (retMaps == null) {
......
...@@ -179,7 +179,7 @@ public class Constants { ...@@ -179,7 +179,7 @@ public class Constants {
*/ */
public static final String PLUGIN_DIR = "plugin.dir"; public static final String PLUGIN_DIR = "plugin.dir";
public static final String PLUGIN_DEFAULT_EMAIL = "email"; public static final String PLUGIN_DEFAULT_EMAIL_ID = "email";
public static final String PLUGIN_DEFAULT_EMAIL_CH = "邮件"; public static final String PLUGIN_DEFAULT_EMAIL_CH = "邮件";
......
...@@ -47,7 +47,7 @@ public class EmailAlertPluginTest { ...@@ -47,7 +47,7 @@ public class EmailAlertPluginTest {
@Test @Test
public void getId() { public void getId() {
String id = plugin.getId(); String id = plugin.getId();
assertEquals(Constants.PLUGIN_DEFAULT_EMAIL, id); assertEquals(Constants.PLUGIN_DEFAULT_EMAIL_ID, id);
} }
@Test @Test
......
...@@ -90,8 +90,8 @@ public class FilePluginManager implements PluginManager { ...@@ -90,8 +90,8 @@ public class FilePluginManager implements PluginManager {
} }
@Override @Override
public AlertPlugin findOne(String name) { public AlertPlugin findOne(String pluginId) {
return pluginMap.get(name); return pluginMap.get(pluginId);
} }
@Override @Override
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册