fix code review issues

ui/src/store/websoket.ts

-import {Mutation, Action, ActionContext} from 'vuex';
+import {Mutation, Action} from 'vuex';
 import { StoreModuleType } from "@/utils/store";
 import {WebSocket} from "@/services/websocket";
 

ui/src/utils/cache.ts

@@ -12,14 +12,14 @@ export const setExecBy = async (execBy) => {
 }
 
 export const getInitStatus = async () => {
-    return await getCache(settings.initStatus);
+    return getCache(settings.initStatus);
 }
 export const setInitStatus = async () => {
     await setCache(settings.initStatus, true);
 }
 
 export const getCurrSiteId = async () => {
-    return await getCache(settings.currSiteId);
+    return getCache(settings.currSiteId);
 }
 export const setCurrSiteId = async (val) => {
     await setCache(settings.currSiteId, val);

ui/src/utils/localCache.ts

 
 import localforage from 'localforage';
-import settings from '@/config/settings';
 
 export const getCache = async (key: string): Promise<any | null> => {
   return localforage.getItem(key);

ui/src/utils/routes.ts

@@ -18,7 +18,6 @@ import { RouteRecordRaw,  RouteLocationNormalizedLoaded } from 'vue-router';
  */
 export type TabNavType = 'path' | 'querypath';
 
-import 'vue-router'
 declare module 'vue-router' {
   /**
    * 自定义补充扩展 - 路由 - 类型字段

ui/src/views/script/TreeContextMenu.vue

@@ -35,7 +35,7 @@
 </template>
 
 <script lang="ts">
-import {computed, defineComponent, PropType, ref, Ref} from "vue";
+import {computed, defineComponent, PropType, ref} from "vue";
 import {useI18n} from "vue-i18n";
 import {useStore} from "vuex";
 import {ScriptData} from "@/views/script/store";

ui/src/views/script/component/tree.vue

@@ -161,7 +161,6 @@
 <script setup lang="ts">
 import {
   computed,
-  defineComponent,
   onMounted, onUnmounted,
   ref,
   watch
@@ -170,7 +169,7 @@ import {useStore} from "vuex";
 import {useI18n} from "vue-i18n";
 
 import {ScriptData} from "../store";
-import {Empty, Modal, notification} from "ant-design-vue";
+import {Modal, notification} from "ant-design-vue";
 
 import bus from "@/utils/eventBus";
 import {ZentaoData} from "@/store/zentao";
@@ -198,7 +197,6 @@ import {isWindows} from "@/utils/comm";
 import {testToolMap} from "@/utils/testing";
 import {ExecStatus} from "@/store/exec";
 import debounce from "lodash.debounce";
-import throttle from "lodash.debounce";
 import TreeContextMenu from "./treeContextMenu.vue"
 import {ZentaoCasePrefix} from "@/utils/const";
 
@@ -495,7 +493,7 @@ import {isInArray} from "@/utils/array";
     const nameFormVisible = ref(false)
 
     const treeDataMap = {}
-    const getNodeMapCall = throttle(async () => {
+    const getNodeMapCall = debounce(async () => {
       getNodeMap(treeData.value[0], treeDataMap)
     }, 300)
 

ui/src/views/script/index.vue

@@ -20,15 +20,13 @@ import {
   computed,
   defineComponent,
   onMounted,
-  ref,
-  watch
 } from "vue";
 import {useStore} from "vuex";
 import {useI18n} from "vue-i18n";
 
 import {ScriptData} from "./store";
-import {resizeWidth, resizeHeight} from "@/utils/dom";
-import {Empty, notification} from "ant-design-vue";
+import {resizeWidth} from "@/utils/dom";
+import {Empty} from "ant-design-vue";
 
 import {ZentaoData} from "@/store/zentao";
 

ui/src/views/script/service.ts

@@ -218,27 +218,22 @@ export const getFileNodesUnderParent = (node): string[] => {
     getNodeMap(node, nodeMap)
 
     const arr = [] as string[]
-    Object.keys(nodeMap).forEach((k, v) => {
-        const node = nodeMap[k]
-        if (node.type === 'file') {
-            node.childrem = null
-            arr.push(node)
+    Object.keys(nodeMap).forEach((k, _v) => {
+        const item = nodeMap[k]
+        if (item.type === 'file') {
+            item.childrem = null
+            arr.push(item)
         }
     })
 
     return arr
 }
 
-export function getSyncToInfoFromMenu(key: string, node: any): any {
-
-    return
-}
-
 export function scriptTreeAddAttr(treeData) {
     if(treeData == undefined){
         return treeData;
     }
-    treeData = treeData.map((item, index) => {
+    treeData = treeData.map((item) => {
         item.id = item.path;
         item.checkable = item.workspaceType == 'ztf' ? true : false;
         if (item.isLeaf) {

ui/src/views/script/store.ts

@@ -107,7 +107,7 @@ const StoreModel: ModuleType = {
             commit('setQueryParams', playload);
             return true;
         },
-        async loadChildren({ commit }, treeNode: any ) {
+        async loadChildren(_ctx, treeNode: any ) {
             console.log('load node children', treeNode.dataRef.workspaceType)
             if (treeNode.dataRef.workspaceType === 'ztf')
                 return true
@@ -118,19 +118,16 @@ const StoreModel: ModuleType = {
             })
         },
 
-        async getScript({ commit, dispatch }, script: any ) {
+        async getScript({ commit}, script: any ) {
             if (!script || script.type !== 'file') {
                 commit('setItem', null);
-                return true;
-            }
-
-            if (script.path.indexOf('zentao-') === 0) {
+            } else if (script.path.indexOf('zentao-') === 0) {
                 commit('setItem', {id: script.caseId, workspaceId: script.workspaceId, code: ScriptFileNotExist});
-                return true;
+            } else {
+                const response: ResponseData = await get(script.path, script.workspaceId);
+                commit('setItem', response.data);
             }
 
-            const response: ResponseData = await get(script.path, script.workspaceId);
-            commit('setItem', response.data);
             return true;
         },
 
@@ -150,7 +147,7 @@ const StoreModel: ModuleType = {
             return resp
         },
 
-        async syncToZentao({ commit, dispatch, state }, payload: any ) {
+        async syncToZentao({ dispatch, state }, payload: any ) {
             const resp = await syncToZentao(payload)
 
             if (resp.code === 0) {
@@ -170,7 +167,7 @@ const StoreModel: ModuleType = {
             return data.done
         },
 
-        async createScript({ commit , dispatch, state}, payload: any) {
+        async createScript({ dispatch, state}, payload: any) {
             try {
                 const jsn = await create(payload);
                 const path = jsn.data
@@ -182,7 +179,7 @@ const StoreModel: ModuleType = {
                 return ''
             }
         },
-        async updateScript({ commit }, payload: any ) {
+        async updateScript(_ctx, payload: any ) {
             try {
                 const { id, ...params } = payload;
                 await update(id, { ...params });
@@ -192,7 +189,7 @@ const StoreModel: ModuleType = {
             }
         },
 
-        async updateCode({ commit, dispatch, state }, payload: any ) {
+        async updateCode({ dispatch, state }, payload: any ) {
             try {
                 await updateCode(payload);
                 await dispatch('listScript', state.queryParams)
@@ -202,7 +199,7 @@ const StoreModel: ModuleType = {
             }
         },
 
-        async pasteScript({ commit , dispatch, state}, data: any ) {
+        async pasteScript({ dispatch, state}, data: any ) {
             try {
                 await paste(data);
                 await dispatch('listScript', state.queryParams)
@@ -213,7 +210,7 @@ const StoreModel: ModuleType = {
             }
         },
 
-        async moveScript({ commit , dispatch, state}, data: any ) {
+        async moveScript({ dispatch, state}, data: any ) {
             try {
                 await move(data);
                 await dispatch('listScript', state.queryParams)
@@ -224,7 +221,7 @@ const StoreModel: ModuleType = {
             }
         },
 
-        async deleteScript({ commit , dispatch, state}, path: string ) {
+        async deleteScript({ dispatch, state}, path: string ) {
             try {
                 await remove(path);
                 await dispatch('listScript', state.queryParams)

ui/src/views/site/store.ts

@@ -76,7 +76,7 @@ const StoreModel: ModuleType = {
             commit('setDetailResult',data);
             return true;
         },
-        async save({ commit }, payload) {
+        async save(_ctx, payload) {
             try {
                 await save(payload);
                 return true;
@@ -84,7 +84,7 @@ const StoreModel: ModuleType = {
                 return false;
             }
         },
-        async delete({ commit , dispatch, state}, id: number ) {
+        async delete({ dispatch, state}, id: number ) {
             try {
                 await remove(id);
                 dispatch('list', {})

ui/src/views/workspace/store.ts

@@ -97,7 +97,7 @@ const StoreModel: ModuleType = {
             commit('setDetailResult',data);
             return true;
         },
-        async save({ commit }, payload) {
+        async save(_ctx, payload) {
             try {
                 await save(payload);
                 return true;
@@ -105,7 +105,7 @@ const StoreModel: ModuleType = {
                 return false;
             }
         },
-        async delete({ commit , dispatch, state}, id: number ) {
+        async delete({ dispatch}, id: number ) {
             try {
                 await remove(id);
                 dispatch('list', {})