提交 bf72938a 编写于 作者: C Chesnay Schepler

[FLINK-20792][build] Allow shorthand calls to spotless

It was not possible to just run 'mvn spotless:check', but instead one needed to use the fully qualified name of the plugin, i.e., 'mvn com.diffplug.spotless:spotless-maven-plugin:check'.

This is due to 'force-shading'; this module is declared as a child of the flink-parent pom (i.e., the root pom of the project), but is not actually declaring that very module as it's parent.
This seems to throw of maven, which fails to retrieve the plugin information from the parent.

Note that this is just a band-aid; a proper fix would declare flink-parent as the parent of force-shading, but this is the easier fix.
上级 96d8c0d4
......@@ -1827,9 +1827,6 @@ under the License.
</configuration>
</plugin>
<!-- Due to the Flink build setup, "mvn spotless:apply" and "mvn spotless:check"
don't work. You have to use the fully qualified name, i.e.
"mvn com.diffplug.spotless:spotless-maven-plugin:apply" -->
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
......
......@@ -43,6 +43,21 @@ under the License.
<packaging>jar</packaging>
<build>
<pluginManagement>
<plugins>
<plugin>
<!-- This only exists to allow shorthand invocations on the command-line
i.e., 'mvn spotless:check'
This is necessary because this module does not declare the flink-parent pom as its parent -->
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>2.4.2</version>
</plugin>
</plugins>
</pluginManagement>
</build>
<profiles>
<profile>
<id>release</id>
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册