提交 920cda40 编写于 作者: A Alexander Pivovarov 提交者: zentol

[FLINK-4595] Close FileOutputStream in ParameterTool

This closes #2478
上级 7e07bde8
......@@ -31,6 +31,7 @@ import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.io.Serializable;
import java.util.Arrays;
import java.util.HashMap;
......@@ -523,7 +524,9 @@ public class ParameterTool extends ExecutionConfig.GlobalJobParameters implement
}
Properties defaultProps = new Properties();
defaultProps.putAll(this.defaultData);
defaultProps.store(new FileOutputStream(file), "Default file created by Flink's ParameterUtil.createPropertiesFile()");
try (final OutputStream out = new FileOutputStream(file)) {
defaultProps.store(out, "Default file created by Flink's ParameterUtil.createPropertiesFile()");
}
}
@Override
......
......@@ -29,6 +29,7 @@ import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.OutputStream;
import java.util.Map;
import java.util.Properties;
......@@ -118,7 +119,9 @@ public class ParameterToolTest {
Properties props = new Properties();
props.setProperty("input", "myInput");
props.setProperty("expectedCount", "15");
props.store(new FileOutputStream(propertiesFile), "Test properties");
try (final OutputStream out = new FileOutputStream(propertiesFile)) {
props.store(out, "Test properties");
}
ParameterTool parameter = ParameterTool.fromPropertiesFile(propertiesFile.getAbsolutePath());
Assert.assertEquals(2, parameter.getNumberOfParameters());
validate(parameter);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册