Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
doujutun3207
flink
提交
91f00ec9
F
flink
项目概览
doujutun3207
/
flink
与 Fork 源项目一致
从无法访问的项目Fork
通知
24
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
F
flink
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
91f00ec9
编写于
12月 26, 2017
作者:
X
Xpray
提交者:
sunjincheng121
12月 29, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FLINK-8312][table] Fix ScalarFunction varargs length exceed 254
This closes #5206
上级
d74869f8
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
44 addition
and
10 deletion
+44
-10
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
...pache/flink/table/functions/utils/ScalarSqlFunction.scala
+17
-10
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
...org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
+27
-0
未找到文件。
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
浏览文件 @
91f00ec9
...
...
@@ -140,7 +140,7 @@ object ScalarSqlFunction {
scalarFunction
:
ScalarFunction
)
:
SqlOperandTypeChecker
=
{
val
signatures
=
getMethodSignature
s
(
scalarFunction
,
"eval"
)
val
methods
=
checkAndExtractMethod
s
(
scalarFunction
,
"eval"
)
/**
* Operand type checker based on [[ScalarFunction]] given information.
...
...
@@ -151,17 +151,24 @@ object ScalarSqlFunction {
}
override
def
getOperandCountRange
:
SqlOperandCountRange
=
{
var
min
=
25
5
var
min
=
25
4
// according to JVM spec 4.3.3
var
max
=
-
1
signatures
.
foreach
(
sig
=>
{
var
len
=
sig
.
length
if
(
len
>
0
&&
sig
(
sig
.
length
-
1
).
isArray
)
{
max
=
254
// according to JVM spec 4.3.3
len
=
sig
.
length
-
1
var
isVarargs
=
false
methods
.
foreach
(
m
=>
{
var
len
=
m
.
getParameterTypes
.
length
if
(
len
>
0
&&
m
.
isVarArgs
&&
m
.
getParameterTypes
()(
len
-
1
).
isArray
)
{
isVarargs
=
true
len
=
len
-
1
}
max
=
Math
.
max
(
len
,
max
)
min
=
Math
.
min
(
len
,
min
)
}
max
=
Math
.
max
(
len
,
max
)
min
=
Math
.
min
(
len
,
min
)
})
)
if
(
isVarargs
)
{
// if eval method is varargs, set max to -1 to skip length check in Calcite
max
=
-
1
}
SqlOperandCountRanges
.
between
(
min
,
max
)
}
...
...
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
浏览文件 @
91f00ec9
...
...
@@ -26,10 +26,12 @@ import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
import
org.apache.flink.table.api.
{
TableEnvironment
,
Types
}
import
org.apache.flink.table.api.scala._
import
org.apache.flink.table.expressions.utils.SplitUDF
import
org.apache.flink.table.expressions.utils.Func15
import
org.apache.flink.table.runtime.utils.TimeTestUtil.EventTimeSourceFunction
import
org.apache.flink.table.runtime.utils.
{
StreamITCase
,
StreamTestData
,
StreamingWithStateTestBase
}
import
org.apache.flink.types.Row
import
org.apache.flink.table.utils.MemoryTableSinkUtil
import
org.junit.Assert._
import
org.junit._
...
...
@@ -516,4 +518,29 @@ class SqlITCase extends StreamingWithStateTestBase {
val
expected
=
List
(
"a,a,d,d,e,e"
,
"x,x,z,z,z,z"
)
assertEquals
(
expected
.
sorted
,
StreamITCase
.
testResults
.
sorted
)
}
@Test
def
testUDFWithLongVarargs
()
:
Unit
=
{
val
env
=
StreamExecutionEnvironment
.
getExecutionEnvironment
val
tEnv
=
TableEnvironment
.
getTableEnvironment
(
env
)
StreamITCase
.
clear
tEnv
.
registerFunction
(
"func15"
,
Func15
)
val
parameters
=
"c,"
+
(
0
until
255
).
map
(
_
=>
"a"
).
mkString
(
","
)
val
sqlQuery
=
s
"SELECT func15($parameters) FROM T1"
val
t1
=
StreamTestData
.
getSmall3TupleDataStream
(
env
).
toTable
(
tEnv
).
as
(
'a
,
'b
,
'c
)
tEnv
.
registerTable
(
"T1"
,
t1
)
val
result
=
tEnv
.
sqlQuery
(
sqlQuery
).
toAppendStream
[
Row
]
result
.
addSink
(
new
StreamITCase
.
StringSink
[
Row
])
env
.
execute
()
val
expected
=
List
(
"Hi255"
,
"Hello255"
,
"Hello world255"
)
assertEquals
(
expected
.
sorted
,
StreamITCase
.
testResults
.
sorted
)
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录