提交 39ac5ab0 编写于 作者: S Stephan Ewen

[FLINK-514] Fix additional javadoc problems and add suppressions for certain compiler warnings.

上级 c8054a3a
......@@ -143,7 +143,6 @@ public abstract class GUIServletStub extends HttpServlet {
+ "</div></h1>");
writer.println(" </div>");
@SuppressWarnings("unchecked")
Map<String, String[]> m = (Map<String, String[]>) req.getParameterMap();
// let the content be printed by the child class
......
......@@ -16,7 +16,6 @@
* limitations under the License.
*/
package org.apache.flink.api.common.typeutils;
import java.io.IOException;
......@@ -297,6 +296,7 @@ public abstract class TypeComparator<T> implements Serializable {
* Get the field comparators. This is used together with {@link #extractKeys(Object)} to provide
* interoperability between different record types.
*/
@SuppressWarnings("rawtypes")
public abstract TypeComparator[] getComparators();
// --------------------------------------------------------------------------------------------
......
......@@ -34,9 +34,11 @@ public abstract class BasicTypeComparator<T extends Comparable<T>> extends TypeC
protected final boolean ascendingComparison;
// This is used in extractKeys, so that we don't create a new array for every call.
@SuppressWarnings("rawtypes")
private final Comparable[] extractedKey = new Comparable[1];
// For use by getComparators
@SuppressWarnings("rawtypes")
private final TypeComparator[] comparators = new TypeComparator[] {this};
......@@ -93,6 +95,7 @@ public abstract class BasicTypeComparator<T extends Comparable<T>> extends TypeC
}
@Override
@SuppressWarnings("rawtypes")
public TypeComparator[] getComparators() {
return comparators;
}
......
......@@ -653,7 +653,8 @@ public abstract class DataSet<T> {
* second input being the second field of the tuple.
*
* <p>
* Call {@link org.apache.flink.api.java.operators.CrossOperator.DefaultCross#with(org.apache.flink.api.common.functions.CrossFunction)} to define a {@link CrossFunction} which is called for
* Call {@link org.apache.flink.api.java.operators.CrossOperator.DefaultCross#with(org.apache.flink.api.common.functions.CrossFunction)} to define a
* {@link org.apache.flink.api.common.functions.CrossFunction} which is called for
* each pair of crossed elements. The CrossFunction returns a exactly one element for each pair of input elements.</br>
*
* @param other The other DataSet with which this DataSet is crossed.
......
......@@ -152,7 +152,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1, I2, OUT,
* The order of fields in the output tuple is defined by to the order of field indexes.
* @return A CrossProjection that needs to be converted into a
* {@link org.apache.flink.api.java.operators.CrossOperator.ProjectCross} to complete the
* Cross transformation by calling {@link CrossProjection#types(Class)}.
* Cross transformation by calling
* {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
*
* @see Tuple
* @see DataSet
......@@ -177,7 +178,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1, I2, OUT,
* The order of fields in the output tuple is defined by to the order of field indexes.
* @return A CrossProjection that needs to be converted into a
* {@link org.apache.flink.api.java.operators.CrossOperator.ProjectCross} to complete the
* Cross transformation by calling {@link CrossProjection#types(Class)}.
* Cross transformation by calling
* {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
*
* @see Tuple
* @see DataSet
......@@ -379,7 +381,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1, I2, OUT,
* For a non-Tuple DataSet, do not provide parameters.
* The order of fields in the output tuple is defined by to the order of field indexes.
* @return A CrossProjection that needs to be converted into a {@link ProjectOperator} to complete the
* ProjectCross transformation by calling {@link CrossProjection#types(Class)}.
* Cross transformation by calling
* {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
*
* @see Tuple
* @see DataSet
......@@ -447,7 +450,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1, I2, OUT,
* For a non-Tuple DataSet, do not provide parameters.
* The order of fields in the output tuple is defined by to the order of field indexes.
* @return A CrossProjection that needs to be converted into a {@link ProjectOperator} to complete the
* ProjectCross transformation by calling {@link CrossProjection#types(Class)}.
* Cross transformation by calling
* {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
*
* @see Tuple
* @see DataSet
......
......@@ -36,6 +36,8 @@ import org.apache.flink.core.memory.DataOutputView;
*/
public class ExternalProcessInputSplit extends GenericInputSplit {
private static final long serialVersionUID = 1L;
// command to be executed for this input split
private String extProcessCommand;
......
......@@ -873,6 +873,7 @@ public class TypeExtractor {
return new GenericTypeInfo<X>(clazz);
}
@SuppressWarnings("unused")
private <X> TypeInformation<X> analyzePojo(Class<X> clazz) {
List<Field> fields = getAllDeclaredFields(clazz);
List<PojoField> pojoFields = new ArrayList<PojoField>();
......
......@@ -26,6 +26,7 @@ import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputView;
import org.apache.flink.core.memory.MemorySegment;
@SuppressWarnings("rawtypes")
public class IntListComparator extends TypeComparator<IntList> {
private static final long serialVersionUID = 1L;
......
......@@ -16,7 +16,6 @@
* limitations under the License.
*/
package org.apache.flink.runtime.operators.testutils.types;
import java.io.IOException;
......@@ -27,7 +26,7 @@ import org.apache.flink.core.memory.DataInputView;
import org.apache.flink.core.memory.DataOutputView;
import org.apache.flink.core.memory.MemorySegment;
@SuppressWarnings("rawtypes")
public class IntPairComparator extends TypeComparator<IntPair> {
private static final long serialVersionUID = 1L;
......
......@@ -27,6 +27,7 @@ import org.apache.flink.core.memory.DataOutputView;
import org.apache.flink.core.memory.MemorySegment;
import org.apache.flink.types.StringValue;
@SuppressWarnings("rawtypes")
public class StringPairComparator extends TypeComparator<StringPair> {
private static final long serialVersionUID = 1L;
......
......@@ -380,7 +380,7 @@ public class OutputEmitterTest extends TestCase {
Assert.fail("Expected a NullKeyFieldException.");
}
@SuppressWarnings("serial")
@SuppressWarnings({"serial", "rawtypes"})
private static class TestIntComparator extends TypeComparator<Integer> {
private final Comparable[] extractedKey = new Comparable[1];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册