Commit migrated from https://github.com/dotnet/coreclr/commit/46348ff653f38749e87f5939c134fcdc832cb646

Commit migrated from https://github.com/dotnet/coreclr/commit/85eb43f20ae9b1ce32ba4631e476ba0e120d5c0b

They are unused. Nothing ever checks for either of them.

Commit migrated from https://github.com/dotnet/coreclr/commit/ac9b8110ce037f367d739c57a5907edf9f7355c1

I'm not sure about the dotnetcore3.0 version but that lets me run
"dotnet blahblahblah/ReadyToRun.SuperIlc.dll and actually launch the
app. Please help me figure out what else needs fixing. I should
probably add a test at some point but I don't yet know how it should
work, I'll look into it as part of my work on the CPAOT pipeline.

Thanks

Tomas


Commit migrated from https://github.com/dotnet/coreclr/commit/0cf6e1ae0400cf62a00dd03178add648b53a0321

After Michal moved the Crossgen2 compiler source code to CoreCLR,
this testing tool is the last bit that only exists in CoreRT so
I'm moving it too. This initial commit amounts to a straightforward
copy of SuperIlc source code from the CoreRT repo.

Thanks

Tomas


Commit migrated from https://github.com/dotnet/coreclr/commit/5f04a3d720be9bd673c874c73517d4322934a10b

Commit migrated from https://github.com/dotnet/coreclr/commit/0f049c3e15a7003efa4daa075d4e9ec11cff2e78

* Use win32 api directly for workingset counter

* Fix build warnings

* Removing useless code

* more cleanup

* remove size annotation

* remove useless comment

* Move all the changes to Environment.WorkingSet and remove it from RuntimeEventSourceHelper

* removing useless usings

* Use kernel32.dll instead of psapi.dll

* Code review feedback

* Remove newline change

* More code review nits


Commit migrated from https://github.com/dotnet/coreclr/commit/6f8cdbc8fd91caf804bf58b798bd5bbf1fee2255

The purpose of this change is to increase the throughput and
reliability of CoreCLR CI pipelines by only performing one GIT
checkout for Windows and Unix, zip them up and reuse for all
subsequent phases / jobs in the pipeline.

Thanks

Tomas


Commit migrated from https://github.com/dotnet/coreclr/commit/17a53cb063b5e63fc1cc832ec36cf8a520111124

S.R.CS.Unsafe is used in number of places in Vector<T> already. This change modifies more places to use it to make the code more compact.

Updated Vector.tt template to match while I was on it



Commit migrated from https://github.com/dotnet/coreclr/commit/76c0217439b062f38fdb96c18224cff06f5a7ace

That field is used only in dumping logic inside `genCodeForBBlist`, for some reason `gtDispTree` doesn't print it.

Commit migrated from https://github.com/dotnet/coreclr/commit/92e501f96c1403b7af4a155741a08ccbd0cbc1b4

Commit migrated from https://github.com/dotnet/coreclr/commit/7adc7249f71679b6a1727e17cd15df4db5d621b3

- Refactor the win32 resource reading code to use more natural managed data structures
- Build a Win32 resource emitter on top of refactored data structures
- Replace resource section copy logic with new node to generate win32 resources

Commit migrated from https://github.com/dotnet/coreclr/commit/17e4bdb9dab45240c85815edd6bf656bf36b1e3d

* Manually marshal parameters for EventPipeInternal.Enable.

* Update src/System.Private.CoreLib/src/System/Diagnostics/Eventing/EventPipe.cs
Co-Authored-By: NJan Kotas <jkotas@microsoft.com>


Commit migrated from https://github.com/dotnet/coreclr/commit/db04a9afd990091e2b6b7bbeb938ed731fbcdba5

[test] Mark EventPipe tests JITStress Incompatible and Partially GC Stress Incompatible (dotnet/coreclr#26606)

* Mark all EventPipe tests as JitOptimizationSensitive
* Mark EventPipe GC tests as GCStressIncompatible
* Reduce number of GCs triggered for EventPipe GC tests to make them more diagnosable in the event of failure


Commit migrated from https://github.com/dotnet/coreclr/commit/d4e66769a2560ab7737c5c63b3702b245378ea2b

* improve logging for EventSource.WriteEvent

* Fix IndexOutOfRangeException in SerializeEventArgs when incorrect arguments got passed

* simplify arg-check; remove nullable-todo

* switch from Debugger.Log to ReportOutOfBandMessage

* Remove unused flush-Paramater from ReportOutOfBandMessage

* fix parameter type nullable-check for reference-types

* fix parameter type nullable-check for nullable-types


Commit migrated from https://github.com/dotnet/coreclr/commit/4eb1526fde7a93a1cf0a3c2eca73fc8182845127

Refactor osGroup / osIdentifier pairs to osGroup / osSubgroup

This simple cleanup removes the duplication between osGroup and
osIdentifier by switching over to use the pair osGroup and osSubgroup
such that the final OS identifier is a plain concatenation of osGroup
and osSubgroup. As the only currently supported OS flavors using
OS subgroups are Linux_musl and Linux_rhel6, this simplifies the
platform-matrix.yml and related scripts overall.

Thanks

Tomas


Commit migrated from https://github.com/dotnet/coreclr/commit/1a17ea321bb9489d85eb7731d765ae36529cab6d

* Fix Running .NET Core Under Winndows App Compat Shim

.NET Core uses Windows features called sort handles for perf reason to speed up the collation operations (e.g. string comparisons). When enabling Windows app compat shim (e.g. Windows 7 compatibility mode), the calls uses sort handles will fail which cause all collation operations to fail.
The fix here is to detect if the sort handles work before using it to ensure successful run.

* Address the feedback

* More feedback addressing


Commit migrated from https://github.com/dotnet/coreclr/commit/0f1314bdca91add2b4e9dbc95ec687dab638e1a0

Commit migrated from https://github.com/dotnet/coreclr/commit/961611fb7acb4f08a89011fec5d1d23f94743ce6

Only remaining use is the one place it shows up in public API, in GC.GetGeneration(WeakReference).

Commit migrated from https://github.com/dotnet/coreclr/commit/778cc84ed4321cb5b3990e6bb683be4ee56bb8a1

* Make StringComparer.Create throw ArgumentNullException

Throws proper exception.

* Update CoreFX.issues.rsp


Commit migrated from https://github.com/dotnet/coreclr/commit/69ff008fde9a23996029c4fa25b6f4fba4d815cf

Also happens to save a string allocation, but that's a drop in the bucket in this function.

Commit migrated from https://github.com/dotnet/coreclr/commit/4432a27c3b221cc0398a3b7be5d372bd4986a980

Also removes dependency on System.Range and RuntimeHelpers.GetSubArray in a simple console app such that they can be trimmed away.

Commit migrated from https://github.com/dotnet/coreclr/commit/86fadd1f51a8d3a4276cc64ae830161503846a9a

We do not need to special-case these types for reflection invocation, and doing so is currently keeping them from being trimmed when not otherwise used.

Commit migrated from https://github.com/dotnet/coreclr/commit/70202b04cab861c7f3fd504a08e33153c2739d73

Commit migrated from https://github.com/dotnet/coreclr/commit/3b177c44a3005cd5733ec4f94b6c1408abbc4290

The error was made in 2017 https://github.com/dotnet/coreclr/commit/dotnet/coreclr@654fed28001085adc162de1ea3207e9a22230235.

Commit migrated from https://github.com/dotnet/coreclr/commit/eed279f32ae3eeb5e959fc27d54372960382644e

Add a check to ensure that there are not any zombied Diagnostics IPC sockets on Linux and error in a readable manner if we are unable to clean them up before running the test (dotnet/coreclr#26573)



Commit migrated from https://github.com/dotnet/coreclr/commit/336662ca1bde4973ce4e2a33f0bee09f1adb5b6e

Commit migrated from https://github.com/dotnet/coreclr/commit/2af6907b5258ac3e13d7938f2c22db81eb0af5aa

* Stop using GT_LIST in GenTreeCall

* Clarify optAssertionGenJtrue code

* Cleanup optCreateAssertion

* Cleanup AddHiddenArgument

* Cleanup impInlineIsGuaranteedThisDerefBeforeAnySideEffects


Commit migrated from https://github.com/dotnet/coreclr/commit/667222e7cee75c0473e2e6b3a9c89dd5043ff176

Commit migrated from https://github.com/dotnet/coreclr/commit/7c9432c3ee874d8d5c4b1e5f38670ebef43bfb3f

Commit migrated from https://github.com/dotnet/coreclr/commit/5dc16c89311f4508ff05ffff15b4437bee3950a5

build-test.cmd limits precompilation to things that are directly in CORE_ROOT. We should do the same on Unix.


Commit migrated from https://github.com/dotnet/coreclr/commit/7b660fc665a76b490e882d4ec993139b903cda2d

Commit migrated from https://github.com/dotnet/coreclr/commit/a1c32fc2fbdfb054a1548b861d4cf52075c3bca9

Initial population of crossgen2 sources from CoreRT repo as of commit dotnet/coreclr@48b4932a57a8aa3a2be45560ac9cac51003dd8b3


Commit migrated from https://github.com/dotnet/coreclr/commit/ce1c7ed76cc113396cbbf25329b99089af6cc784

Commit migrated from https://github.com/dotnet/coreclr/commit/82f0870166f8c6a1c34497f5f088cdcebb4a33f7

* Replace HashHelpers.Combine with HashCode.Combine

* Address PR feedback


Commit migrated from https://github.com/dotnet/coreclr/commit/1894302e7031a4677191dc383b781a89cca9bd2c

Keeping these reflection enabled pulls in quite a bit of junk (generic dictionaries, standalone method bodies, bookkeeping) that adds up to 1.5% of the size of Hello World...
Signed-off-by: Ndotnet-bot <dotnet-bot@microsoft.com>


Commit migrated from https://github.com/dotnet/coreclr/commit/87d194f3ecc0b41e95b43e3132e947feb9e6514b

The implementation reads the current value of the static cache field and then later overwrites that field with the originally read value.  If ClearCachedData was called in the interim to clear the cached data, this will end up effectively undoing part of that clearing, as it'll end up restoring the previous cache. The fix is to write back the new reference only when we need to, which we could do when we detect it's null.

There's a secondary race condition this fixes as well.  When a name and an altname are used with CultureInfo.GetCurrentCulture(string, string), the implementation was publishig the newly created instance into the dictionary under the lock, but then after the lock was released, it was setting that TextInfo to be read-only.  That provides a window where another thread could see it as non-read-only and mutate it.  The fix is to ensure it's marked as read-only fully before it's published.

As I was doing this, it struck me that the implementation was overly complicated, trying to merge three different code paths for three different callers, presumably to share code, but most of the code ended up not being shared anyway, which just made the code harder to follow for little gain.  So, I split it back out into the three calling functions and removed the helper.

I also changed the locking mechanism.  It had been using a single shared lock to protect all state, but the purpose of the lock is really just to synchronize access to an individual dictionary, so we can just lock on the relevant dictionary.



Commit migrated from https://github.com/dotnet/coreclr/commit/456afea9fbe721e57986a21eb3b4bb1c9c7e4c56

* Add a repro for GitHub_26311.

Add an IL test that reproduces GitHub_26311 without using external functions and stress modes.
The test uses tail call opcode to force tail call to VSD over generic class via a slow helper.

* Exclude the test for windows x64.


Commit migrated from https://github.com/dotnet/coreclr/commit/1416a9c8703be562f3f01ed3da5825e3c3a1c286

Commit migrated from https://github.com/dotnet/coreclr/commit/bd8e35e41e6a6e626c4fc623845ec40b7704d109

There's currently no auto-fix for this, so the fixes were done manually.


Commit migrated from https://github.com/dotnet/coreclr/commit/208d864733c86e00499b15b310fe661a9aacc7ba