- 22 4月, 2022 13 次提交
-
-
由 John Salem 提交于
-
由 Carlos Sanchez 提交于
* Add assembly to NetCoreAppLibrary.props * Remove <PackageDescription> from src csproj since it is not OOB. * Add NetCoreAppCurrent to src csproj TargetFrameworks * Additional src csproj changes. Co-authored-by: Ncarlossanlop <carlossanlop@users.noreply.github.com>
-
由 Jan Vorlicek 提交于
The iteration that marks loader allocators in LoaderAllocator::Mark() was not being called under an appropriate lock, which lead to a rare and hard to reproduce race condition and a crash in the LoaderAllocator::Mark(). The issue happened when the m_LoaderAllocatorReferences.Begin() returned an iterator at the time the m_LoaderAllocatorReferences were empty and another thread has written something into those references before the m_LoaderAllocatorReferences.End() was called. The iter was then evaluated as not equal to the End and the iter was getting dereferenced. Since the iterator had m_table set to NULL, the dereferencing caused crash.
-
由 Stephen Toub 提交于
* Enable new CA1311 (ToLower/Upper culture) and CA1852 (seal internal/private types) CA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant. CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't. * Address PR feedback and fix more CI failures * Fix unit test build error
-
由 Ankit Jain 提交于
* perf: Don't build in the payload directory on helix A copy of the `performance` repo is sent as payload to helix. And then we build from the same directory. But this is shared by the whole job. And it gets uploaded only once. So, all the workitems on that machine would share that directory. This can cause issues like if a workitem has to be retried by helix, then it will end up building incrementally, because it is using the same artifacts from the first build. This case was hit when some wasm/aot workitems were retries. Solution: copy the diretory to `$HELIX_WORKITEM_ROOT/performance` before building, since `$HELIX_WORKITEM_ROOT` is private to a workitem. Thanks to @premun for the suggestion. * blazor_perf.proj: Pass --readonly-dotnet so the shared dotnet installation is not modified * blazor_scenarios: pass --readonly-dotnet to post.py scripts too
-
由 Jakob Botsch Nielsen 提交于
-
由 Aleksey Kliger (λgeek) 提交于
In debug configurations, use of `_ASSERTE` requires the `PAL_frpintf` function and linking with the `coreclrpal` static library. Instead just use `assert()` from `<assert.h>` Fixes https://github.com/dotnet/runtime/issues/68279 * Don't use _ASSERTE in runtime tests That macro requires linking the coreclrpal static library, which the runtime tests don't currently do. * use an absolute path for binary_dir
-
由 Tomas Weinfurt 提交于
-
由 Elinor Fung 提交于
-
由 Stephen Toub 提交于
* Remove usage of !! from dotnet/runtime - Use ArgumentNullException.ThrowIfNull instead where possible. It's only usable for projects that only target .NET 6+, and it can't be used in places like this(...) or base(...). - In other cases, if the project already has a ThrowHelper, augment it for null as needed and use that. - For most of the extensions projects, add a ThrowHelper.ThrowIfNull that replicates ArgumentNullException.ThrowIfNull. - For everything else, just use "throw new". * Address PR feedback * Address PR feedback * Remove false positives from searches * Address PR feedback
-
由 Alexander Köplinger 提交于
We were still calling into the PAL to get the platform name string, but we can just hardcode the result like we do on other platforms.
-
由 Qiao Pengcheng 提交于
* Part6-2: -add the coreclr-vm directory for LoongArch64. (#59561) Co-authored-by: Loongson's .NET-teams * [LoongArch64] revert the syncblk.cpp. * [LoongArch64] delete some unused codes. * [LoongArch64] add vm/CMakeLists.txt from #62889. * [LoongArch64] add related files from #62886 and #62893. * [LoongArch64] moved vm/jitinterface.cpp from #62893. moved inc/corinfo.h from #6288. * [LoongArch64] run the file `src/coreclr/tools/Common/JitInterface/ThunkGenerator/gen.sh` and merge the patch from #62893. * [LoongArch64] revert vm/ceeload.h. amend the `ToolBox/superpmi/superpmi-shared/agnostic.h` * [LoongArch64] add empty interfaces within `CorInfoImpl.cs`. * [LoongArch64] Fix the compiling error on Windows. * [LoongArch64] Fix the compiling error for memory unaligned m_currentByteStackIndex. * [LoongArch64] Delete the !TARGET_LOONGARCH64 for m_currentByteStackIndex. * [LoongArch64] move ToolBox from #62886. * [LoongArch64] amend the args when needs unsigned extending within CallTargetWorker. * [LoongArch64] add bool type for args' unsigned extention. * [LoongArch64] adding char type for args' unsigned extention. Also rename `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI` within ABI. * [LoongArch64] amend renaming `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI` within ABI. * [LoongArch64] remove the JIT/EE interface to #62893. * [LoongArch64] revert the rename `TARGET_LOONGARCH64` to `UNIX_LOONGARCH64_ABI`. Also add unsigned extend for CHAR type. * [LoongArch64] refactor the `ArgDestination and ArgLocDesc`. * [LoongArch64] rename the `m_flag` and `getFieldTypeByHnd`. * [LoongArch64] add `NATIVE_SYMBOL_READER_DLL` for compiling error. * [LoongArch64] update the version of the `LICENSE description`. * [LoongArch64] keep same with the comment in `jit/targetloongarch64.h` * [LoongArch64] amend the code for reviewing. * [LoongArch64] refactor LoongArch64-ABI within `vm`, and also amend some code for review. * [LoongArch64] delete unused codes. * [LoongArch64] merge main for #65869. * [LoongArch64] amend the format for reviewing. * [LoongArch64] delete some unused code for reviewing. * [LoongArch64] amend code for CR feedback @jkotas @janvorli * [LoongArch64] add class type for LoongArch64-ABI. * [LoongArch64] Amend the LoongArch64's ABI after merged `MethodTable::GetLoongArch64PassStructInRegisterFlags()` and `CEEInfo::getLoongArch64PassStructInRegisterFlags()` * [LoongArch64] Fix the assert error when running hello-world within debug-mode after refacting. Co-authored-by: Nqiaopengcheng <qiaopengcheng-hf@loongson.cn>
-
由 Carlos Sanchez 提交于
API proposal: https://github.com/dotnet/runtime/issues/65951
-
- 21 4月, 2022 27 次提交
-
-
由 Stephen Toub 提交于
* Pass more information about execution mode to RegexRunners Some engines, in particular NonBacktracking, are relatively pay-for-play, in that the more information you need, the more processing they do. However, we currently don't pass enough information down to the RegexRunner to allow the engine to take full advantage. Today NonBacktracking can short-circuit its evaluation if it's told IsMatch is being used, but with the new EnumerateMatches and Count (and some uses of Replace), it's still gathering up all of the capture information even though that capture information will be ignored. This commit introduces a new RegexRunnerMode enum that lets us pass down to the engine exactly what portion of the information is needed, allowing it to avoid unnecessary work. Related, we can reduce the amount of work performed by Match.Tidy: if the captures information won't be used, there's no point in fixing up the positions. As part of this, I noticed we have a race condition in the new EnumerateMatches. We want to extract the index, length, and new text position from the Match object in order to populate the enumerator and result structs, but today we're doing so after the runner is returned to the cache. That means another thread could come along and start using that same Match object while we're still using it in the EnumerateMatches call. The fix is to extract the data from the Match before returning the runner. * Address PR feedback * Address PR feedback
-
由 Joni Aromaa 提交于
-
由 Kunal Pathak 提交于
* Do not reset the assignedInterval again * Add test case
-
由 Marie Píchová 提交于
* TestEventListener * Feedback
-
由 Jan Kotas 提交于
Fixes #68257
-
由 Alexander Köplinger 提交于
Extracted from https://github.com/dotnet/runtime/pull/67771 to get the fix for https://github.com/dotnet/runtime/issues/67349 Updates the WASM tests to always use net6.0 until we can upgrade to a net7.0 SDK. Co-authored-by: NPremek Vysoky <premek.vysoky@microsoft.com>
-
由 Krzysztof Wicher 提交于
* add more diagnostics to LookupProperty flaky tests * Fix nullability issue on Release build
-
由 Aaron Robinson 提交于
* Update TestHandleCollector() test Initialize local member in HandleCollector since it was the only one not initialized. Update test to wait for pending finalizers since that is when the HandleCollector API will trigger the GC. Co-authored-by: NElinor Fung <elfung@microsoft.com>
-
由 Luiz Strobelt 提交于
* Add API entry for JsonDocument converter * Add reference to System.Text.Json * Add JsonElementConverter from MetadataServices * Correct converter naming * Add JsonDocument type to source generation * include testing Co-authored-by: NEirik Tsarpalis <eirik.tsarpalis@gmail.com>
-
由 Jose Perez Rodriguez 提交于
-
由 Stephen Toub 提交于
-
由 Dan Moseley 提交于
* Add retries to ModulesAreDisposedWhenProcessIsDisposed * Update src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs Co-authored-by: NAdam Sitnik <adam.sitnik@gmail.com> Co-authored-by: NAdam Sitnik <adam.sitnik@gmail.com>
-
由 Stephen Toub 提交于
The recent change around timeouts appears to have made the timeout used in this test more accurate, which makes it more likely to fire, which is tripping up CI on slower machines. There's no need for a timeout in this test, though; just delete it.
-
由 Elinor Fung 提交于
-
由 Stephen Toub 提交于
* Use generic math in Enumerable.Sum/Average * Address PR feedback
-
由 Stephen Toub 提交于
* Use generic math to dedup Enumerable.Min/Max * Address PR feedback
-
由 Kunal Pathak 提交于
* fix the srcBufferLength check * trigger superpmi replay job when changes to superpmi tool
-
由 Dan Moseley 提交于
* Add test that fails * fix * Fix test failing unelevated * annotate * overflow * Apply suggestions from code review Co-authored-by: NRobin Lindner <robin@deeprobin.de> * Apply suggestions from code review Co-authored-by: NAdam Sitnik <adam.sitnik@gmail.com> Co-authored-by: NRobin Lindner <robin@deeprobin.de> Co-authored-by: NAdam Sitnik <adam.sitnik@gmail.com>
-
由 Danyy427 提交于
* Added Fix For System.CodeDom.Tests * Added Fix for Microsoft.XmlSerializer.Generator tests * Removed unnecessary File IO * Substituted LineEndingsHelper.Normalize
-
由 Alexander Köplinger 提交于
The runtime is creating the exception so we need to preserve it. See https://github.com/xamarin/xamarin-android/issues/6626 While looking at this I noticed that `FirstChanceExceptionEventArgs` is in ExceptionNotification.cs for some reason, fixed the filename to match the type name. Use DynamicDependency for preserving `FirstChanceExceptionEventArgs` and `UnhandledExceptionEventArgs`
-
由 Kevin Jones 提交于
* Use OpenSSL 3 on macOS * Update documentation * Restart CI
-
由 Jan Kotas 提交于
The virtual vector instruction used internally by the JIT were leaking out and reported as unsupported Fixes #68222
-
由 Eirik Tsarpalis 提交于
-
由 Jakob Botsch Nielsen 提交于
CallArgABIInfo::ArgNum is essentially unnecessary now that arguments are stored in order so remove it. Also address some feedback from the refactoring and fill out some function headers.
-
由 Tanner Gooding 提交于
* Exposing ExpM1, Exp2, Exp2M1, Exp10, Exp10M1, LogP1, Log2P1, and Log10P1 * Adding tests covering ExpM1, Exp2, Exp2M1, Exp10, Exp10M1, LogP1, Log2P1, and Log10P1 * Ensure Log10P1Test64 is 64-bit only
-
由 Jakob Botsch Nielsen 提交于
Fix #58874 Fix #64802 Fix #68157
-
由 Jakob Botsch Nielsen 提交于
Currently the JIT's constant folding (gtFoldExprConst and VNs EvalOpSpecialized) assumes that BSWAP16 zero extends into the upper 16 bits. This was not the case, and in fact the behavior of BSWAP16 depended on platform. Normally this would not be a problem since we always insert normalizing casts when creating BSWAP16 nodes, however VN was smart enough to remove this cast in some cases (see the test). Change the semantics of BSWAP16 nodes to zero extend into the upper 16 bits to match constant folding, and add a small peephole to avoid inserting this normalization in the common case where it is not necessary. Fixes #67723 Subsumes #67726
-