1. 18 3月, 2022 19 次提交
    • A
      [mono] Hot Reload: support for reloadable types (#66749) · a19d9fa4
      Aleksey Kliger (λgeek) 提交于
      Fully implement support for the `NewTypeDefinition` EnC capability: a hot reload edit can add a new type definition (class, struct, interface, enum) that contains new fields, methods, properties, events, and nested classes, and can have generic params.  Also add reflection support for all of the above.
      
      This is sufficient to support hot reload of types tagged with [`CreateNewOnMetadataUpdateAttribute`](https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.createnewonmetadataupdateattribute?view=net-6.0).
      
      Contributes to https://github.com/dotnet/runtime/issues/63643 and https://github.com/dotnet/runtime/issues/57365
      
      ---
      
      The implementation introduces `MonoAddedDefSkeleton` which is a bookkeeping structure that records the metadata indexes of where to find methods, fields, properties and events for a newly-added class.  The issue is that normally `mono_class_create_from_typedef` expects to find all that stuff in a contiguous block starting at the row pointed by the `MONO_TYPEDEF_FIELD_LIST` or `MONO_TYPEDEF_METHOD_LIST` columns of the new typedef.  But in EnC deltas, those columns are zeroed out, and instead the EnCLog functions like `ENC_FUNC_ADD_METHOD` and `ENC_FUNC_ADD_FIELD` explicitly record when a new row is added that is relevant to a particular type definition.
      
      So during the pass over the EnCLog, we start creating skeletons when we see a new row added to the typedef table.  Then when we see the add functions, we record the row indices of the field, method, etc tables.  As far as I can tell, the rows for a particular type definition are contiguous, so we just record the first index and the count.
      
      At the end of the pass, we save the skeletons on the metadata delta, and when code finally creates the `MonoClass` for a particular freshly-added type definition, we check the skeleton and use the recorded rows to populate the fields and methods.  Event and property data is created on-demand (the demand being reflection) in basically the same way.
      
      One important note: we try very hard not to accidentally materialize a newly-added class as a `MonoClass` during the update itself - we need to at least get through the entire EnCLog - otherwise we might not see every field/method/etc and set up the class incorrectly.
      
      The upshot is that the newly-added `MonoClass` behaves like any other "normal" class - all its fields are laid out normally (they're stored in the object, not in a separate hash table).  It can be generic.  It can have base types, interfaces, etc.
      
      This is different from how added fields, props and events will be implemented on existing classes - we won't modify `MonoClass:fields` or the `MonoClassPropertyInfo:properties` arrays - once they have been allocated, we don't want to mess with them.  Instead additions to existing classes with create `MonoClassMetadataUpdateField` (`MonoClassMetadataUpdateProperty` and `MonoClassMetadataUpdateEvent`) structs that are going to be stored on the `MonoClassMetadataUpdateInfo` that's associated with each `MonoClass`.  The various iterators like `mono_class_get_fields` and `mono_class_get_props` will be modified to return the added fields/props/etc after the existing ones.
      
      This is already implemented for fields.  Props and Events will be part of a separate effort to implement reflection support for them.
      
      ---
      
      * Checkpoint. Infrastructure for added types
      
      * register member->parent lookups for newly-added classes and members
      
      * fix off by one error creating class from skeleton
      
      * AddNestedClass test works with mono now; also make it generic
      
      * checkpoint: adding properties
      
         it "works" but only because we don't look very hard for the new properties anywhere.  reflection is probably pretty broken.
      
      * Add a property to AddNestedClass test
      
      * remove allow class/field/method/property ifdefs
      
         keep the instance field ifdef for now
      
      * add event to AddNestedClass
      
      * add DISALLOW_BROKEN_PARENT ifdef
      
         allow CustomAttribute row modifications to change Parent, while https://github.com/dotnet/roslyn/issues/60125 is being sorted out
      
      * checkpoint: adding events
      
      * Add new test ReflectionAddNewType
      
      * Add new types to the image name cache
      
      * Assembly.GetTypes and additional tests
      
      * Make nested types work
      
      * GetInterfaces on new types; also Activator.CreateInstance
      
      * Mark mono_class_get_nested_classes_property as a component API
      
         also mono_class_set_nested_classes_property
      
      * Add GetMethods, GetFields, GetMethod, GetField test
      
      * [class] Implement added method iteration
      
         Change the iterator from storing MonoMethod** values to storing an iteration count. For added methods, when the iteration count is more than mono_class_get_method_count, run through the hot reload added_members list and
      iterate over any relevant methods
      
      * Implement added field iteration
      
      * Add a GetField(BindingFlags.Static) test case
      
      * Add Enum.GetNames and GetProperties tests - not working yet
      
      * Mark mono_class_get_method_count as a component API
      
         also mono_class_get_field_count
      
      * Enum values work
      
      * Use GSList for added_fields (and props, events); add from_update bit
      
         Use GSList to simplify the concurrency story for accessing added_fields (and added_props and added_events, eventually): unlike a GPtrArray it won't resize, so we don't need to lock readers.
      
         Add a from_update bit to MonoProperty and MonoEvent - when props or events are added to existing classes, they will have the bit set.  That means that pointer arithmetic to figure out the prop (or event) tokens won't be usable (since
      they're not allocated in one big block).
      
      * Reflection on props in new classes works
      
      * events on new classes work
      
      * Add CustomAttribute reflection test
      
      * remove test for props on existing type - it's not part of this PR
      
      * instance field additions to existing types aren't supported yet
      
      * rm TODO and FIXME
      
      * store prop and event from_update bit in attrs
      
         The upper 16 bits aren't used for ECMA flags, so grab a bit for metadata-update
      
      * remove instance fields from reflection test
      
         since Mono doesn't support them yet
      
      * make the Browser EAT lanes happy
      
         Add some fields to the baseline versions of some test assemblies to keep some types that are used in the deltas from getting trimmed away
      a19d9fa4
    • S
    • A
      Use guint64 in UCONTEXT_REG_SET_PC (arm64) (#66812) · 3175a8a0
      Adeel Mujahid 提交于
      In this scope, `__uint64_t` is not available on musl based systems. Switched to `guint64`, which nearby code is using.
      3175a8a0
    • J
      0b12d378
    • A
      Reenable 4611 and 4703 (#66792) · 5371203d
      Aaron Robinson 提交于
      5371203d
    • E
      110cb9fe
    • D
    • L
      Fix emscripten-version.txt link (#66778) · 8c97244d
      Layomi Akinrinade 提交于
      8c97244d
    • S
      Implement missing SymUnmanaged* interfaces (#66650) · 03190102
      Steve 提交于
      * Implement missing SymUnmanaged* interfaces
      
      * Add try-finally around GCHandle
      
      * Marshal interface argument to pinned pointer
      
      * Minor fixes
      
      * Address feedbacks from review
      03190102
    • J
      Reimplement stubs to improve performance (#65738) · eb8460fd
      Jan Vorlicek 提交于
      * Reimplement stubs to improve performance
      
      This change implements `FixupPrecodeStub`, `PrecodeStub`
      and `CallCountingStub` using a new mechanism with fixed code and separate RW
      data. The `LoaderHeap` was updated to support a new kind of allocation
      using interleaved code and data pages to support this new mechanism.
      The JIT now generates code that uses indirection slot to jump to the
      methods using `FixupPrecode`, improving performance of the ASPNet
      plaintext benchmark by 3-4% depending on the target platform (measured
      on x64 Windows / Linux and arm64 Linux).
      
      I have also removed the Holders, as the stubs are naturally properly
      aligned due to the way they are allocated.
      
      There is now only a single variant of each stub, there are no long /
      short ones anymore as they are not needed - the indirect jumps we use
      now are not range limited.
      
      Most of the stubs stuff is now target agnostic and the originally split
      implementation is now in single place for all targets. Only a few
      constants are defined as target specific in these.
      
      The code for the stubs is no longer generated as bytes by C++ code, but
      rather written in asm and compiled. These precompiled templates are then
      used as a source to copy the code from. The x86 is a bit more complex
      than that due to the fact that it doesn't support PC relative indirect
      addressing, so we need to relocate all access to the data slots when
      generating the code pages.
      
      As a further improvement, we could generate just a single page of the
      code and then just map it many times. This is left for future work.
      
      ARM64 Unix differs from the other targets / platforms - there are
      various page sizes being used. So the asm templates are generated for
      4k..64k page sizes and the variant is then picked at runtime based on
      the page size extracted from the OS.
      
      This also removes a lot of writeable mappings created for modifications
      of the stub code when W^X is enabled, in the plaintext benchmark they
      were reduced by 75%. That results in a significant reducing of the .NET
      application startup time with W^X enabled.
      
      I think the `LoaderHeap` would benefit from some refactoring, but I'd
      prefer leaving it for a follow up. It seems that for the sake of the
      review, it is better to keep it as is.
      
      The change also implements logging of number of mappings and their exact
      locations. This helped me to drive the work and I am planning to use it
      for further changes. It can be removed in the future once we reach a
      final state.
      
      There are still opportunities for improvement, but these stubs allowed
      me to scrape off the most significant portion of the mappings.
      eb8460fd
    • A
      Always append the "dll" extension for native libraries loads on Windows (#66666) · 60478d25
      Aaron Robinson 提交于
      * Always append the "dll" extension for native libraries loads on Windows
      
      Due to case-sensitive file systems on Windows the runtime will now
        always append the ".dll" extension unless the name contains a trailing
        "." or a known loadable extensions. This is an attempt to mitigate
        the default Windows behavior that appends a ".DLL" which is rarely the
        casing used for Windows shared libraries.
      Co-authored-by: NJan Kotas <jkotas@microsoft.com>
      60478d25
    • T
      Ensure the generic math interfaces are implemented implicitly where possible (#66748) · 7f2cdc53
      Tanner Gooding 提交于
      * Updating generic math interfaces to be implicitly implemented where possible
      
      * Resolve a build error in OdbcConnection caused by new Parse APIs
      
      * Revert "Resolve a build error in OdbcConnection caused by new Parse APIs"
      
      This reverts commit 6fd7ec7797cad7b28d381a695e84430c8d1081ae.
      
      * Suppress CA1846 for System.Data.Odbc
      
      * Updating the xml doc comments for exposed constants
      7f2cdc53
    • T
      [wasm][debugger] Fix incompatibility between runtime and nuget package (#66295) · a1bc0f34
      Thays Grazia 提交于
      * Fix incompatibility between runtime and nuget package
      
      * Update debug.ts
      a1bc0f34
    • T
      [wasm][debugger] Don't show the wasm functions on callstack when debugging managed code (#64223) · 15db6e07
      Thays Grazia 提交于
      * Show the callstack as it's shown on net5.
      
      * Addressing @lewing and @radical comments.
      
      * addressing @lewing comment.
      15db6e07
    • N
      Add additional trace to HttpConnectionPool (#66605) · bd02b322
      Natalia Kondratyeva 提交于
      The additional trace should help troubleshoot hanged "pending" connection issues (i.e. the reasons why new connections were not created) in HttpConnectionPool.
      
      The issue manifests as growing number of timeouted requests. It is not easy to link a timeouted request (esp. with a small timeout) to a connection that was created 3 minutes ago but still is not connected. There are no traces of the state of HttpConnectionPool, e.g. number of pending connections, so it is unclear from existing traces why the pool decided not to create a connection.
      
      Related to #66297
      bd02b322
    • J
      Surface native sourcelink on CoreCLR native PDBs for easier dump debugging (#66677) · 200a11cf
      Juan Hoyos 提交于
      * Use managed sourcelink infrastructure to allow for win native sourcelink
      200a11cf
    • R
      Temporarily disable... · 575100ed
      Radek Zikmund 提交于
      Temporarily disable HttpClientTest.GetContentAsync_WhenCanNotConnect_ExceptionContainsHostInfo on OSX (#66761)
      
      575100ed
    • D
      Update area owners to add 2 triagers (#66767) · de2db693
      Dan Moseley 提交于
      de2db693
    • S
      048da75f
  2. 17 3月, 2022 21 次提交