1. 28 4月, 2020 1 次提交
  2. 24 4月, 2020 2 次提交
    • T
      [release/5.0-preview4] Add new IntPtr/UIntPtr API surface (#35248) · 0ce44af8
      Tanner Gooding 提交于
      * Add new IntPtr/UIntPtr API surface (#307)
      
      * Add new IntPtr surface
      
      * Add new UIntPtr API surface
      
      * Add sequential layout to match [U]Int32
      
      * Add interfaces and sequential layout
      
      * Add interfaces
      
      * Add namespaces
      
      * Add namespaces
      
      * Update UIntPtr.cs
      
      * Update IntPtr.cs
      
      * Change style
      
      * make non versionable, elide copy
      
      * fix style, elide copy, make non versionable
      
      * Fix syntax error
      
      * Fix style issues
      
      * Fix style issues
      
      * Update IntPtr.cs
      
      * Update UIntPtr.cs
      
      * Update ref assembly
      
      * Allow comparison of intptr/uintptr in Array
      
      * Fixed ELEMENT_TYPE cases, added tests based on Int32/UInt32 tests
      
      * Fixes
      
      * Update Array.cs
      
      * Update Array.cs
      
      * Update Array.cs
      
      * Update ArrayTests.cs
      
      * Update ArrayTests.cs
      
      * Update UIntPtrTests.cs
      
      * Update ArrayTests.cs
      
      * fix instance methods??
      
      * fixes
      
      * Fixwa
      
      * fix tests
      
      * Add non versionables
      
      * fix compare methods
      
      * Fix comparison error
      
      * fix boundary
      
      * fix compares
      
      * fix maxvals
      
      * remove xunit buggy data
      
      * silly var name error
      
      * Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx
      Co-Authored-By: NTanner Gooding <tagoo@outlook.com>
      
      * Fix ToString
      Co-authored-by: NTanner Gooding <tagoo@outlook.com>
      
      * Remove the explicit IEquatable implementation from the IntPtr/UIntPtr reference API
      Co-authored-by: NJohn <johnkellyoxford@gmail.com>
      0ce44af8
    • T
      System.Diagnostics Tracing APIs (#35220) (#35326) · 88c069b8
      Tarek Mahmoud Sayed 提交于
      * System.Diagnostics Tracing APIs
      
      * address the feedback
      88c069b8
  3. 22 4月, 2020 1 次提交
  4. 21 4月, 2020 5 次提交
    • F
      Remove passing tests from exclude list (#35139) · 8675bc40
      Fan Yang 提交于
      8675bc40
    • M
    • M
      Override IsByRefLike on S.R.E.*Builder classes (#34846) · cfb1335d
      Marcus Turewicz 提交于
      * Override IsByRefLike on S.R.E.*Builder classes
      
      Fixes #8828
      
      * Adds tests
      
      * Update System.Reflection.Emit.Tests.csproj
      
      * Bumping CI
      
      * Update mono as well
      cfb1335d
    • M
      [wasm][debugger] Implement `Runtime.callFunctionOn`, and support array expansion (#35156) · a637d3e5
      monojenkins 提交于
      - This was prompted by vscode/vs requiring this for array expansion.
      - It runs a given js function string, on a given object id.
      - We handle the case for dotnet object ids.
      
      Implementation:
      
      - We build a proxy object that reflects the details of the real dotnet object/array
      - And run the js function on that proxy object
      
      - Then if `returnByValue` was requested, the result is returned as-is
      - Else we cache that object, with a new special object id (`dotnet:cfo_res:..`),
        and return that id in the response.
      
      - Subsequently, we would get `Runtime.getProperties` request on this new object id
      - And a `Runtime.releaseObject` request, to free that function result.
      
      - All this is handled currently
      
      Tests:
      
      - A few tests were added which invoke `callFunctionOn`, on JS objects, and checks the result
        - And the same checks are performed on equivalent dotnet objects, with the same js function
        - This should help stay in sync with what we think `callFunctionOn` should work as
      
        - These tests have an additional parameter - `roundtrip`, which calls a simple function
      	`function () { return this; }`
          .. on a dotnet object, and gets the result object id. If `roundtrip == true`, then it
          runs that same function on the result object, and gets a new result object id. And the
          tests run their checks on that.
      
          - this helps to check that outside of the proxy, the result object behaves same as any
            other dotnet object.
      
      - Also, most of the tests were modified to support an additional mode (`use_cfo`).
        - With this, whenever a test wants to run `Runtime.getProperties on an object, we pass that
          object through the earlier "identity" function, and then run `getProperties` on that
          resultant object.
      
        - This helps to take advantage most of the existing tests, and use them for `callFunctionOn`
          testing too, by ensuring that the results of CFO returns results same as any other object.
      
      Fixes mono/mono#19229, mono/mono#19531
      Co-authored-by: Nradical <radical@users.noreply.github.com>
      a637d3e5
    • J
      Add Reverse Diagnostics Server (#33307) · 629dba55
      John Salem 提交于
      * Add Advertise IPC Command
      * Update diagnostics server to use both reverse and traditional modes
      * Change DOTNET_DiagnosticsServerAddress to DOTNET_DiagnosticsMonitorAddress and only use for reverse connection
      * Add IpcStreamFactory abstraction
      * IpcStreamFactory::Poll is now more similar to the poll API from Linux
      * IpcPollHandle struct is used to abstract listening for client and server connections
      * use overlapped io for all io on windows
      * Add ConnectionState abstraction
      * Implement timeout read/write
      629dba55
  5. 20 4月, 2020 9 次提交
  6. 19 4月, 2020 6 次提交
  7. 18 4月, 2020 16 次提交
    • C
      Enclose paths with quotes in testPackages.proj (#34791) · cf66f084
      Carlos Sanchez Lopez 提交于
      * Enclose paths with quotes in testPackages.proj
      cf66f084
    • V
      Remove verbose test output logging (#35104) · c8ab193b
      Viktor Hofer 提交于
      Fixes https://github.com/dotnet/runtime/issues/33926.
      
      As we ContinueOnError and error by reading from the ExitCode property we can set IgnoreExitCode in the msbuild Exec invocation to avoid the following verbose output: `error MSB4132: The "Exec" task returned false but did not log an error.`
      c8ab193b
    • S
    • T
      Fixing several of the Sse/Sse2.Compare* intrinsics to account for NaN inputs (#34204) · 2bd14dee
      Tanner Gooding 提交于
      * Adding a regression test to validate the Sse.CompareGreaterThan and related behaviors
      
      * Fixing several of the Sse/Sse2.Compare* intrinsics to account for NaN inputs
      
      * Applying format patch
      
      * Switch to using compOpportunisticallyDependsOn
      
      * Use the named intrinsic comparison macros rather than magic numbers
      
      * Applying formatting patch
      
      * Define the _CMP hwintrinsic macros since they aren't available by default on Unix
      
      * Simplifying the special importation logic for Sse/Sse2 compare GreaterThan functions
      
      * Applying formatting patch
      
      * Add a comment explaining the naming of the _CMP_* macros used by the x86 HWIntrinsics
      
      * Switch to mirroring the FloatComparisonMode enum rather than using the _CMP_* macros
      
      * Apply formatting patch
      
      * Don't use XML style doc comments for the FloatComparisonMode mirror on the C++ side
      
      * Ensure the base type is set before it is checked
      
      * Applying formatting patch
      2bd14dee
    • M
      Remove erroneous curlies in Xml resource (#33890) · 9e9543bb
      mrj001 提交于
      * Added test for Issue 30218, use of resource Sch_MinLengthGtBaseMinLength
      
      * Reworded error message to remove the invalid formatters.
      
      Issue #30218
      
      * Updated check of message from the exception to be more amenable to potential internationalization.
      
      * Reworded resource Sch_MaxLengthGtBaseMaxLength and added unit test for same.
      
      * Simplified test code per feedback from Dan Moseley, PR#33890.
      
      * Tests to increase code coverage.   The ones that are failing trigger resource string Sch_MaxMinLengthBaseLength to be used as the Exception message.
      
      * Removed invalid formatters from the resource string Sch_MaxMinLengthBaseLength.  Failing tests from the previous commit now pass.
      
      * Added test for the Exception using string resource Sch_LengthGtBaseLength as its message.  This covers a source line and branch not previously covered.  This test fails due to the invalid formatters.
      
      * Reworded string resource Sch_LengthGtBaseLength to remove the invalid formatters.
      
      * Added unit tests for uses of string resource Sch_FacetBaseFixed.
      
      * Made test for the message containing "fixed" more specific.
      
      * Reworded string resource Sch_FacetBaseFixed to remove the invalid formatter.
      
      * Added unit test to cover usage of string resource Sch_InvalidAllMax.  A second usage of this string resource is not covered as it is in a class marked Obsolete.
      
      * Reworded string resource Sch_InvalidAllMax to remove the invalid formatter.
      
      * Added unit test for String Resource Sch_InvalidAllElementMax - invalid formatter.
      
      * Reworded string resource Sch_InvalidAllElementMax to remove the invalid formatter.
      
      * Added unit test which causes an XmlSchemaException using string resource Sch_InvalidExemplar as its message.
      
      * Reworded Sch_InvalidExemplar to remove the invalid formatter.  Also, added the name of the element which cannot be used as the substitution group affiliation.
      
      * Added unit test that causes an XmlSchemaException to be thrown using string resource Sch_GroupBaseRestNotEmptiable as its message.
      
      * Removed the curly braces so there are no longer any invalid formatters.
      
      * Added unit tests that cause an XmlSchemaException to be thrown using string resource Sch_AllRefMinMax as its message.
      
      * Changed string resource Sch_AllRefMinMax to remove the invalid formatters.
      
      * reworded Sch_MinLengthGtBaseMinLength and Sch_MaxLengthGtBaseMaxLength similarly to Sch_LengthGtBaseLength
      
      * Corrected error "greater than" to "less than".
      
      * Changed name of test to more accurately  reflect its purpose.
      
      * Changed casing of MinLength and MaxLength to match their XML facets.  Removed redundant ToLower call and comment.
      
      * Removed all Regex used to find invalid formatters.
      
      * renamed MaxMinLengthBaseLength_TestData to indicate that this is testing the successful case.
      
      * Removed suppression of exception so that we will see the exception if one is thrown.
      
      * Removed comments as there are issues tracking these.
      
      * Fixed comment larger -> lower.
      
      * Removed XML comments on test methods.
      
      * Removal of XML comment that was missed.
      9e9543bb
    • A
      Fix all runtime IL generation paths from passing GC types to unmanaged function calls. (#35026) · ddd458e8
      Aaron Robinson 提交于
      * Native COM clients have not been running since we switched over to SDK projects.
      
      * Stop IL generators from passing GC types to unmanaged function calls.
      Update crossgen2 IL stub generators.
      Update Dynamic runtime stub generator.
      Add assert for GC types in unmanaged function calls.
      ddd458e8
    • T
      Rename ReadyToRun.SuperIlc to just R2RTest to save typing (#35110) · 028501be
      Tomáš Rylek 提交于
      * Rename ReadyToRun.SuperIlc to just R2RTest to save typing
      
      * Apply the SuperIlc -> R2RTest rename to crossgen determinism test
      028501be
    • J
      Fix collectible AssemblyLoadContext shutdown race (#35131) · 701d8eeb
      Jan Vorlicek 提交于
      When the last reference to a collectible AssemblyLoadContext goes away,
      its finalizer is called on the finalizer thread. It ends up calling the
      native CLRPrivBinderAssemblyLoadContext::PrepareForLoadContextRelease
      method which replaces a long weak GC handle to the managed
      AssemblyLoadContext stored in the CLRPrivBinderAssemblyLoadContext by a
      strong GC handle to the same AssemblyLoadContext and closes the original
      weak handle.
      The problem is that another thread may have read the weak handle pointer
      and then try to use it to call into the resolving methods on the managed
      AssemblyLoadContext. If that thread tries to resolve the related handle
      after the finalizer thread has closed it, it fails as the handle doesn't
      exist anymore. It could even get a completely different object if the
      handle got reused in between. Or even worse, if the handle got reused by
      another AssemblyLoadContext, the handle would resolve, but to the
      different AssemblyLoadContext.
      
      This change fixes the problem by keeping the weak handle open and
      closing it after the AssemblyLoadContext shutdown completes (there are
      no more assemblies that were loaded into that context and no instances
      of types from those assemblies). The strong handle now serves only to
      keep the managed AssemblyLoadContext alive.
      701d8eeb
    • J
      Spanize interop in System.Net.NetworkInformation (#35098) · 8b41d4cb
      Jan Kotas 提交于
      Faster and safer
      8b41d4cb
    • K
    • M
      ce416f4c
    • D
      profiler tests depend on jit events (#34919) · 2d1f7b02
      David Mason 提交于
      * profiler tests depend on jit events so disable R2R images via profiler eventmask
      
      * fix RequestReJITWithInliners for R2R modules
      
      * Update tests to work correctly when crossgenned
      
      * fix issue where test was treating an HRESULT as a FunctionID
      
      * fix alpine failures. you can dlopen a relative path in glib, but apparently with musl you have to have the full path. So look at /proc/self/maps to find the full path to the loaded coreclr
      
      * re-enable profiler tests now that they are passing
      
      * Code review feedback
      
      * Update rejit.cpp
      2d1f7b02
    • S
      Enable cross OS DBI build (#35021) · 9890a9a6
      Steve MacLean 提交于
      * Enable cross OS DBI build
      
      * Fix .gitignore
      
      * Fix Cross OS DBI compilation issues
      
      * Review feedback
      
      * Cleanup dummy/twowaypipe.cpp
      9890a9a6
    • M
      Add wasm for browser RID (#34940) · d7a0cb3d
      Marek Safar 提交于
      d7a0cb3d
    • J
      64f18773
    • V
      Update VS minimum dependency (#35114) · 3b42a9a1
      Viktor Hofer 提交于
      With the net5.0 TFM change and the nuget static graph restore, we require VS >= 16.6 Preview2.
      3b42a9a1