Formatting changes to System.Collections.Immutable

Commit migrated from https://github.com/dotnet/corefx/commit/ba8180fdcd863cb6accfb01a98891efe6d989fcd

Commit migrated from https://github.com/dotnet/corefx/commit/ae985912211b000a4ce1748724691a7e48384efd

This reverts commit dotnet/corefx@9073ca9794cc5c59d5535267aa00cd247dce8f97.

Conflicts:
	src/System.Numerics.Vectors/tests/Matrix3x2Tests.cs
	src/System.Numerics.Vectors/tests/Matrix4x4Tests.cs
	src/System.Numerics.Vectors/tests/PlaneTests.cs
	src/System.Numerics.Vectors/tests/QuaternionTests.cs


Commit migrated from https://github.com/dotnet/corefx/commit/1ca773af3b75bd747b3ed11bf74dac5cc690bcc6

Add System.IO.Pipes source code

Commit migrated from https://github.com/dotnet/corefx/commit/e668913988c2c1291ce57dfb767bc67ee420e7d8

Commit migrated from https://github.com/dotnet/corefx/commit/af404c8b112a2cd427e6a7d47a300be7e24b7330

Clean up a line to avoid a ternary operator

Commit migrated from https://github.com/dotnet/corefx/commit/420f69847cb8a228e7f53a9bd9dad2963d433774

Commit migrated from https://github.com/dotnet/corefx/commit/3236ea8581190d675fcbc141e356a0321851b0b0

Re-enable some Vector tests which were flaky on CI machines

Commit migrated from https://github.com/dotnet/corefx/commit/ad36182d7f6003d22569563441d27106911b065c

Remove app.config from Registry.

Commit migrated from https://github.com/dotnet/corefx/commit/d19a02f307b4d8637a76ea6d36ca6fda8c4230fb

Commit migrated from https://github.com/dotnet/corefx/commit/c0201c52f22f68b6ce06b02676b18e0885da44ad

Improve Dictionary access

Commit migrated from https://github.com/dotnet/corefx/commit/e5485ca0a9d8ade4a67d511e587278cd141cc5f0

Commit migrated from https://github.com/dotnet/corefx/commit/160cd3e7a74ef689720d5feb7194253912f7861e

Formatting changes to private fields.

Commit migrated from https://github.com/dotnet/corefx/commit/c652ebdbdc5379608c7de97fb7925aff5d671920

Commit migrated from https://github.com/dotnet/corefx/commit/9073ca9794cc5c59d5535267aa00cd247dce8f97

Fix bug in Matrix4x4.Decompose.

Commit migrated from https://github.com/dotnet/corefx/commit/825b6e2dd7d662cc71aafab1b7e128bd0ff43ca2

Commit migrated from https://github.com/dotnet/corefx/commit/0cefc987d968ef5ef665f908977cc8f7111d9f59

While working on the Win2D numerics implementation, I discovered this longstanding issue
which was inherited from XNA. In some corner cases where one axis of a matrix transform
has degenerate (zero) scale factor, the Decompose method tries to compensate by filling
in an artificially generated orthogonal coordinate system, but was doing this wrong and
generating nonsense results.

Also updated unit tests to properly validate decompose of matrices with zero and negative
scale factors.


Commit migrated from https://github.com/dotnet/corefx/commit/2b088ec790804f5b755b7b6ab125ba75d9a7b977

Implement Microsoft.Win32.Primitives support on Linux

Commit migrated from https://github.com/dotnet/corefx/commit/7e6b3364b11bcc363e08407a64a357be59696219

Fix multiple projects for optimizations, debug/trace, etc.

Commit migrated from https://github.com/dotnet/corefx/commit/e70afbb0f5f5ad0dfa341ee380e335bc9d6bd478

Separates out the Windows interop code from the main Win32Exception type, and then adds a basic Linux implementation, based on strerror_r. (There are a few other minor, unrelated changes, e.g. some additional enum values in an interop file, in order to keep these files in sync with additional .NET Core projects not yet shared.)


Commit migrated from https://github.com/dotnet/corefx/commit/af18f40702983f756402b7f944a6f87c4f79c3f1

System.Linq.Parallel.csproj wasn't outputting symbols, and it didn't have optimizations enabled in Release.

System.Numerics.Vectors.csproj was setting TRACE in Release builds but not in Debug builds.

System.Text.RegularExpressions.csproj wasn't setting either DEBUG nor RELEASE constants in either Debug/Release builds, it didn't have optimizations enabled in Release, and it wasn't generating symbols in either.

The XML libraries were't setting DEBUG/TRACE in either Debug/Release builds, weren't enabling optimizations in Release builds, and weren't generating symbols in either.

DEBUG is important in almost all of these libraries, as they use Debug.* for asserts and the like.  Symbol generation is important for debugging.  Optimizations are obviously important (but just to verify I saw significant performance wins in multiple libraries just from turning this on in release).  TRACE isn't really important, as none of the libraries do release tracing, but I thought it good hygiene to enable it.


Commit migrated from https://github.com/dotnet/corefx/commit/f0f17dfdb834cb5eca94febc98ee6f8c8638e64f

Commit migrated from https://github.com/dotnet/corefx/commit/2dd40f62e46709bb3b4d8e6596a0070f20a59a72

Initial commit Microsoft.Win32.Registry


Commit migrated from https://github.com/dotnet/corefx/commit/979e07c5adf40bd6d90d607831ab2c55da665579

Add Jenkins CI badges

Commit migrated from https://github.com/dotnet/corefx/commit/95b9f20b8ccec48b94a3b680ddacbec327dfcc41

Improve performance of Regex ctor and IsMatch

Commit migrated from https://github.com/dotnet/corefx/commit/a3a485ee0b73cadb2e939dcf38946ae73877bd5f

Remove superfluous ToLowerInvariant helper

Commit migrated from https://github.com/dotnet/corefx/commit/0aff2c060fc357cd6c71c4edf5899e283f1b19b9

Commit migrated from https://github.com/dotnet/corefx/commit/33be4008b9280e3945737f94e98fd1eea63a1cb0

Move NuGet.config up one level where VS can see it

Commit migrated from https://github.com/dotnet/corefx/commit/cb154969233e3915cbd66541291b66bbd0cf7343

NuGet.config files can be found by VS package restore so long as they're
in a parent directory of the sln.

Copy the file one level higher to align with that. Once the buildtools
are updated, the old copy can be deleted.


Commit migrated from https://github.com/dotnet/corefx/commit/0646815997795c67e18251b488df3084663b57bd

The Regex class maintains a cache of byte codes, which the Regex ctor indexes into using a key.  It uses this seemingly innocuous line to create that key:

String key = ((int)options).ToString(NumberFormatInfo.InvariantInfo) + ":" + cultureKey + ":" + pattern;

This, however, has the unfortunate effect of allocating a string for the options, a string array for the five strings to be passed to the String.Concat call generated by the compiler, another string array allocation inside of Concat, and then the resulting string for the whole operation.  The cost of those allocations is causing a non-trivial slowdown for repeated Regex.IsMatch calls for simple regular expressions, such as for a phone number (e.g. "^\\d{3}-\\d{3}-\\d{4}$").

This commit adds a new struct key type that just stores the constitutent options, cultureKey, and pattern, rather than creating a string to store them.  That key is then what's stored in each entry in the cache.

For repeated Regex.IsMatch calls for basic regular expressions like the phone number one previously mentioned, on my machine this improves throughput by ~35%, in large part due to ~80% reduction in number of allocations, and (for this particular test case) an ~70% reduction in number of bytes allocated (it depends primarily on the length of the pattern and the length of the culture name).


Commit migrated from https://github.com/dotnet/corefx/commit/9820567e1bb1972502bfe6345963eb0ab99ef3f9

Fix some XML comments

Commit migrated from https://github.com/dotnet/corefx/commit/691bfca2eed5feb9a2bbe4af1f10bd3ab35d2110

Remove Xunit nuget package references from Tests.props

Commit migrated from https://github.com/dotnet/corefx/commit/a43f3ab6fa6afa296dec31aebc972271853810e4

Added System.Text.RegularExpressions source

Commit migrated from https://github.com/dotnet/corefx/commit/2a0164a6370e4dac26de33c65428eb9937ab043f

Commit migrated from https://github.com/dotnet/corefx/commit/a738f63d91331db71120dd7d79cc8dbb3361b548

Commit migrated from https://github.com/dotnet/corefx/commit/cc07fbf1a2fdac12523573ffb2dd273d82542f8d

Avoid boxing ImmutableHashSet<T>.Enumerator and others

Commit migrated from https://github.com/dotnet/corefx/commit/4d7a6c0d9515ea6646817bf7448d7c49fc638a9b

Commit migrated from https://github.com/dotnet/corefx/commit/a8a66c2dc806fe2df2dcd534bbc8dbf3bc278edd

It turns out it only applies in one place. But as it is RemoveRange and if it has an empty list as an argument we'd like it to be fast, it seems worthwhile.


Commit migrated from https://github.com/dotnet/corefx/commit/450b494d2bfbc658bedc4c962ae21bd8743774ea

Commit migrated from https://github.com/dotnet/corefx/commit/d68d16591180db6697116bf02e809313bec8c9d6

In adding code to opt-in ImmutableArray to the GetEnumerable extension method, I noticed it didn't work because ImmutableArray`1+Enumerator didn't implement IEnumerator<T> (because it doesn't want to be disposable to reduce code gen size). This called to my attention that the EnumeratorAdapter`2 type didn't implement IDisposable itself, so it would not recycle the stacks used by our several AVL-tree based collection's stack objects used by their enumerator structs.

To fix this, I introduced DisposableEnumeratorAdapter. So we have adapter structs for both cases: disposable and not disposable. Since C# doesn't allow overloads of methods that vary only on generic type argument constraints, this requires that the caller of the extension methods call the right method for their struct type. I've put a constraint on one method and a debug.assert on the other method to help flow callers into the right buckets and verified that a mistake produces either a compile error or a test failure.

I stop short of actually opting ImmutableArray<T> into the pattern (in this commit anyway) because it caused test failures since the types of exceptions thrown from uninitialized ImmutableArray<T> structs changed (due to calling a different GetEnumerator method).


Commit migrated from https://github.com/dotnet/corefx/commit/fbec451018fd6eb81fc30eeb8d2ecc2c2ae9cade