- 11 6月, 2022 8 次提交
-
-
由 Steve Pfister 提交于
Add a trait to control when the test executes as we don't have a good way to differentiate between Android emulators and devices. Fixes #70482
-
由 Jakob Botsch Nielsen 提交于
-
由 Jakob Botsch Nielsen 提交于
When changing the shape of child nodes in pre-order we must ensure we properly morph potential promoted/demoted child nodes. Normally this happens inside fgMorphTree which does it for child nodes, but this specific transform was not calling fgMorphTree on the parent tree after changing the shape of child nodes. The simplest fix is just to move the optimization to post-order which catches more cases and does not need to bother dealing with this. Fix #61074
-
由 Alexander Köplinger 提交于
* Remove Android crypto internals from System.Security.Cryptography.X509Certificates tests The `Interop.AndroidCrypto.X509ChainSupportsRevocationOptions` internally just checks that a certain Java class exists, we can assume it is always there on Android API 24+. This allows us to remove a bunch of internal crypto code from the tests. * Remove unused managed API
-
https://github.com/dotnet/xharness由 Alexander Köplinger 提交于
Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.22305.1 -> To Version 1.0.0-prerelease.22310.1 Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
-
由 Stephen Toub 提交于
-
由 Stephen Toub 提交于
-
由 Sapana-Khemkar 提交于
* mono add support to build for ppc64le * fix build failures in mini-ppc.c * handle unhandled exception ids * donot use std/ld inst when address is not div by 4. This adds fix for test failure in System.Buffers.Binary.Tests.BinaryReaderUnitTestsw.ReadingStructFieldByFieldOrReadAndReverseEndianness * Fixed failing test cases from System.Numerics.Vectors.Tests * change objcopy name for ppc64le from ppc64le-linux-gnu-objcopy to powerpcle-linux-gnu-objcopy
-
- 10 6月, 2022 32 次提交
-
-
由 Eirik Tsarpalis 提交于
* Change DeserializeAsyncEnumerable so that reading from the underlying stream does not wait until the underlying buffer is full. * Encapsulate the buffer management logic behind ReadBufferState. * Avoid allocating a new JsonTypeInfo instance on every IAsyncEnumerator initialization.
-
由 Tanner Gooding 提交于
* Updating the various generic math functions to have default implementations * Ensure GenericMathHelpers keep the right constraints
-
由 Stephen Toub 提交于
* Fix async handle leak when sync RandomAccess read/write on async handle fails * Use UnsafeAllocateNativeOverlapped in GetNativeOverlappedForAsyncHandle This isn't invoking user code and it's entirely for synchronous operations; there's no reason it needs to capture ExecutionContext.
-
由 Jan Krivanek 提交于
-
由 Qiao Pengcheng 提交于
-
由 Michal Strehovský 提交于
We're seeing Windows ARM64 workitems being stuck in the Helix queue for more than 90 minutes.
-
由 Stephen Toub 提交于
* Enable IDE0029 (Use coalesce expression) * Address PR feedback and a few missed cases
-
由 Jose Perez Rodriguez 提交于
* Move analyzer and fixer tests into FunctionalTests project * Don't use the live ref pack references infrastructure
-
由 Egor Bogatov 提交于
Co-authored-by: NTanner Gooding <tagoo@outlook.com>
-
由 Jakob Botsch Nielsen 提交于
* Fix impTokenToHandle when importing parent This was mistakenly creating a handle for the parent (always a class) but specifying the handle type of the child (e.g. constructor method handle). * Do not lie about critical sections being method handles
-
由 MSDN.WhiteKnight 提交于
* Update project * Create readme.md * Fix typo * Update src/libraries/System.Text.Json/src/readme.md Co-authored-by: NEirik Tsarpalis <eirik.tsarpalis@gmail.com> * Delete readme.md * Rename readme file * Add more docs links * Fix link * Update PackageDescription * Apply suggestions from code review Co-authored-by: NEirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: NViktor Hofer <viktor.hofer@microsoft.com> * Remove mentions of exact target framework versions Co-authored-by: NEirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: NViktor Hofer <viktor.hofer@microsoft.com>
-
由 Stephen Toub 提交于
-
由 Stephen Toub 提交于
-
由 Stephen Toub 提交于
The analyzer bug was fixed.
-
由 Michal Strehovský 提交于
Sample stack: ``` System.Runtime.Tests.exe!S_P_CoreLib_System_SR__GetResourceString() Line 29 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Exception__get_Message() Line 57 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Exception__AppendExceptionStackFrame() Line 134 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Runtime_EH__AppendExceptionStackFrameViaClasslib() Line 234 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Runtime_EH__UpdateStackTrace() Line 735 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Runtime_EH__DispatchEx() Line 630 Unknown System.Runtime.Tests.exe!S_P_CoreLib_System_Runtime_EH__RhThrowEx() Line 571 Unknown System.Runtime.Tests.exe!RhpThrowEx�() Unknown System.Runtime.Tests.exe!S_P_TypeLoader_Internal_TypeSystem_TypeDesc__ComputeTemplate_0() Line 241 Unknown System.Runtime.Tests.exe!S_P_TypeLoader_Internal_TypeSystem_TypeDesc__ComputeTemplate() Line 233 Unknown ```
-
由 Vladimir Sadov 提交于
* prevent reentering CreateThreadLocalContentionCountObject * do not call into type system on lock contentions
-
由 Aleksey Kliger (λgeek) 提交于
* [wasm] Add infrastructure for building WebWorkers - Modify the rollup.config.js script to look for webworkers and to roll them up into IIFE js files in the ${nativeBinDir}/src artifacts directory - A "webworker" is any file in `src/mono/wasm/runtime/workers/` that looks like `dotnet-{workerName}-worker.ts` or `.js`. It can also include other files (ideally by defining them in files in subdirectories for that worker `src/mono/wasm/runtime/workers/dotnet-{workerName}-worker/utility.ts`) - Other changes still have to be done manually in wasm.proj, and elsewhere in order to place the bundled JS file in the right place. - Adds a tsconfig.json for the workers to typecheck using the DedicatedWorkerGlobalScope and without the DOM globals (`window`, etc) - This doesn't convert dotnet-crypto-worker.js into TypeScript, but it does turn on TypeScript checking using a JSDoc comment. To convert that file to typescript: 1. rename `workers/dotnet-crypto-worker.js` to `workers/dotnet-crypto-worker.ts` 2. replace uses of `var` by `let` or `const` 3. add `:any` in various places. * use fast-glob instead of fs.readdir * add fast-glob to devDependencies
-
由 Zoltan Varga 提交于
[mono][wasm] Add a 'wasm-gc-safepoints' option to enable the generation of GC safe points in AOTed code on WASM. (#70520)
-
由 Ankit Jain 提交于
When the results xml is large, and we are writing the base64 representation in one line, `node` can exit before all the output gets flushed out. This results in xharness getting an incomplete `STARTRESULTXML <len> <base64> ... ` with missing `ENDRESULTXML`, thus no `testResults.xml` is generated. This can be seen in the case of `Microsoft.Extensions.Primitives.Tests` which has xml ~140KB, and `System.Memory.Tests` which has a xml ~13MB. So, wait for the two streams to be flushed out, with a timeout of 3secs. - use the `drain` event only if `stream.write('')` returns `false` * Address review feedback @kg, @maraf
-
由 Tlakaelel Axayakatl Ceja 提交于
Add basic testing infrastructure in NativeAOT (port from dotnet/linker) - Port the Mono.Linker.Tests* projects from dotnet/linker - Add the new projects to .editorconfig so they remain under the dotnet/linker format instead of dotnet/runtime - clr.toolstests subset now runs the Mono.Linker.Tests infrastructure - Make DisplayNameHelpers a public class so it can be used by the test infrastructure - Add a couple of simple test cases (Dataflow and Requires) along with a Repro test, just like the repro project the repro test serves prototyping purposes - Adds ProducedBy.NativeAOT to be able to represent differences between dotnet/linker and NativeAOT (either because of a bug or because NativeAOT correctly produces additional warnings) - Use MSBuild properties instead of trying to figure out with linker paths
-
由 Buyaa Namnan 提交于
-
由 Ivan Povazan 提交于
-
由 Andy Gocke 提交于
[main] Update dependencies from dotnet/linker
-
由 SingleAccretion 提交于
* Add a test * Fix the issue
-
由 Koundinya Veluri 提交于
* Modify thread pool thread counting to be a bit more defensive - An unexpected underflow in one or more thread counts can lead to a large number of threads to be created continually - Prevented underflows in changes to thread counts, such that following an unexpected underflow, subsequent paired increments and decrements would avoid repeating the underflow - Verified by creating an unexpected underflow in the debugger
-
由 Steve Harter 提交于
-
由 Stephen Toub 提交于
-
由 Ankit Jain 提交于
The new `Threading*` CI jobs on `runtime-wasm` use `shouldContinueOnError: false` because the tests are known to be unstable right now. But they were not getting correctly forwarded to the base templates.
-
由 Steve Dunn 提交于
Merging. Thanks @SteveDunn for your contribution.
-
由 dotnet-maestro[bot] 提交于
* Update dependencies from https://github.com/dotnet/arcade build 20220519.3 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22269.3 * Update dependencies from https://github.com/dotnet/arcade build 20220523.1 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22273.1 * Update dependencies from https://github.com/dotnet/arcade build 20220524.3 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22274.3 * Update dependencies from https://github.com/dotnet/arcade build 20220524.7 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22274.7 * Update dependencies from https://github.com/dotnet/arcade build 20220525.1 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22275.1 * Update dependencies from https://github.com/dotnet/arcade build 20220525.2 Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk From Version 2.5.1-beta.22255.2 -> To Version 2.5.1-beta.22275.2 * Update dependencies from https://github.com/dotnet/arcade build 20220526.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22276.1 * Update dependencies from https://github.com/dotnet/arcade build 20220530.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22280.2 * Update dependencies from https://github.com/dotnet/arcade build 20220531.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22281.1 * Update dependencies from https://github.com/dotnet/arcade build 20220601.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22301.2 * Update dependencies from https://github.com/dotnet/arcade build 20220606.1 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22306.1 * Update dependencies from https://github.com/dotnet/arcade build 20220606.2 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22306.2 * Update dependencies from https://github.com/dotnet/arcade build 20220608.5 Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22255.2 -> To Version 7.0.0-beta.22308.5 Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: NPremek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: NLarry Ewing <lewing@microsoft.com>
-
由 Andy Gocke 提交于
-
由 Tomáš Rylek 提交于
* Fix Crossgen2 PDB generator During my perf investigation work I have found out that PDB emitter in Crossgen2 is broken. I tracked this down to the change https://github.com/dotnet/runtime/commit/fdf6485c800ec580656d7491795e10881d493afb#diff-24e48862e3b82f52e7fa04f22700b1c976a012bfeb08a246406f4e5ec579699b that caused two behavioral changes in the PDB emitter: 1) The logic around QueryPDBNameEx got refactored to use a char[] instead of a StringBuilder and that silently caused _pdbFilePath to be set to the string "System.Char[]" instead of the actual path (cf PdbWriter.cs#221 in the quoted commit). 2) The COM wrapper refactoring ended up bumping the refcount on the _ngenWriter by one so that it never got actually closed and properly flushed; due to this the resulting PDB was invalid. Thanks Tomas
-