- 28 9月, 2022 23 次提交
-
-
由 Will Smith 提交于
* Update disasm-checks documentation with limitations and future improvements * Include not about anchors * Update disasm-checks.md
-
由 Jamie Magee 提交于
Co-authored-by: NJamie Magee <jamie.magee@microsoft.com>
-
由 Peter Sollich 提交于
* Initial version of gradual decommit for WKS. This is the regions version modeled after the behavior of the segments version. Idea is simply to limit the amount of decommitted memory based on the time since the last GC. * Change decommit_step to take a step_milliseconds parameter - this makes the logic for the WKS decommit more straightforward. * Only do decommits at most every 100 milliseconds to limit the number of decommitted regions. * Address code review feedback: disable the logic in decommit_ephemeral_segment_pages for WKS, some changes in distribute_free_regions as a consequence. * Remove unused static field ephemeral_elapsed. * Fix typo in comment.
-
由 Alexander Köplinger 提交于
While looking at https://github.com/dotnet/runtime/pull/76250 I noticed that we were querying the HOME env variable for SpecialFolder.UserProfile but we're already doing that in PersistedFiles.GetHomeDirectory()
-
由 Michał Bryłka 提交于
-
由 Miepee 提交于
#68610 moved `Personal`/`MyDocuments` on Unix systems from HOME to the documents folder. However, it didn't do so for Android systems, which was only noticed after tests later failed. This fixes it.
-
由 Jo Shields 提交于
Closes: #75080
-
由 Zoltan Varga 提交于
[mono][llvm] Avoid making the 'this' variable in gshared methods volatile, the generated llvm code already saves it to separate variable for using during EH. (#76284)
-
由 Tom Deseyn 提交于
* Pass SourceBuild TargetRid and SourceBuildPortable args through the native script. * Rename -packagerid to -distrorid. * Fix init-distro-rid.sh. * Use OutputRid instead of PackageRid. * Drop unnecessary Condition. * Try passing --distrorid as OutputRid. * NativeExport: use PackageRID for AppHostRuntimeIdentifier. * Rename --distrorid to --outputrid. * Fix SourceBuild.props. * Undo changes to init-distro-rid.sh. * Let source-build leg build 'banana-x64' rid. * SourceBuild.props: don't force a RuntimeOS. * SourceBuild.props: set AdditionalRuntimeIdentifierParent. * Build banana.24-x64 instead. * Fix SourceBuild.props. * SourceBuild.props: try fix AdditionalRuntimeIdentifier* usage. * source-build.yml: add runtimeOS parameter. * SourceBuild.props: derive RuntimeOS from NETCoreSdkRuntimeIdentifier. * Undo using NETCoreSdkRuntimeIdentifier. * Update eng/pipelines/common/global-build-job.yml Co-authored-by: NJeremy Koritzinsky <jkoritzinsky@gmail.com> Co-authored-by: NJeremy Koritzinsky <jkoritzinsky@gmail.com>
-
由 Zoltan Varga 提交于
[wasm] Run System.Runtime tests in a deterministic order to work around https://github.com/dotnet/runtime/issues/74302. (#76287)
-
由 Michal Strehovský 提交于
Small quality-of-life improvement since the SDK default means less code to compile and faster compile times.
-
由 Matous Kozak 提交于
-
由 Michal Strehovský 提交于
Contributes to https://github.com/dotnet/runtime/issues/71506.
-
由 Michal Strehovský 提交于
There was a bug in the code that maps accessor names to property names when the method is on an instantiated type. We would incorrectly demangle getters into setters. Also made this do the same thing for events. Also changed the throw to an assert. We don't really want to crash the compiler if there's a bug here.
-
由 Zoltan Varga 提交于
-
由 James S. Wang 提交于
-
由 Tanner Gooding 提交于
* Support containing HWIntrinsics that can operate like a store * Applying formatting patch * Ensure code is properly under #if defined(FEATURE_HW_INTRINSICS) * Resolve an assert in lsrabuild * Update src/coreclr/jit/emitxarch.cpp Co-authored-by: NSingleAccretion <62474226+SingleAccretion@users.noreply.github.com> * Update src/coreclr/jit/codegenlinear.cpp Co-authored-by: NSingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
-
由 Tanner Gooding 提交于
* Refactor Lowering::IsContainableBinaryOp so node checks are simpler * Update Lowering::ContainCheckBinary to check both operands for a commutative oper * Updating Lowering::IsContainableBinaryOp to support some shifted register instructions * Resolving some build failures/asserts * Ensure IsContainableBinaryOp checks IsSafeToContainMem * Use parentNode not node * Ensure shifted register instructions that set flags use the right instruction * Ensure the shift amount is checked for smaller nodes * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: NSingleAccretion <62474226+SingleAccretion@users.noreply.github.com> Co-authored-by: NSingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
-
由 Elinor Fung 提交于
-
由 Qiao Pengcheng 提交于
* [LoongArch64] Fix the assert error for `genSetRegToIcon()` * delete the `genSetRegToIcon()` for LA64.
-
由 Tanner Gooding 提交于
* Ensure CreateScalarUnsafe gets constant handling on Arm64 * Clear constant reg during upper vector save * Apply formatting patch Co-authored-by: NKunal Pathak <Kunal.Pathak@microsoft.com>
-
由 Will Smith 提交于
* Disabling disasm checks under certain testing environments * Add extra linux musl check * Add JitDisasm check back * Remove JitDisasm check * Re-enable musl * Do not run disasm checks under stress modes * Feedback, force a failure * Trying to fix targets * Trying to fix targets * Update Runtime_34937.cs
-
由 Stephen Toub 提交于
- Expand it to all supported types with `Enumerable.Min<T>`/`Max<T>` - Combine Min/Max into a single method using a static abstract interface with generic specialization to differentiate - Use `Vector128<T>` and `Vector256<T>` instead of `Vector<T>` - Improve test coverage
-
- 27 9月, 2022 17 次提交
-
-
由 Zoltan Varga 提交于
[mono][aot] Prefer specific instances instead of gshared for methods containing static virtual calls. (#76033) These calls cannot be resolved at compile time in gshared methods, so they cannot be inlined etc. They are used in perf sensitive BCL code like SpanHelpers. To fix this, modify the AOT compiler so in addition to the gshared versions, it emits specific instances of these methods if possible. This only affects a small subset of gshared methods so it doesn't lead to a noticable code size increase. Fixes https://github.com/dotnet/runtime/issues/75801.
-
由 Sparin 提交于
ANSI string depends on system encoding charset. Unix's implementation of Marshal.StringToHGlobalAnsi encodes in UTF8. UTF8 characters which are out of 8-bit range (otcet) encodes in multiple bytes (otcets). ASCII characters usually are in 0x00-0x7F range but cyrillic and other characters are not. For example, 'Зфыы123;' (eq. 'Pass123$') will be encoded in 12 bytes instead of 8 Fix #76125
-
由 Stephen Toub 提交于
* Improve IPAddress to/from bytes perf Also cleaned up some unnecessary `!`s with `MemberNotNullWhen`. * Address PR feedback to use shifts instead of shuffle And also simplify fallback. * Avoid non-portable cast for big endian
-
由 Andy Ayers 提交于
One more preparatory step before introducing the new phi-based disambiguation. * handle some cases of ambiguous preds better * split out the jump threading pre checks into a helper * properly support updating switch preds * generalize retry logic a bit to handle more cases
-
由 Stephen Toub 提交于
* Extend RuntimeHelpers.IsBitwiseEquatable to more types Today, RuntimeHelpers.IsBitwiseEquatable is hardcoded to a fixed list of types. This means that almost all of the vectorization we've done with arrays and spans is limited to just those types; developers can themselves use MemoryMarshal.Cast to convert spans of other types to spans of supported one, but it doesn't naturally happen. This extends IsBitwiseEquatable a bit more. We already have a CanCompareBitsOrUseFastGetHashCode helper used by ValueType.Equals to determine whether structs that don't override Equals can be compared with the equivalent of memcmp. This extends that same helper to be used by IsBitwiseEquatable. However, IsBitwiseEquatable also needs to rule out types that implement `IEquatable<T>` (the existing helper doesn't because it's about the implementation of the object.Equals override where the interface doesn't come into play). The upside of this is APIs like Array.IndexOf will now automatically vectorize with more types. The main downside is that types which provide their own equality implementation still don't benefit, which in turn means adding an `IEquality<T>` implementation could in the future be a deoptimization (we should consider some kind of attribute or marker interface a type can use to say "I promise my equality implementation is the same as a bitwise comparison"). We also currently constrain most of our MemoryExtensions methods to types that implement `IEquatable<T>`, so there are only a handful of public methods today that benefit from this. * Fix contract on CanCompareBitsOrUseFastGetHashCode * Add more SequenceEqual tests * Remove duplicative check * Add IsBitwiseEquatable extension to ilc * Address PR feedback * Update src/coreclr/tools/Common/TypeSystem/IL/Stubs/ComparerIntrinsics.cs
-
由 Wei Chen 提交于
* Check for expression bodied method Fixed LoggerMessageGenerator parser to check for expression bodied method and generate a proper diagnostic message. Fix #66080 * Fix expression body in test Fixed invalid expression body in test
-
由 Tom Deseyn 提交于
* Use generated runtime.json when building shared framework packages. * Don't UpdateRuntimeJson on Build. * PR feedback. * Update Microsoft.NETCore.Platforms.csproj Co-authored-by: NViktor Hofer <viktor.hofer@microsoft.com>
-
由 Steve Dunn 提交于
* First pass * More annotations * Rever mistaken change to test * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * More annotations * Remove red flag comment * PR feedback * Remove 'red flag' comments * Revert unintended changes to tests * Revert unintended changes * PR feedback: remove redundant !'s from things that can never return null * Added `[MemberNotNullWhen(true, nameof(_cachedXml))]` on implementation. * Updated ref t ypes (with `dotnet msbuild /t:GenerateReferenceAssemblySource`) * Updated ref assembly * PR feedback: add `MemberNotNull` attribute on `Initialize`) * Updated ref again * Put `MemberNotNull` attribute on the getter rather than the property in the reference file. * PR feedback: remove MemberNotNullWhenAttribute from ref * PR feedback: non nullable param to match method in base class * Fix post-merge build errors * PR feedback * PR feedback from @bartonjs - add [DisallowNull] and cascade * PR feedback * PR feedback * PR feedback * Fix build again, by removing the `protected internal` property `CacheValid` * PR feedback * Added back `CacheValid` based on PR comment * Fix issues from recent rebase * Add `DisallowNull` attribute to ref file and remove it from `DefaultGenApiDocIds.txt` * PR feedback * Fix issues from recent merge * Remove some more extraneous damnit operators * Fix NRT analysis errors after prior rebase * PR feedback * PR feedback * PR feedback * PR feedback * PR feedback * CipherReference and CipherValue made to disallow null * Make Uri non-nullable on EnctrypedReference * Add AllowNull attribute on EncryptedType::KeyInfo * AllowNull on EncryptedXml::Recipient * Made baseUri nullable * DisallowNull on PropertlyElement * AllowNull on SignedInfo::CanonicalizationMethod * AllowNull on SignedXml::EncryptedXml * Fix build after recent rebase * Remove redundant damnit operator now that https://github.com/dotnet/runtime/pull/71860 has been merged * PR feedback * Fix build due to change of the CanonicalXmlElement constructor * PR feedback * Remove redundant damnit operators * Fix broken tests * Fix issues after rebase * PR feedback * PR feedback
-
由 Meri Khamoyan 提交于
* #74642 changed isolated storage path for mobile platforms
-
由 Matous Kozak 提交于
* Vector128 AndNot * swap operands for Vector128, block AndNot for integer types * fix AndNot intermediate type for Vector64 * move AndNot to XBINOP from SSE * AndNot intrinsics move check outside ifdef * defined macro * use different tmp variable * Re-use OP_SSE_ANDN code * remove space * missing {} in SN_AndNot case
-
由 SingleAccretion 提交于
* Spilling fixes * Unspilling fixes * Fix multi-reg HWIs
-
由 dotnet-maestro[bot] 提交于
[main] Update dependencies from dotnet/xharness dotnet/runtime-assets dotnet/runtime dotnet/emsdk (#76120) [main] Update dependencies from dotnet/xharness dotnet/runtime-assets dotnet/runtime dotnet/emsdk
-
由 Hyungju Lee 提交于
* Fix bugs found from static analyzer Co-authored-by: NJan Kotas <jkotas@microsoft.com>
-
由 Miepee 提交于
* Fix incorrect SpecialFolder entries for Unix This fixes an incorrect Documents/Personal for Linux+Mac entry, incorrect Videos Mac entry, and an incorrect (Local) ApplicationData Mac entry. Fix #63214 * Don't make Unix tests assume Personal is Home * Use the same value for Mac's (Local)ApplicationData * Use NSPaths for OSX Special Folder The Apple documentation recommends to use these instead of hardcoding the paths, so the paths that had NSPath equivalents have been replaced. * Change System.Native CMakeLists to include OSX for SearchPath `a17e73466ca639388a3d89f4d6be0ab9703802fc` made OSX call the native NSearchPath functions, however a stub was initially called. This fixes it to call the native functions.
-
由 Thays Grazia 提交于
* fix exception while decoding value that has a byref field * Apply suggestions from code review Co-authored-by: NLarry Ewing <lewing@microsoft.com> Co-authored-by: NLarry Ewing <lewing@microsoft.com>
-
由 Kevin Gosse 提交于
-