Commit migrated from https://github.com/dotnet/coreclr/commit/cc23e89ca1e28be6129d3aa30c5672aceba587e1

Update dependencies from https://github.com/dotnet/core-setup build 20190329.11 (dotnet/coreclr#23594)

- Microsoft.NETCore.App - 3.0.0-preview4-27529-11

Commit migrated from https://github.com/dotnet/coreclr/commit/8993ac60a06b8a63fa830375e09dcca45691b356

Commit migrated from https://github.com/dotnet/coreclr/commit/192a53da2f6f14c7e7fd2d21b2a25332912dfdda

Commit migrated from https://github.com/dotnet/coreclr/commit/b23ad3afc2276945c5c5ab60ecda32d6e0c821a3

Build test against corefx ref facade
Enable Assembly.Load(byte[], ...) test

Commit migrated from https://github.com/dotnet/coreclr/commit/57ea93ab397ac2b41112cd682aa749a97e2e5198

Remove Fedora runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/79b2ed74655a840c482b58c7eceaf96df20fa5c5

New machines are slower that we had before, so increate the timeout for the longest runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/2ca512927b7d8e8b4b4c8f8eb0cf7986d3115c0f

Commit migrated from https://github.com/dotnet/coreclr/commit/c7761a233b1e894bf9972d527aa85b02f6662cad

* Defining VariableLiveRange class

* Adding some typedefs to avoid rewriting

* Defining VariableLiveDescriptor class

* Initializing VariableLiveRange structures before BasicBlock code is being generated

* Getting a siVarLoc for variable homes from a given LclVarDsc and stack level

* Defining VariableLiveKeeper class

* Reporting VariableLiveRanges on changes of variable livenesss or variable homes

* Adding USING_VARIABLE_LIVE_RANGE flag to enable disable VariableLiveRange

* Send VariableLiveRanges to debugger

* Reporting variable homes on prolog

* Wrong argument

* Miss to change variable homes count before sending them to debugger

* Adding dumper of VariableLiveRanges for each blocks and end of code generation

* Close all open VaribleLiveRanges on last BasicBlock

* Changing order of properties initialization on VariableLiveRange constructor

* Type error on assignation

* Rephrasing comments, moving dumps and fixing typos

* Changing const VARSET_TP* for VARSET_VALARG_TP on args

* Variable home was variable location in VariableLiveRange context

* Rephrase and rename of VariableLiveKeeper properties

* Missing some renames

* Adding const where BasicBlock should not be modified

* siBeginBlock and siInit have support for debug code for VariableLiveRange and siScope info

* Adding USING_VARIABLE_LIVE_RANGE flags on methods definition.

* Variable home -> variable location

* Renaming and rephrasing names and uses of VariableLiveRange

* Moving LiveRangeDumper ctor to class declation

* Removing destructors
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Removing blank spaces and reordering functions inside class definition
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Miss to increment the index after refactoring

* Logic for keeping the last BasicBlock end IL offset is shared between siScope and VariableLiverange for debug code

* Missing to print on debug the last block VariableLiveRanges

* Avoid updating VariableLiveRange when unspilling and dying at the same assembly instruction

* Rephrasing #ifs and #ifdefs

* Calling VariableLiveKeeper in one line

* Avoid copying siVarLoc on genSetScopeInfo

* Removing unused args from eeSetLVinfo

* Changing VariableLiveKeeper ctor

* Typo
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Updating VariableLiveDescriptor ctor
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Error on first argument
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Changing reference for pointer
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Renaming assembly offset -> native offset

* removing unnecesary comments and asserts
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Update VariableLiveRange dump message
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Moving VariableLiveRanges classes inside VariableLiveKeeper

* Wrong flag name

* Adding documentation about how we track variables for debug info
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Adding opened issues to doc file
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Changing dump tittle
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Renaming VariableLiveKeeper property
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Update documentation
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Updating comments on flags
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>

* Setting Scope Info as default way of tracking variables for debug info
Signed-off-by: NBrian Bohe <brianbohe@gmail.com>


Commit migrated from https://github.com/dotnet/coreclr/commit/493023e6e1bc03ec04ee4aa9f390e37dc4d0906e

* Fix HW intrinsic containment bugs

For the Fma case (dotnet/coreclr#23430), fix the handling of contained 3-operand HW intrinsic nodes.
For the Bmi case (dotnet/coreclr#23534), fix a bad assert placement, and re-enable the Bmi tests.

Fix dotnet/coreclr#23530
Fix dotnet/coreclr#23534

* Add guard for Fma test


Commit migrated from https://github.com/dotnet/coreclr/commit/1df87c785e0e43392abf4bcba56e2bf4d9249fd4

Use normalized path for ALC name

Commit migrated from https://github.com/dotnet/coreclr/commit/8c7d91177742e150b91f11cf37da84b8f80f6620

GCStress fails there because it can't use external disasembler when it is available in CoreRoot.


Commit migrated from https://github.com/dotnet/coreclr/commit/519016d08d21f2f8bdb7f7c8a47a6914905523fe

Fix for issue 23411

Commit migrated from https://github.com/dotnet/coreclr/commit/12e7288df91d7c2fbc84be56e520535c1ee38382

New machines are slower that we had before, so increate the timeout for the longest runs.


Commit migrated from https://github.com/dotnet/coreclr/commit/fd81d2dfc658a1cfc7bf7957ef538b1ae2172989

* Extract `impAppendStmt` and `impExtractLastStmt`.

* Delete `BEG_STMTS` fake stmt.

Use new functions to keep the list updated.

* Retype `impTreeList` and `impTreeLast` as statements.
Rename `impTreeList` and `impTreeLast` to show that they are statements.

* Fix fields that have to be stmt.

* Start using GenTreeStmt.

Change `optVNAssertionPropCurStmt` to use GenTreeStmt.
Replace `GenTree* stmt = block->bbTreeList` with `GenTreeStmt* stmt = block->firstStmt()`.
Save results of `FirstNonPhiDef` as `GenTreeStmt`.

* Replace do-while with for loop.

* Change type inside VNAssertionPropVisitorInfo.

* Delete unused args fron `optVNConstantPropOnTree`.

* Update fields to be stmt.

Update optVNConstantPropCurStmt to use Stmt.
Change `lvDefStmt` to stmt.
Update LoopCloning structs.
Update `optDebugLogLoopCloning`.
Make `compCurStmt` a statement.
Update declaration name in `BuildNode`.

* Clean simple cpp files.

Clean valuenum.
Clean ssabuilder.
Clean simd.
Clean optcse.
Clean loopcloning.
Clean copyprop.
Clean optimizer part1.

* Start cleaning importer, morph, flowgraph, gentree.

* Continue clean functons.

Clean assertionprop.
Clean morph.
Clean gentree.
Clean flowgraph.
Clean compiler.
Clean rangecheck.
Clean indirectcalltransofrmer.
Clean others.

* Create some temp stmt.

* Delete unnecessary noway_assert and casts.

* Init `impStmtList` and `impLastStmt` in release.

* Response review 1.


Commit migrated from https://github.com/dotnet/coreclr/commit/311b5e2fe413c6c74a2a3680ab54d8a978651472

* Simplify and unify Vector64/128/256 platform-agnostic intrinsic handling

* Removed unsupported ISAs


Commit migrated from https://github.com/dotnet/coreclr/commit/4a4ba4d379002c8b8e77ef968f510cf0283201d0

It fixes COR_CTOR_METHOD_NAME_W and many other macros on Linux
to be of type char16_t[] (not wchar_t[]) by using W("") instead of L"".

Bug: dotnet/coreclr#21977

Commit migrated from https://github.com/dotnet/coreclr/commit/4e5a542537ea73c94d3443d9c82b05c744f76758

Commit migrated from https://github.com/dotnet/coreclr/commit/fee4d5f873efc37100bcbcf381401eb27434bb52

Correctly marshal structure return values in member functions on Win-x64 and Win-x86 (dotnet/coreclr#23145)

* In Windows-x64, if we have a native member function signature with a struct return type, we need to do a by-ref return.

* Implement support for marshalling structure return values via a return buffer argument correctly in instance signatures on AMD64-Windows.

* Change field initialization ordering to satisfy warning.

* Try to narrow down the conditions that trigger these changes to just COM methods.

* Don't bash the return type on AMD64 Windows. Only treat it as a byref return buffer.

* PR feedback.

* Enable returning structs from COM methods via a return buffer on x86 for structs <= 8 bytes.

* Add test for struct returns with ThisCall. Extend the "struct return buffer" fix to functions marked as unmanaged thiscall since they all must be instance methods

* Don't include the return-type-bashing switch on AMD64 platforms.

* Don't do the signature swapping/copy on non-instance functions with struct returns.

* Cast the return type of GetStubTargetCallingConv to the right calling convention enum type.

* If we're doing a thiscall, marshal the "this" parameter before the return buffer (if the return buffer exists) on all platforms.

* Remove temporary logging code I added in for debugging.

* Clean up class naming.

* Try using a vtable instead of a pointer-to-member-function.

* Remove delete of class with non-virtual destructor




Commit migrated from https://github.com/dotnet/coreclr/commit/6b889aba05b8e1ccc9cef793a2d1293e30598453

SSE abstraction for GCC and abstract __if_exists

Commit migrated from https://github.com/dotnet/coreclr/commit/cda8f7bf0a826878fc6ca6b9d7bc6f6011626cc9

* Change Timer implementation on Unixes to use only one scheduling thread

- Separated from https://github.com/dotnet/corert/pull/7066

* Address feedback from https://github.com/dotnet/corert/pull/7066

* Remove reference to s_lock

* Reduce work inside lock

* Move _id

* Fix duplicate timers in scheduled timer list, move info to TimerQueue
Signed-off-by: Ndotnet-bot <dotnet-bot@microsoft.com>


Commit migrated from https://github.com/dotnet/coreclr/commit/6e215e1faa8275c1468bcd059e29a530d2de0064

llvm


Commit migrated from https://github.com/dotnet/coreclr/commit/6a3af88cd2cefb8932b2965db64080c2a7c197ef

Enable SSE for GCC


Commit migrated from https://github.com/dotnet/coreclr/commit/446393da44258d60aaa9c660602fb826c79fe6b3

 Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively (dotnet/coreclr#23536)

* Removing FeedTasksPackageVersion from dependencies.props
* The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884

* Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively

* Adding a ! in String.Searching.cs


Commit migrated from https://github.com/dotnet/coreclr/commit/9f2b33e9e124c1a6be86fa83c21a1a8134a9ca10

Commit migrated from https://github.com/dotnet/coreclr/commit/dc0d0721aca6c6b1da99346dfb95de78d7c83d6f

* Clean `valuenum.cpp`.

* Clean `emitarm64.cpp`.

* Clean `lsraarm64.cpp`.

* Clean `lsraarmarch.cpp`.

* Clean `lowerarmarch.cpp`.

* Clean `lower.cpp`.

* Clean `ssabuilder.cpp`.

* Clean `simd.cpp`.

* Clear `simdcodegenxarch.cpp`.

* Clean `lowerxarch.cpp`.

* Clean `scopeinfo.cpp`.


Commit migrated from https://github.com/dotnet/coreclr/commit/ecf92d0664acc8a36ee7ae69efefca5bb5a7dee5

Commit migrated from https://github.com/dotnet/coreclr/commit/f3747cd376bd870e01eef9448de15dda97117ca1

No longer needed

Commit migrated from https://github.com/dotnet/coreclr/commit/b1b8718355a687c7223de9f4a45e10937d2bf3f1

Commit migrated from https://github.com/dotnet/coreclr/commit/ff25b931d519c1399838c3ac36ea41f264ae7cf3

* exclude failing in PRs tests

* And another one.

* Exclude for all platforms.


Commit migrated from https://github.com/dotnet/coreclr/commit/10510b5f9fae3361ec5b161b35014ae2cdefc009

* Delete `setup_coredis_tools` from runtest.py.

* delete dead `setup_coredis_tools` .


Commit migrated from https://github.com/dotnet/coreclr/commit/3483c6e33b47bd956c433c7437bffad7ab5aca21

Added test case GitHub_23411


Commit migrated from https://github.com/dotnet/coreclr/commit/cc04782de8f5a8f6eff0f8ff9e790c90edb3c68d

* Add test for IncrementingPollingCounter

* Fix a bug in Increment calculation in IncrementingPollingCounter

* Remove setting DisplayName property since that's a private property for now

* fix comment

* Remove unused variables


Commit migrated from https://github.com/dotnet/coreclr/commit/9517ad0821e339418b3d3d31145dc0bbb1afc38d

* exclude failing in PRs tests


Commit migrated from https://github.com/dotnet/coreclr/commit/72a3f75791be7d78c825ce1f4f02a54c8a7fa344

* Fix codegen for StoreNonTemporal

Also, add some asserts and mark some intrinsics as not supporting containment.

Fix dotnet/coreclr#23509


Commit migrated from https://github.com/dotnet/coreclr/commit/ffe8a331dca0edce1d5bc9537537ed2bfba31b71

Commit migrated from https://github.com/dotnet/coreclr/commit/d1f914ca36acf46aa64ebc35719f367b2ed1d96f

* [WIP] Struct & SIMD improvements

- Enable CSE of struct values when handle is available (and add code to get the handle of HW SIMD types)
- Don't require block nodes for SIMD assignments
- Don't set `GTF_GLOB_REF` on `GT_OBJ` if it is local
- Set `lvRegStruct` on promoted SIMD fields
- Add tests for dotnet/coreclr#19910 (fixed with this PR) and dotnet/coreclr#3539 & dotnet/coreclr#19438 (fixed with dotnet/coreclr#21314)
- Additional cleanup

Fix dotnet/coreclr#19910

Commit migrated from https://github.com/dotnet/coreclr/commit/3d4a1d5cea0ae71eed1482990ce6e575049829d8

* Fix Helix queue names

* Fix open Deb9 queue name.


Commit migrated from https://github.com/dotnet/coreclr/commit/a32f7e6b176fc18973581d48d919112d66e321aa

* dnceng-linux-internal-temp -> BuildPool.Ubuntu.1604.Amd64
* dotnet-internal-temp -> BuildPool.Windows.10.Amd64.VS2017


Commit migrated from https://github.com/dotnet/coreclr/commit/3027b9d4cc4ee4637834eec99c08b16bc54b38bb

Restore Windows arm32/arm64 innerloop build jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/2d0a5baba4cb1e4f09845d92f8d610a419a83f58