1. 03 11月, 2022 23 次提交
    • A
      [wasm] Bump tests timeout 15mins to 30mins, for .. (#77819) · 1f61914e
      Ankit Jain 提交于
      .. `xharness`.
      
      Some library tests, like `System.Text.RegularExpressions.Tests` can take more than 15mins.
      
      - Also, fix building `console-v8` sample with `make`
      1f61914e
    • T
      Use more spans in `System.Reflection.Metadata` et. al. (#76574) · b8a09066
      Theodore Tsirpanis 提交于
      * Use Unsafe.As in ImmutableByteArrayInterop.
      
      Code quality increases.
      
      * Optimize methods in the BlobUtilities class.
      
      * Include more information in exceptions thrown from catch blocks.
      
      * Use spans in BlobContentId, avoiding ImmutableByteArrayInterop.
      
      * Use spans in BlobWriter, reducing pinning and ImmutableArrayInterop.
      
      * Use spans in BlobBuilder, reducing pinning and ImmutableArrayInterop.
      
      * Remove NoInlining from the throw helpers.
      
      It prevents the JIT from looking into the method's body, realizing it's a throw helper, and doing what's best (such as considering it cold).
      
      * Inline `BlobUtilities.Read(Immutable)?Bytes`.
      
      * Avoid a length check introduced by the use of `BinaryPrimitives`.
      
      * Remove `DisallowNull` from `ImmutableArrayInterop.DangerousCreateFromUnderlyingArray`.
      
      * Remove an early bail-out if the buffer was empty.
      
      * Stop using value tuples.
      
      * Fix tests and expose writing a span to BlobWriter.
      
      * Fix stack overflows.
      
      * Shorten BlobUtilities methods that write integers.
      
      * Optimize some methods in `MemoryBlock`.
      b8a09066
    • M
    • M
      Fixes typos and formatting in comments (#76975) · 786d631a
      Michael Aranda 提交于
      786d631a
    • I
      Implement Environment.IsPrivilegedProcess (#77355) · aaf9c8a7
      Ilya 提交于
      * Implement Environment.IsPrivilegedProcess
      
      * Address feedback
      
      * Use one static
      
      * Fix mono wasm
      
      * Address feedback 2
      
      * Address feedback 3
      
      * Fix typo.
      
      * Fix wasm
      aaf9c8a7
    • R
      correct code snippets (#77581) · 35d88230
      RaymondY 提交于
      Let them be valid C# code. Uniform code style as well.
      35d88230
    • J
      Fix ThunkGenerator build break (#77816) · 53444431
      Jan Kotas 提交于
      Apply all style auto-fixers on ThunkGenerator
      53444431
    • J
      Fix wrong metadata name in test (#77806) · 21e99135
      Jakob Botsch Nielsen 提交于
      21e99135
    • A
      Update tar test data version (#77785) · 64b3ee4d
      Adeel Mujahid 提交于
      64b3ee4d
    • A
      JIT: Enable phi-based jump threading when SSA updates aren't needed (#77748) · 9b9aeafb
      Andy Ayers 提交于
      Leverage the new SSA accounting to look for cases of phi-based jump threading
      that will not require SSA updates. In particular cases where the phis are all
      locally consumed.
      
      Also update documentation on the SSA checker implementation (which aims to
      ensure that the SSA accounting we're relying on here is accurate).
      9b9aeafb
    • E
      Remove empty BEGIN/END_ENTRYPOINT_* macros (#77810) · 92971c9a
      Elinor Fung 提交于
      92971c9a
    • Z
    • A
      System.Threading.RateLimiting de-queue canceled request (#77182) · fbc20578
      Ali Khalili 提交于
      * Dequeue canceled request before making decision for processing queue’s requests
      fbc20578
    • C
      Update assembly version from hardcoded to MajorVersion (#74157) · f84c1b5c
      Carlos Sanchez 提交于
      * Update assembly version from hardcoded to MajorVersion
      
      * Bump version to 8 in XsdDataContractExporterTests
      
      * Retrieve major version dynamically for expected message in TypesTest_Negative
      
      * Retrieve major version dynamically for expected message in SurrogateProvider_MemberData
      
      * Manually generate the TestData.resources.
      The dotnet exec command generated by the msbuild Target had to be manually executed in the cmdline with the target framework folders for RemoteExecutor hardcoded to net7.0-windows so the resources file could be generated.
      
      * Avoid hardcoded 8 in additional SurrogateTests line
      
      * Fix Diagnostics.EventLog supression message
      
      * Update assembly version from hardcoded to MajorVersion
      
      * Bump version to 8 in XsdDataContractExporterTests
      
      * Retrieve major version dynamically for expected message in TypesTest_Negative
      
      * Retrieve major version dynamically for expected message in SurrogateProvider_MemberData
      
      * Manually generate the TestData.resources.
      The dotnet exec command generated by the msbuild Target had to be manually executed in the cmdline with the target framework folders for RemoteExecutor hardcoded to net7.0-windows so the resources file could be generated.
      
      * Avoid hardcoded 8 in additional SurrogateTests line
      
      * Fix Diagnostics.EventLog supression message
      
      * Extract the LocalEchoServer bits from the projects
      
      .. so that the helix bits are in a LocalEchoServer.helix.targets ,
      instead of being special-cased in sendtohelix-wasm.targets .
      - And this is setup and used by the test projects by importing one file.
      
      * Build the LocalEchoServers specifically without using artifacts .
      
      - The RemoteLoopServer, and NetCoreServer are projects used as aspnetcore
      middleware, and loaded by xharness.
      - These are built against the live artifacts, same as other projects.
          - But this can be a problem when the libraries in `runtime` are on a
          newer assembly version (say `8.0.0`), but xharness is still built with
          `7.0.0` libraries.
          - In that case, xharness fails to load the middleware:
      
      ```
      Application startup exception: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
      
      ...
      
      Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
      
         at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
         at System.Reflection.Assembly.GetTypes()
         at Microsoft.DotNet.XHarness.CLI.CommandArguments.TypeFromAssemblyArgument`1.GetLoadedTypes()+MoveNext() in /_/src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Arguments/TypeFromAssemblyArgument.cs:line 29
         at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.<>c__DisplayClass0_0.<Start>b__9(TestWebServerOptions options) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 60
         at Microsoft.Extensions.Options.OptionsFactory`1.Create(String name)
         at Microsoft.Extensions.Options.OptionsCache`1.<>c__3`1.<GetOrAdd>b__3_0(String name, ValueTuple`2 arg)
         at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd[TArg](TKey key, Func`3 valueFactory, TArg factoryArgument)
         at Microsoft.Extensions.Options.OptionsCache`1.GetOrAdd[TArg](String name, Func`3 createOptions, TArg factoryArgument)
         at Microsoft.DotNet.XHarness.CLI.Commands.WebServer.TestWebServerStartup.Configure(IApplicationBuilder app, IOptionsMonitor`1 optionsAccessor) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WebServer.cs:line 126
         at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
         at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
         at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
         at Microsoft.AspNetCore.Hosting.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)
         at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
         at Microsoft.AspNetCore.Hosting.WebHost.BuildApplication()
      ```
      
      - Build the project in isolation from rest of the repo, so that it is
      built with references only from the SDK. The built assembly can then be
      deployed for use with xharness, just like before.
      
      * add missing files
      
      * [wasm] fixup extensions targets for LocalEchoServer
      
      * [wasm] Use eng/targetingpacks.targets instead of wasm specific targets
      
      * [wasm] Avoid duplicate imports, and don't use the targetingpacks.targets
      
      .. for runtime tests since the paths are set explicitly in the project
      
      * [wasm] Workaround for https://github.com/dotnet/runtime/issues/77707
      
      The middleware projects are now being built separately, so they can
      target a different TFM. But when `RunAOTCompilation=true` is set, like
      on CI/AOT builds, the build breaks with:
      
      ```
      To build this project, the following workloads must be installed: macos [/__w/1/s/Build.proj]
      To install these workloads, run the following command: dotnet workload restore [/__w/1/s/Build.proj]
      ```
      
      This is described in https://github.com/dotnet/runtime/issues/77707 .
      And the issue is present in `7.0 rc1` also, which is currently used for
      building the repo. To workaround it, we unset some properties which
      aren't needed anyway for the middleware projects builds.
      Co-authored-by: Ncarlossanlop <carlossanlop@users.noreply.github.com>
      Co-authored-by: NAnkit Jain <radical@gmail.com>
      f84c1b5c
    • A
      Fix missing dispose on rate limiting (#76784) · 37bd664f
      Ali Khalili 提交于
      37bd664f
    • E
      d1c29603
    • D
      [main] Update dependencies from 7 repositories (#77594) · acd44456
      dotnet-maestro[bot] 提交于
      [main] Update dependencies from 7 repositories
      acd44456
    • D
      Fix triple slash documentation for System.Runtime.Intrinsics (#76687) · f5c67acf
      Drew Kersnar 提交于
      * Add missing type param documentation for Vector64.Create<T>
      
      * Add summaries to the Vector types
      
      * Fix typeparamref
      
      * Address PR feedback
      f5c67acf
    • D
      [main] Update dependencies from dotnet/linker (#77595) · 7bd30600
      dotnet-maestro[bot] 提交于
      * Update dependencies from https://github.com/dotnet/linker build 20221027.4
      
      Microsoft.NET.ILLink.Tasks
       From Version 7.0.100-1.22525.3 -> To Version 7.0.100-1.22527.4
      
      * Update dependencies from https://github.com/dotnet/linker build 20221031.1
      
      Microsoft.NET.ILLink.Tasks
       From Version 7.0.100-1.22525.3 -> To Version 7.0.100-1.22531.1
      
      * Update dependencies from https://github.com/dotnet/linker build 20221031.2
      
      Microsoft.NET.ILLink.Tasks
       From Version 7.0.100-1.22525.3 -> To Version 7.0.100-1.22531.2
      
      * Update dependencies from https://github.com/dotnet/linker build 20221101.1
      
      Microsoft.NET.ILLink.Tasks
       From Version 7.0.100-1.22525.3 -> To Version 7.0.100-1.22551.1
      Co-authored-by: Ndotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
      7bd30600
    • A
      Use SR.Format in a few more places (#77615) · 6d47f766
      Adeel Mujahid 提交于
      6d47f766
    • B
      Avoid reporting empty debug info ranges to the vm (#77289) · fdaaa61d
      Brian Bohe 提交于
      * Removing empty variable live ranges
      
      The debugger is not using empty variable live ranges.
      We are reporting them because they can get extended
      later if the variable becomes alive in the immediately
      next emitted instruction. If an empty live range is
      not getting extended, which we can realize after
      emitting all the code or creating a new live range
      for the same variable, we can remove it.
      
      * Extending variable live ranges in more cases
      
      When the emitter moved to the next group but has not
      emitted any instruction, and the variable died and
      becomes alive again, we would like to extend its range.
      
      * Avoiding creating a new debug range when previous is empty
      
      * Updating check for empty debug ranges
      
      * Updating print
      
      * Avoiding printing twice variable live range
      
      * Avoiding reporting empty variable ranges to the vm
      
      * Revert "Avoiding printing twice variable live range"
      
      This reverts commit 4e1cf47dd6cdf9d45ce4a51eaa05b3ec6e4b3b41.
      
      * Revert "Updating print"
      
      This reverts commit 7b79b0d955daa4dc9770b604d6780591b51c9ee1.
      
      * Revert "Updating check for empty debug ranges"
      
      This reverts commit e8b102d489d79028750068decf4f427ad8e5f69f.
      
      * Revert "Avoiding creating a new debug range when previous is empty"
      
      This reverts commit a11fd5d0ffaa98631d731bec1f2619f1d108d33a.
      
      * Revert "Extending variable live ranges in more cases"
      
      This reverts commit 609605a1ca7cf1c0c843dbaf353432ec9ed846e2.
      
      * Revert "Removing empty variable live ranges"
      
      This reverts commit 66d18e031f83c8efe864981b35c0548af49e0714.
      
      * Freeing vm memory when there is no debug info
      
      * Persisting JIT-EE contract on empty debug info
      
      * Update src/coreclr/jit/ee_il_dll.cpp
      Co-authored-by: NJakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
      Co-authored-by: NBrian Bohe <brianbohe@microsoft.com>
      Co-authored-by: NJakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
      fdaaa61d
    • T
      Mark and expose additional Vector functions as Intrinsic (#77562) · 13d4e6de
      Tanner Gooding 提交于
      * Mark and expose additional Vector functions as Intrinsic
      
      * Applying formatting patch
      
      * Ensure Vector64.CreateScalarUnsafe for long/ulong/double is handled
      
      * Ensure we use the right Count
      
      * Ensure small types don't sign extend up to int
      
      * Ensure reflection invocation is correct for Vector<T> bitwise ops
      
      * Adding tests and fixing a couple small typing issues
      
      * Fixing the name of the One property
      
      * Assert GT_RSH for simd isn't TYP_LONG on xarch
      
      * Ensure the correct operation is picked for vector ShiftRightArithmetic
      
      * Fixing StoreAlignedNonTemporal on Arm64
      13d4e6de
    • A
      [hot_reload] implement param reflection (#77563) · a27ecc51
      Aleksey Kliger (λgeek) 提交于
      * Add new test ReflectionAddNewMethod
      
      * FIXME: get_param_names, get_marshal_info and custom_attrs need work
      
      * WIP - add a method param reverse lookup
      
      * look up params from added methods
      
      * Remove FIXMEs and unused field
      
      * remove writelines from test
      
      * fix test on coreclr
      
      * why does coreclr have 2 attributes here??
      
      * There should be 2 attributes on the 4th param
      
      * one more place that looks at params
      
      * A couple more places where we look at the Params table
      
      * Check default values on params on added method
      
      * fix lookup if table is empty
      
      * add a gratuitious typeof assert
      
      otherwise the CancellationToken type is trimmed on wasm
      
      * Add a single mono_metadata_get_method_params function
      
      remove duplicated code
      a27ecc51
  2. 02 11月, 2022 17 次提交