The code tries to write the status from `rcClose`, but accidentally writes
out the value of `rc` instead.

memcpy is defined to only work when the source and destination memory
regions do not overlap. In here, they do. So let's use memmove instead.

Using NewHolder results in the data being `delete` d after it's used.
The underlying data is an array, so it should be `delete[]` ed instead.

These free() calls are done in the middle of the method body; it's
possible that a duplicate free() can be called on these at the cleanup
code that runs before the method returns. So set these pointers to null
after free()ing them to avoid free() already free()d memory.

* [wasm] Add $( WasmBuildAppAfterThisTarget) to control which target

.. triggers WasmAppBuild. Defaults to `Publish`.

* [wasm] emcc, mono-aot-cross doesn't like relative output paths

eg. `-o foo/bar.js`

.. so convert that to absolute paths.

* [wasm] Check for WasmMainJSPath close to it's use

* [wasm] Add new $(WasmGenerateAppBundle) to allow skipping app bundle

.. generation. This is useful when you want to do all the other steps
for wasm, but handle the packaging/bundle generation yourself. Eg.
Blazor

* [wasm] Ensure that generated dotnet.{js,wasm} get copied to the app dir

This is usually done as part of the bundle generation (NativeAssets).
But in cases when that step is being skipped, we still want to copy over
generated dotnet.{js,wasm} (eg. in case of AOT) to the app dir. This is
the case that blazor uses.

* [wasm] Allow skipping mono-cil-strip step

In some cases, eg. blazor (till we fix it), `mono-cil-strip` can break
the app, because of bugs, or linker issues etc.

Also, do this only in the AOT case.

* [wasm] Add support for building wasm projects outside the tree

.. using local runtime builds.

* [wasm] fix up the support for local build dir

* [wasm] add comments for new properties

* [wasm] LocalBuild.*: add more comments, validation

* [wasm] sample: Use BeforeTargets for Prepare target, as a psuedo test for that

Since we're in an IL stub, we don't need to support breakpoints in the stub itself. The debugger will try to resolve the target method and move the breakpoint there. In actuality, that's the part that's failing. Somewhere in the ReversePInvoke helper call chain, we're touching the secret arg register. As a result, when the debugger tries to move the breakpoint, it crashes. By doing the same work ourselves, the debugger doesn't need to resolve the stub secret arg since it never sees a breakpoint in the stub itself. Use UMEntryThunk::GetManagedTarget like what the old system used.

During my experimentation with callchain optimizations I noticed
that the profile map only contains meaningful information when
we're generating PDB or PerfMap at the same time - apparently I
had the PDB generation turned on during debugging so I overlooked
this.

Thanks

Tomas

This is showing up a bit on ASP.NET startup paths, and we can be more efficient in how we handle allocations and work.

Remove workaround after fixed with #47614

Based on Andy's advice I propose to harden makeExtraStructQueries
against drilling into types outside of the current compilation
version bubble similar to what we're already doing when promoting
struct fields. I have locally verified that it fixes the crash
Bruce described in the issue.

Thanks

Tomas

* Removing unecessary casts to float/double from the classlibnative COMSingle and COMDouble types

* Reordering NI_System_Math_* usages to make it easier to spot errors

* Removing unecessary support for Cos/Sin as "target intrinsics"

* Adding asserts and changing target cost for math intrinsics to be based on IsTargetIntrinsic

* Don't include PAL math wrappers where no additional functionality is needed

* Adding valuenum support for the remaining Math intrinsics, minus FMA and SinCos

* Allow constant folding for all math intrinsics when not IsReadyToRun is false

* Apply formatting patch

* Adding THROW_DECL to match functions to satisfy GCC

* noodes to nodes

* Removing ScaleB named intrinsics

* Update src/coreclr/jit/codegenxarch.cpp

* Consolidate Bitmap(Type, string) constructor

* Fix NRE in Bitmap(Type, string)

Add support for producing "callchain profile quality map", a new
auxiliary output file describing code layout properties w.r.t.
a given call chain profile.

Sample output for System.Private.CoreLib:

CHARACTERISTIC            | PAIR COUNT | CALL COUNT | PERCENTAGE
----------------------------------------------------------------
ENTRIES TOTAL             |        291 |     266229 |     100.00
RESOLVED ENTRIES          |        267 |     260172 |      97.72
UNRESOLVED ENTRIES        |         24 |       6057 |       2.28
NEAR (INTRA-PAGE) CALLS   |        145 |     109055 |      40.96
FAR (CROSS-PAGE) CALLS    |        122 |     151117 |      56.76

Thanks

Tomas

1. Use superpmi.py parallelism (per assembly), not crossgen2 parallelism.
This is both faster, and it avoids a problem I was seeing of sharing
violations opening the method context file during collection.
2. Work around https://github.com/dotnet/runtime/issues/47554:
crossgen2 doesn't like EnableExtraSuperPmiQueries=1, so disable it
for crossgen2 collections.
3. Fix issue when `resolveToken` throws an exception: the resulting
resolved token structure could be corrupt (it was for crossgen2 in
a case I saw that led to SPMI crashing), so zero it out and record
that instead.

With this, there is only one crashing issue for collecting Core_Root
libraries (Windows x64 Checked), but there are 77835 compilation
failures on replay (see https://github.com/dotnet/runtime/issues/47540).

* Add APIs to make nint/nuint match Int32 and others

* Add default argument to nint/nuint TryFormat

* Fix Api Compat error

* Add test to nint/nuint

* fix test error

* Revert #34861

* reinstate removed test

* Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
Co-authored-by: NStephen Toub <stoub@microsoft.com>
Co-authored-by: NStephen Toub <stoub@microsoft.com>

Removed WebSocketProtocol code and mentions of the assembly.
Moved ManagedWebSocket.cs from Common to System.Net.WebSockets.

Fixes #1493

If GetTempFileNameA fails, we don't free up the dynamically allocated
memory that tempfile_name points to.

* Avoid Marshal.SizeOf in EventSource

We're getting the marshalling size of an enum underlying type - there are not that many of those. I chose not to treat `char` and `bool`, but we could (the only other remaining options).

Calling into `Marshal.SizeOf` increases the risk that `EventSource` is going call itself recursively - see the comment at the beginning of the method.

This was originally introduced in https://github.com/dotnet/coreclr/pull/19205.

* Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

* Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

* Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

Somehow when it was ported to .NET Core, the transition from connecting to connected was switched to being done before the connect rather than after.  As a result, if the connection fails and the websocket is never initialized, subsequent use (misuse) ends up null ref'ing.  This restores the .NET Framework behavior, which was to dispose of the instance if the connect fails; subsequent operations then throw ObjectDisposedException.

Forthcoming edge-based instrumentation will need to handle some BBF_INTERNAL
blocks, so update main processing logic to accomodate this.

Also have `fgInstrument` return proper phase status, so we get after-phase
dumping if any instrumentation is added.

During my last PR about icordebug I included this error, fixing it.
Co-authored-by: Nthaystg <thaystg@users.noreply.github.com>

They were nearly identical already, move them to a common location.

* Add NotNullWhen(true) on Directory/File.Exists.

* Apply suggestions.

* Improve msg for missing libicu

* add comment

* add aka.ms

* better link

Same as https://github.com/dotnet/runtime/pull/47417

Cause a connection abort when HTTP/2-only frame and settings types are received in HTTP/3. (Progress toward HTTP/3 draft 31 compat) (#43287)

Send h3-29 through h3-31 for ALPN as we are compatible with all of them.
Move some of the loopback test code into the stream class rather than connection class.
Add a basic test for SETTINGS frame receipt.
Fix some tests that were explicitly using Http3LoopbackServer and did not see the new "Mock" QUIC setting introduced in https://github.com/dotnet/runtime/pull/43076

* Randomize SNI

* remove debug message

* Fix the http test

* Add explanation comment

* Remove accidental indentation

debugger-protocol.h was missing from the tarball
Co-authored-by: Nakoeplinger <akoeplinger@users.noreply.github.com>