未验证 提交 a58437f7 编写于 作者: J Jeff Handley 提交者: GitHub

Update stale comments that reference GitHub issues (#65932)

* Update comment in BinaryFormatterWriter to indicate a NRT bug won't be fixed

* Update comment to reflect known issue in .NET Framework

* Update comment to indicate a known issue
上级 68fb7fc6
......@@ -31,8 +31,8 @@ void RunWithExpectedCodePage(int expectedCodePage)
Assert.True(p.WaitForExit(WaitInMS));
};
// Don't test this on Windows containers, as the test is currently failing
// cf. https://github.com/dotnet/runtime/issues/42000
// Don't test this on Windows containers, as there is a known issue.
// See https://github.com/dotnet/runtime/issues/42000 for more details.
if (!OperatingSystem.IsWindows() || PlatformDetection.IsInContainer)
{
RunWithExpectedCodePage(Encoding.UTF8.CodePage);
......
......@@ -117,7 +117,7 @@ internal void WriteObject(NameInfo nameInfo, NameInfo? typeNameInfo, int numMemb
int assemId;
int objectId = (int)nameInfo._objectId;
Debug.Assert(typeNameInfo != null); // Explicitly called with null, asserting for now https://github.com/dotnet/runtime/issues/31402
Debug.Assert(typeNameInfo != null); // Explicitly called with null. Potential bug, but closed as Won't Fix: https://github.com/dotnet/runtime/issues/31402
string? objectName = objectId < 0 ?
typeNameInfo.NIname : // Nested Object
nameInfo.NIname; // Non-Nested
......
......@@ -390,7 +390,7 @@ public static IEnumerable<object[]> Groups_Basic_TestData()
yield return new object[] { engine, null, @"(cat)(\cZ*)(dog)", "asdlkcat\u001adogiwod", RegexOptions.None, new string[] { "cat\u001adog", "cat", "\u001a", "dog" } };
yield return new object[] { engine, null, @"(cat)(\cz*)(dog)", "asdlkcat\u001adogiwod", RegexOptions.None, new string[] { "cat\u001adog", "cat", "\u001a", "dog" } };
if (!PlatformDetection.IsNetFramework) // missing fix for https://github.com/dotnet/runtime/issues/24759
if (!PlatformDetection.IsNetFramework) // `\c[` was not handled in .NET Framework. See https://github.com/dotnet/runtime/issues/24759.
{
yield return new object[] { engine, null, @"(cat)(\c[*)(dog)", "asdlkcat\u001bdogiwod", RegexOptions.None, new string[] { "cat\u001bdog", "cat", "\u001b", "dog" } };
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册