Disable matching constants for vectors that needs upper half to be save/restore (#74110)

* Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)"

This reverts commit 24f5de4b.

* Revert "Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)""

This reverts commit 984120f0cde0d26f9768112296e68164cfe76c8e.

* Add partial save check

* Use the correct register type

src/coreclr/jit/lsra.cpp

@@ -2721,7 +2721,11 @@ bool LinearScan::isMatchingConstant(RegRecord* physRegRecord, RefPosition* refPo
 
         case GT_CNS_VEC:
         {
-            return GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());
+            return
+#if FEATURE_PARTIAL_SIMD_CALLEE_SAVE
+                !Compiler::varTypeNeedsPartialCalleeSave(physRegRecord->assignedInterval->registerType) &&
+#endif
+                GenTreeVecCon::Equals(refPosition->treeNode->AsVecCon(), otherTreeNode->AsVecCon());
         }
 
         default: